From 25b17436b1b73fc7bb0220bd2ed33a32e54420e1 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Tue, 30 Apr 2024 13:58:29 -0400 Subject: [PATCH] fix types --- .../test/generic/focus-controller.e2e.ts | 9 +++++---- .../focus-controller/test/ionic/focus-controller.e2e.ts | 9 +++++---- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/core/src/utils/focus-controller/test/generic/focus-controller.e2e.ts b/core/src/utils/focus-controller/test/generic/focus-controller.e2e.ts index ae2771693f9..dd10bd59905 100644 --- a/core/src/utils/focus-controller/test/generic/focus-controller.e2e.ts +++ b/core/src/utils/focus-controller/test/generic/focus-controller.e2e.ts @@ -1,5 +1,6 @@ import { expect } from '@playwright/test'; import { configs, test } from '@utils/test/playwright'; +import type { E2ELocator } from '@utils/test/playwright'; configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { test.describe(title('focus controller: generic components'), () => { @@ -8,7 +9,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { }); test('should focus heading', async ({ page }) => { const goToPageOneButton = page.locator('page-root button.page-one'); - const nav = page.locator('ion-nav'); + const nav = page.locator('ion-nav') as E2ELocator; const ionNavDidChange = await (nav as any).spyOnEvent('ionNavDidChange'); // Focus heading on Page One @@ -21,7 +22,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { test('should focus banner', async ({ page }) => { const goToPageThreeButton = page.locator('page-root button.page-three'); - const nav = page.locator('ion-nav'); + const nav = page.locator('ion-nav') as E2ELocator; const ionNavDidChange = await (nav as any).spyOnEvent('ionNavDidChange'); const pageThreeHeader = page.locator('page-three header'); @@ -33,7 +34,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { test('should focus content', async ({ page }) => { const goToPageTwoButton = page.locator('page-root button.page-two'); - const nav = page.locator('ion-nav'); + const nav = page.locator('ion-nav') as E2ELocator; const ionNavDidChange = await (nav as any).spyOnEvent('ionNavDidChange'); const pageTwoContent = page.locator('page-two main'); @@ -47,7 +48,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { test.skip(browserName === 'webkit', 'Desktop Safari does not consider buttons to be focusable'); const goToPageOneButton = page.locator('page-root button.page-one'); - const nav = page.locator('ion-nav'); + const nav = page.locator('ion-nav') as E2ELocator; const ionNavDidChange = await (nav as any).spyOnEvent('ionNavDidChange'); const pageOneBackButton = page.locator('page-one ion-back-button'); diff --git a/core/src/utils/focus-controller/test/ionic/focus-controller.e2e.ts b/core/src/utils/focus-controller/test/ionic/focus-controller.e2e.ts index d31b1d2b89e..8b576872b83 100644 --- a/core/src/utils/focus-controller/test/ionic/focus-controller.e2e.ts +++ b/core/src/utils/focus-controller/test/ionic/focus-controller.e2e.ts @@ -1,5 +1,6 @@ import { expect } from '@playwright/test'; import { configs, test } from '@utils/test/playwright'; +import type { E2ELocator } from '@utils/test/playwright'; configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { test.describe(title('focus controller: ionic components'), () => { @@ -8,7 +9,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { }); test('should focus heading', async ({ page }) => { const goToPageOneButton = page.locator('page-root ion-button.page-one'); - const nav = page.locator('ion-nav'); + const nav = page.locator('ion-nav') as E2ELocator; const ionNavDidChange = await (nav as any).spyOnEvent('ionNavDidChange'); // Focus heading on Page One @@ -21,7 +22,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { test('should focus banner', async ({ page }) => { const goToPageThreeButton = page.locator('page-root ion-button.page-three'); - const nav = page.locator('ion-nav'); + const nav = page.locator('ion-nav') as E2ELocator; const ionNavDidChange = await (nav as any).spyOnEvent('ionNavDidChange'); const pageThreeHeader = page.locator('page-three ion-header'); @@ -33,7 +34,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { test('should focus content', async ({ page }) => { const goToPageTwoButton = page.locator('page-root ion-button.page-two'); - const nav = page.locator('ion-nav'); + const nav = page.locator('ion-nav') as E2ELocator; const ionNavDidChange = await (nav as any).spyOnEvent('ionNavDidChange'); const pageTwoContent = page.locator('page-two ion-content'); @@ -47,7 +48,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { test.skip(browserName === 'webkit', 'Desktop Safari does not consider buttons to be focusable'); const goToPageOneButton = page.locator('page-root ion-button.page-one'); - const nav = page.locator('ion-nav'); + const nav = page.locator('ion-nav') as E2ELocator; const ionNavDidChange = await (nav as any).spyOnEvent('ionNavDidChange'); const pageOneBackButton = page.locator('page-one ion-back-button');