From 5f2001c43c0846ec8973cbb8eb5662976ba7e31a Mon Sep 17 00:00:00 2001 From: Thomas Clark Date: Fri, 29 May 2020 19:35:34 +0100 Subject: [PATCH] fix(reorder-group): revert item to original position when passing false to complete (#21396) fixes #19128 --- core/src/components/reorder-group/reorder-group.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/components/reorder-group/reorder-group.tsx b/core/src/components/reorder-group/reorder-group.tsx index b49aa486489..d3f43fd1336 100644 --- a/core/src/components/reorder-group/reorder-group.tsx +++ b/core/src/components/reorder-group/reorder-group.tsx @@ -219,7 +219,7 @@ export class ReorderGroup implements ComponentInterface { const toIndex = this.lastToIndex; const fromIndex = indexForItem(selectedItemEl); - if (toIndex !== fromIndex && (!listOrReorder || listOrReorder === true)) { + if (toIndex !== fromIndex && (listOrReorder === undefined || listOrReorder === true)) { const ref = (fromIndex < toIndex) ? children[toIndex + 1] : children[toIndex];