From 0c6367697e357ebf34eb08f2d59852259b9cb402 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Mon, 18 May 2020 13:16:19 +0000 Subject: [PATCH 1/2] fix a11y for menu button --- core/src/components/menu-button/menu-button.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/src/components/menu-button/menu-button.tsx b/core/src/components/menu-button/menu-button.tsx index 5fed2e38e2e..6b1f04c1be1 100644 --- a/core/src/components/menu-button/menu-button.tsx +++ b/core/src/components/menu-button/menu-button.tsx @@ -77,6 +77,7 @@ export class MenuButton implements ComponentInterface, ButtonInterface { onClick={this.onClick} aria-disabled={disabled ? 'true' : null} aria-hidden={hidden ? 'true' : null} + aria-label="menu" class={{ [mode]: true, @@ -98,7 +99,7 @@ export class MenuButton implements ComponentInterface, ButtonInterface { > - + {mode === 'md' && } From d29a6f1bff85efd79b47a54f13215d754ffb5f00 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Mon, 18 May 2020 14:44:41 +0000 Subject: [PATCH 2/2] fix label on ios --- core/src/components/menu-button/menu-button.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/components/menu-button/menu-button.tsx b/core/src/components/menu-button/menu-button.tsx index 6b1f04c1be1..2b214e95649 100644 --- a/core/src/components/menu-button/menu-button.tsx +++ b/core/src/components/menu-button/menu-button.tsx @@ -77,7 +77,6 @@ export class MenuButton implements ComponentInterface, ButtonInterface { onClick={this.onClick} aria-disabled={disabled ? 'true' : null} aria-hidden={hidden ? 'true' : null} - aria-label="menu" class={{ [mode]: true, @@ -96,6 +95,7 @@ export class MenuButton implements ComponentInterface, ButtonInterface { {...attrs} disabled={disabled} class="button-native" + aria-label="menu" >