Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 8.1: Fixed touch scrolling and the js errors #2518

Merged
merged 14 commits into from Feb 3, 2015

Conversation

@dkarzon
Copy link

@dkarzon dkarzon commented Nov 8, 2014

Working with ionic on Windows 8.1 most of it is working great.

The main problem I had was the touch scrolling didn't work. This fix for this is to add the -ms-content-zooming: none; to the body tag. This tag disables user zooming which seems to cause the mspointer events to be incorrectly fired resulting in touch scrolling not working.

The others were javascript errors I'd come across, mainly related to methods that don't exist or are unsupported. Windows Store javascript apps fail certification if there are any js errors during the certification process.

@adamdbradley
Copy link
Member

@adamdbradley adamdbradley commented Nov 18, 2014

Awesome work thanks, we'll have @perrygovier take a look at this as he's making some scrolling improvements right now. Thanks!

@perrygovier
Copy link
Member

@perrygovier perrygovier commented Nov 21, 2014

Thanks for this @dkarzon, I took a look at our 8.0 Lumia, and I'm not noticing a difference. Can you provide an example of what this fixes, or is it something specific to 8.1? The Lumia 820 we have isn't eligible for an update yet.

@dkarzon
Copy link
Author

@dkarzon dkarzon commented Nov 21, 2014

Actually this fix I more for Windows 8.1 (Windows Store apps) but also affects the native JavaScript projects on Windows 8.1

So more for devices like the Microsoft Surface.

@dkarzon
Copy link
Author

@dkarzon dkarzon commented Nov 21, 2014

Just some further info, the Cordova solution for WP8 is a Silverlight app with a webview embedded but on Windows 8.1 and Windows Phone 8.1 javascript apps are natively supported using an IE11 AppHost. The Silverlight solution works fine its just the native javascript apps that do not because they implement the touch event differently.

adamdbradley added a commit that referenced this pull request Feb 3, 2015
fix(windows8.1): touch scrolling
@adamdbradley adamdbradley merged commit a5e93a0 into ionic-team:master Feb 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants