Skip to content

refactor(input): deprecate accept property #25501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2022
Merged

refactor(input): deprecate accept property #25501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0835e3
refactor(): deprecate accept property
liamdebeasi Jun 17, 2022
7dd0117
Merge branch 'main' into input-accept
liamdebeasi Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions core/src/components.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1002,7 +1002,8 @@ export namespace Components {
}
interface IonInput {
/**
* If the value of the type attribute is `"file"`, then this attribute will indicate the types of files that the server accepts, otherwise it will be ignored. The value must be a comma-separated list of unique content type specifiers.
* This attribute is ignored.
* @deprecated
*/
"accept"?: string;
/**
Expand Down Expand Up @@ -1078,7 +1079,7 @@ export namespace Components {
*/
"mode"?: "ios" | "md";
/**
* If `true`, the user can enter more than one value. This attribute applies when the type attribute is set to `"email"` or `"file"`, otherwise it is ignored.
* If `true`, the user can enter more than one value. This attribute applies when the type attribute is set to `"email"`, otherwise it is ignored.
*/
"multiple"?: boolean;
/**
Expand Down Expand Up @@ -4928,7 +4929,8 @@ declare namespace LocalJSX {
}
interface IonInput {
/**
* If the value of the type attribute is `"file"`, then this attribute will indicate the types of files that the server accepts, otherwise it will be ignored. The value must be a comma-separated list of unique content type specifiers.
* This attribute is ignored.
* @deprecated
*/
"accept"?: string;
/**
Expand Down Expand Up @@ -5000,7 +5002,7 @@ declare namespace LocalJSX {
*/
"mode"?: "ios" | "md";
/**
* If `true`, the user can enter more than one value. This attribute applies when the type attribute is set to `"email"` or `"file"`, otherwise it is ignored.
* If `true`, the user can enter more than one value. This attribute applies when the type attribute is set to `"email"`, otherwise it is ignored.
*/
"multiple"?: boolean;
/**
Expand Down
5 changes: 3 additions & 2 deletions core/src/components/input/input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ export class Input implements ComponentInterface {
@Prop({ reflect: true }) color?: Color;

/**
* If the value of the type attribute is `"file"`, then this attribute will indicate the types of files that the server accepts, otherwise it will be ignored. The value must be a comma-separated list of unique content type specifiers.
* This attribute is ignored.
* @deprecated
*/
@Prop() accept?: string;

Expand Down Expand Up @@ -143,7 +144,7 @@ export class Input implements ComponentInterface {
@Prop() minlength?: number;

/**
* If `true`, the user can enter more than one value. This attribute applies when the type attribute is set to `"email"` or `"file"`, otherwise it is ignored.
* If `true`, the user can enter more than one value. This attribute applies when the type attribute is set to `"email"`, otherwise it is ignored.
*/
@Prop() multiple?: boolean;

Expand Down