From 4350d0cab828d7f21bfa38349eba2c2d46179098 Mon Sep 17 00:00:00 2001 From: Brandy Carney Date: Tue, 4 Apr 2023 12:27:16 -0400 Subject: [PATCH 1/2] fix(picker-column-internal): hide empty picker items from screenreaders --- .../picker-column-internal.tsx | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/core/src/components/picker-column-internal/picker-column-internal.tsx b/core/src/components/picker-column-internal/picker-column-internal.tsx index 883923c4d89..a72e25d1a2c 100644 --- a/core/src/components/picker-column-internal/picker-column-internal.tsx +++ b/core/src/components/picker-column-internal/picker-column-internal.tsx @@ -403,9 +403,9 @@ export class PickerColumnInternal implements ComponentInterface { ['picker-column-numeric-input']: numericInput, })} > -
 
-
 
-
 
+ + + {items.map((item, index) => { { /* @@ -435,9 +435,9 @@ export class PickerColumnInternal implements ComponentInterface { ); })} -
 
-
 
-
 
+ + + ); } From dc7738748cb0d597491a2220a05439b9bfbc8c49 Mon Sep 17 00:00:00 2001 From: Brandy Carney Date: Tue, 4 Apr 2023 13:54:05 -0400 Subject: [PATCH 2/2] style(lint): fix lint --- .../picker-column-internal.tsx | 24 ++++++++++++++----- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/core/src/components/picker-column-internal/picker-column-internal.tsx b/core/src/components/picker-column-internal/picker-column-internal.tsx index a72e25d1a2c..6682603486d 100644 --- a/core/src/components/picker-column-internal/picker-column-internal.tsx +++ b/core/src/components/picker-column-internal/picker-column-internal.tsx @@ -403,9 +403,15 @@ export class PickerColumnInternal implements ComponentInterface { ['picker-column-numeric-input']: numericInput, })} > - - - + + + {items.map((item, index) => { { /* @@ -435,9 +441,15 @@ export class PickerColumnInternal implements ComponentInterface { ); })} - - - + + + ); }