fix(select): modern syntax works with forms #27480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
liamdebeasi
changed the title
liamdebeasi
changed the title
sean-perkins
approved these changes
May 15, 2023
github-actions
bot
added
package: react
liamdebeasi
force-pushed
the
FW-4351
branch
2 times, most recently
from
330280e
to
920157d
Compare
github-actions
bot
removed
package: react
|
Accidentally pushed a React commit from a different patch which added Amanda as a reviewer. I removed the wrong commit and removed Amanda as a reviewer, but still feel free to review if you'd like! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #27478
What is the current behavior?
The modern syntax render function was missing
renderHiddenInputwhich caused modernion-selectinstances to not participate in form submission. Legacy syntax is not affected.What is the new behavior?
renderHiddenInput.Does this introduce a breaking change?
Other information
Dev build:
7.0.7-dev.11684158250.1920157d