From 2eccfba18868f79e47fba81d96c5c26c0a2a7b3f Mon Sep 17 00:00:00 2001 From: Maria Hutt Date: Thu, 19 Oct 2023 16:41:29 -0700 Subject: [PATCH 1/2] fix(radio): tabbing --- core/src/components/radio/test/legacy/a11y/radio.e2e.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/src/components/radio/test/legacy/a11y/radio.e2e.ts b/core/src/components/radio/test/legacy/a11y/radio.e2e.ts index c3567e26cf0..ed831e9dda5 100644 --- a/core/src/components/radio/test/legacy/a11y/radio.e2e.ts +++ b/core/src/components/radio/test/legacy/a11y/radio.e2e.ts @@ -7,7 +7,7 @@ import { configs, test } from '@utils/test/playwright'; configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => { test.describe(title('radio: a11y'), () => { // TODO(FW-5218) - test.fixme('tabbing should switch between radio groups', async ({ page, pageUtils }) => { + test('tabbing should switch between radio groups', async ({ page, pageUtils }) => { await page.goto(`/src/components/radio/test/legacy/a11y`, config); const firstGroupRadios = page.locator('#first-group ion-radio'); @@ -23,7 +23,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => await expect(firstGroupRadios.nth(0)).toBeFocused(); }); // TODO(FW-5218) - test.fixme('using arrow keys should move between enabled radios within group', async ({ page, pageUtils }) => { + test('using arrow keys should move between enabled radios within group', async ({ page, pageUtils }) => { await page.goto(`/src/components/radio/test/legacy/a11y`, config); const firstGroupRadios = page.locator('#first-group ion-radio'); From d99449aba4b4524be3ad6b26de5d972f0fca0ff4 Mon Sep 17 00:00:00 2001 From: Maria Hutt Date: Fri, 20 Oct 2023 13:20:54 -0700 Subject: [PATCH 2/2] fix(radio): skip Safari --- .../src/components/radio/test/legacy/a11y/radio.e2e.ts | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/core/src/components/radio/test/legacy/a11y/radio.e2e.ts b/core/src/components/radio/test/legacy/a11y/radio.e2e.ts index ed831e9dda5..af6ccbfeb2b 100644 --- a/core/src/components/radio/test/legacy/a11y/radio.e2e.ts +++ b/core/src/components/radio/test/legacy/a11y/radio.e2e.ts @@ -6,10 +6,11 @@ import { configs, test } from '@utils/test/playwright'; */ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => { test.describe(title('radio: a11y'), () => { - // TODO(FW-5218) - test('tabbing should switch between radio groups', async ({ page, pageUtils }) => { + test.beforeEach(async ({ page, skip }) => { + skip.browser('webkit', 'Tabbing is flaky in Safari'); await page.goto(`/src/components/radio/test/legacy/a11y`, config); - + }); + test('tabbing should switch between radio groups', async ({ page, pageUtils }) => { const firstGroupRadios = page.locator('#first-group ion-radio'); const secondGroupRadios = page.locator('#second-group ion-radio'); @@ -22,10 +23,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => await pageUtils.pressKeys('shift+Tab'); await expect(firstGroupRadios.nth(0)).toBeFocused(); }); - // TODO(FW-5218) test('using arrow keys should move between enabled radios within group', async ({ page, pageUtils }) => { - await page.goto(`/src/components/radio/test/legacy/a11y`, config); - const firstGroupRadios = page.locator('#first-group ion-radio'); await pageUtils.pressKeys('Tab');