To test for regressions, I run the E2E tests on desktop Chrome with gulp snapshot. The results were the same with and without this change. Here are the popover-related results:
should init - pass
should open left side ios popover - pass
should close ios popover when clicking backdrop - fail
should open middle ios popover - pass
should open right ios popover - fail
should open left side android popover - fail
should close android popover when clicking backdrop - fail
should open middle android popover - pass
should open right android popover - fail
So some failures, but as said, same result before and after the contents of this pull request.
gulp karma passes on my environment also with this pull request's content:
Chrome 39.0.2171 (Mac OS X 10.9.5): Executed 864 of 864 SUCCESS (6.959 secs / 6.869 secs)
By the way, to run the snapshot tests locally, I had to do two edits:
I noticed was that commit 7d000de changed the location to which demos ended up being generated so had to revert that for the test runner to find the demos.
The tests didn't execute if the IonicReporter was enabled in the configs like it was by default. As a workaround, I commented out the reporter from config/lib/ionic-snapshot.js line 138.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.