diff --git a/.github/workflows/actions/test-core-screenshot/action.yml b/.github/workflows/actions/test-core-screenshot/action.yml index 52596467d39..d9cf4bf6f50 100644 --- a/.github/workflows/actions/test-core-screenshot/action.yml +++ b/.github/workflows/actions/test-core-screenshot/action.yml @@ -7,6 +7,8 @@ inputs: description: 'Playwright total number of test shards (ex: 4)' update: description: 'Whether or not to update the reference snapshots' + component: + description: 'The component to update the reference snapshots' runs: using: 'composite' @@ -23,9 +25,29 @@ runs: run: npm install && npx playwright install && npx playwright install-deps shell: bash working-directory: ./core + - id: clean-component-name + name: Clean Component Name + # Remove `ion-` prefix from the `component` variable if it exists. + run: | + echo "component=$(echo ${{ inputs.component }} | sed 's/ion-//g')" >> $GITHUB_OUTPUT + shell: bash + - id: set-test-file + name: Set Test File + # Screenshots can be updated for all components or specified component(s). + # If the `component` variable is set, then the test has the option to + # - run all the file paths that are in a component folder. + # -- For example: if the `component` value is "item", then the test will run all the file paths that are in the "src/components/item" folder. + # -- For example: if the `component` value is "item chip", then the test will run all the file paths that are in the "src/components/item" and "src/components/chip" folders. + run: | + if [ -n "${{ steps.clean-component-name.outputs.component }}" ]; then + echo "testFile=\$(echo '${{ steps.clean-component-name.outputs.component }}' | awk '{for(i=1;i<=NF;i++) \$i=\"src/components/\"\$i}1')" >> $GITHUB_OUTPUT + else + echo "testFile=$(echo '')" >> $GITHUB_OUTPUT + fi + shell: bash - name: Test if: inputs.update != 'true' - run: npm run test.e2e -- --shard=${{ inputs.shard }}/${{ inputs.totalShards }} + run: npm run test.e2e ${{ steps.set-test-file.outputs.testFile }} -- --shard=${{ inputs.shard }}/${{ inputs.totalShards }} shell: bash working-directory: ./core - name: Test and Update @@ -47,7 +69,7 @@ runs: # which is why we not using the upload-archive # composite step here. run: | - npm run test.e2e -- --shard=${{ inputs.shard }}/${{ inputs.totalShards }} --update-snapshots + npm run test.e2e ${{ steps.set-test-file.outputs.testFile }} -- --shard=${{ inputs.shard }}/${{ inputs.totalShards }} --update-snapshots git add src/\*.png --force mkdir updated-screenshots cd ../ && rsync -R --progress $(git diff --name-only --cached) core/updated-screenshots diff --git a/.github/workflows/assign-issues.yml b/.github/workflows/assign-issues.yml new file mode 100644 index 00000000000..da273a8c4ba --- /dev/null +++ b/.github/workflows/assign-issues.yml @@ -0,0 +1,18 @@ +name: Assign issues to triage + +on: + issues: + types: [opened] + +jobs: + auto-assign: + runs-on: ubuntu-latest + permissions: + issues: write + steps: + - name: 'Auto-assign issue' + uses: pozil/auto-assign-issue@edee9537367a8fbc625d27f9e10aa8bad47b8723 # v1.13.0 + with: + assignees: liamdebeasi, sean-perkins, brandyscarney, amandaejohnston, mapsandapps, thetaPC + numOfAssignee: 1 + allowSelfAssign: false diff --git a/.github/workflows/update-screenshots.yml b/.github/workflows/update-screenshots.yml index 7ff2c499013..b78a13c42a6 100644 --- a/.github/workflows/update-screenshots.yml +++ b/.github/workflows/update-screenshots.yml @@ -2,6 +2,11 @@ name: 'Update Reference Screenshots' on: workflow_dispatch: + inputs: + component: + description: 'What component(s) should be updated? (leave blank to update all or use a space-separated list for multiple components)' + required: false + default: '' jobs: build-core: @@ -34,6 +39,7 @@ jobs: shard: ${{ matrix.shard }} totalShards: ${{ matrix.totalShards }} update: true + component: ${{ inputs.component }} update-reference-screenshots: runs-on: ubuntu-latest diff --git a/CHANGELOG.md b/CHANGELOG.md index bab77c44f56..103bb521276 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,20 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [7.6.7](https://github.com/ionic-team/ionic-framework/compare/v7.6.6...v7.6.7) (2024-01-31) + + +### Bug Fixes + +* **accordion:** prevent opening of readonly accordion using keyboard ([#28865](https://github.com/ionic-team/ionic-framework/issues/28865)) ([e10f49c](https://github.com/ionic-team/ionic-framework/commit/e10f49c43daa11fe7deb5a9b9bfd34897542b6b1)), closes [#28344](https://github.com/ionic-team/ionic-framework/issues/28344) +* **action-sheet, alert, toast:** button roles autocomplete with available options ([#27940](https://github.com/ionic-team/ionic-framework/issues/27940)) ([f6fc22b](https://github.com/ionic-team/ionic-framework/commit/f6fc22bba60388701b80a9421510e3d843d39e9e)), closes [#27965](https://github.com/ionic-team/ionic-framework/issues/27965) +* **item:** ensure button focus state on property change ([#28892](https://github.com/ionic-team/ionic-framework/issues/28892)) ([bf7922c](https://github.com/ionic-team/ionic-framework/commit/bf7922c8b37b32dbf90650cb74a2e77bedf0c118)), closes [#28525](https://github.com/ionic-team/ionic-framework/issues/28525) +* **item:** only default slot content wraps ([#28773](https://github.com/ionic-team/ionic-framework/issues/28773)) ([9448783](https://github.com/ionic-team/ionic-framework/commit/9448783bb19b187f867054c86d215e3dc97952c1)), closes [#28769](https://github.com/ionic-team/ionic-framework/issues/28769) + + + + + ## [7.6.6](https://github.com/ionic-team/ionic-framework/compare/v7.6.5...v7.6.6) (2024-01-24) diff --git a/core/CHANGELOG.md b/core/CHANGELOG.md index de77edeea80..99bb0982564 100644 --- a/core/CHANGELOG.md +++ b/core/CHANGELOG.md @@ -3,6 +3,20 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [7.6.7](https://github.com/ionic-team/ionic-framework/compare/v7.6.6...v7.6.7) (2024-01-31) + + +### Bug Fixes + +* **accordion:** prevent opening of readonly accordion using keyboard ([#28865](https://github.com/ionic-team/ionic-framework/issues/28865)) ([e10f49c](https://github.com/ionic-team/ionic-framework/commit/e10f49c43daa11fe7deb5a9b9bfd34897542b6b1)), closes [#28344](https://github.com/ionic-team/ionic-framework/issues/28344) +* **action-sheet, alert, toast:** button roles autocomplete with available options ([#27940](https://github.com/ionic-team/ionic-framework/issues/27940)) ([f6fc22b](https://github.com/ionic-team/ionic-framework/commit/f6fc22bba60388701b80a9421510e3d843d39e9e)), closes [#27965](https://github.com/ionic-team/ionic-framework/issues/27965) +* **item:** ensure button focus state on property change ([#28892](https://github.com/ionic-team/ionic-framework/issues/28892)) ([bf7922c](https://github.com/ionic-team/ionic-framework/commit/bf7922c8b37b32dbf90650cb74a2e77bedf0c118)), closes [#28525](https://github.com/ionic-team/ionic-framework/issues/28525) +* **item:** only default slot content wraps ([#28773](https://github.com/ionic-team/ionic-framework/issues/28773)) ([9448783](https://github.com/ionic-team/ionic-framework/commit/9448783bb19b187f867054c86d215e3dc97952c1)), closes [#28769](https://github.com/ionic-team/ionic-framework/issues/28769) + + + + + ## [7.6.6](https://github.com/ionic-team/ionic-framework/compare/v7.6.5...v7.6.6) (2024-01-24) diff --git a/core/package-lock.json b/core/package-lock.json index fac0a25cddd..bbc1c89a111 100644 --- a/core/package-lock.json +++ b/core/package-lock.json @@ -1,24 +1,24 @@ { "name": "@ionic/core", - "version": "7.6.6", + "version": "7.6.7", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/core", - "version": "7.6.6", + "version": "7.6.7", "license": "MIT", "dependencies": { - "@stencil/core": "^4.10.0", + "@stencil/core": "^4.12.0", "ionicons": "^7.2.2", "tslib": "^2.1.0" }, "devDependencies": { - "@axe-core/playwright": "^4.8.3", + "@axe-core/playwright": "^4.8.4", "@capacitor/core": "^5.6.0", "@capacitor/haptics": "^5.0.6", - "@capacitor/keyboard": "^5.0.7", - "@capacitor/status-bar": "^5.0.6", + "@capacitor/keyboard": "^5.0.8", + "@capacitor/status-bar": "^5.0.7", "@ionic/eslint-config": "^0.3.0", "@ionic/prettier-config": "^2.0.0", "@playwright/test": "^1.39.0", @@ -26,7 +26,7 @@ "@rollup/plugin-virtual": "^2.0.3", "@stencil/angular-output-target": "^0.8.3", "@stencil/react-output-target": "^0.5.3", - "@stencil/sass": "^3.0.8", + "@stencil/sass": "^3.0.9", "@stencil/vue-output-target": "^0.8.7", "@types/jest": "^29.5.6", "@types/node": "^14.6.0", @@ -56,9 +56,9 @@ "dev": true }, "node_modules/@axe-core/playwright": { - "version": "4.8.3", - "resolved": "https://registry.npmjs.org/@axe-core/playwright/-/playwright-4.8.3.tgz", - "integrity": "sha512-YtbkAWeOp5oQeI8vS6KYqJDa5yTl5O1wJP8KOZAAVjhxeiK/Y1ssxnZuGRobARyVh3eS6O3jdxTv/iCK1RfgaA==", + "version": "4.8.4", + "resolved": "https://registry.npmjs.org/@axe-core/playwright/-/playwright-4.8.4.tgz", + "integrity": "sha512-xpwd+T0BODt19hnXW0eX9xf+H/Ns1rdWwZNmuCV9UoTqjZ9mGm1F80pvh/A1r317ooltq8nwqcoVO9jbHWKSdA==", "dev": true, "dependencies": { "axe-core": "~4.8.3" @@ -652,18 +652,18 @@ } }, "node_modules/@capacitor/keyboard": { - "version": "5.0.7", - "resolved": "https://registry.npmjs.org/@capacitor/keyboard/-/keyboard-5.0.7.tgz", - "integrity": "sha512-+6lW8z2nXTM2NOG7D7pOasCfIGicz26+EeDRXIj5AtJibbjwtE1Q5GIY+qGHgzpmwOF0qmcrGJBz4zagDwUapg==", + "version": "5.0.8", + "resolved": "https://registry.npmjs.org/@capacitor/keyboard/-/keyboard-5.0.8.tgz", + "integrity": "sha512-XYyBzGlzjgLPqyPVdu5McGLYV6+G2efVR4I3l5cF1B27M6U/oFqv9CQU74WNG08nee28bfccboNpv6eWCLYn1A==", "dev": true, "peerDependencies": { "@capacitor/core": "^5.0.0" } }, "node_modules/@capacitor/status-bar": { - "version": "5.0.6", - "resolved": "https://registry.npmjs.org/@capacitor/status-bar/-/status-bar-5.0.6.tgz", - "integrity": "sha512-7od8CxsBnot1XMK3IeOkproFL4hgoKoWAc3pwUvmDOkQsXoxwQm4SR9mLwQavv1XfxtHbFV9Ukd7FwMxOPSViw==", + "version": "5.0.7", + "resolved": "https://registry.npmjs.org/@capacitor/status-bar/-/status-bar-5.0.7.tgz", + "integrity": "sha512-KblB3gV2LDMEjx3fQoNBAzxb+Tr+2mv68SfFLLDCMiMUD3Eile2TAWRWd1yxy496pDFTOs2BJtup8++iuuuJ/w==", "dev": true, "peerDependencies": { "@capacitor/core": "^5.0.0" @@ -1825,9 +1825,9 @@ } }, "node_modules/@stencil/core": { - "version": "4.10.0", - "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.10.0.tgz", - "integrity": "sha512-7lDTPY1IxXN2/C+wQPHt3e/dYgY4YgelA8MxOsU3ZftXtpzWad/QNWhSAtKisJMrSjQh41jMDOgD0yLBwV6E7w==", + "version": "4.12.0", + "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.12.0.tgz", + "integrity": "sha512-qAQcfNmp2sdxAh1DlyUhHfDmIUS7mhI+5LAhPphg74zK9sKgFL5vpLzgjs0wohpjlmI4msgJFYiRB8lxVPqjPg==", "bin": { "stencil": "bin/stencil" }, @@ -1846,9 +1846,9 @@ } }, "node_modules/@stencil/sass": { - "version": "3.0.8", - "resolved": "https://registry.npmjs.org/@stencil/sass/-/sass-3.0.8.tgz", - "integrity": "sha512-QJUG4Dr/b3wSizViwQXorrk1PJzxOsKkq5hSqtUHc3NNG3iomC4DQFYGeu15yNfoCDBtt4qkyHSCynsekQ8F6A==", + "version": "3.0.9", + "resolved": "https://registry.npmjs.org/@stencil/sass/-/sass-3.0.9.tgz", + "integrity": "sha512-GtPMjf5r4/BVBCO3LvcoMSIfOa6T+0wq+SrTGEilC4NCZpuZdAlZffWxXi80caZ1jDclwdzJ2qGwEgCAfvGoNA==", "dev": true, "engines": { "node": ">=12.0.0", @@ -10899,9 +10899,9 @@ }, "dependencies": { "@axe-core/playwright": { - "version": "4.8.3", - "resolved": "https://registry.npmjs.org/@axe-core/playwright/-/playwright-4.8.3.tgz", - "integrity": "sha512-YtbkAWeOp5oQeI8vS6KYqJDa5yTl5O1wJP8KOZAAVjhxeiK/Y1ssxnZuGRobARyVh3eS6O3jdxTv/iCK1RfgaA==", + "version": "4.8.4", + "resolved": "https://registry.npmjs.org/@axe-core/playwright/-/playwright-4.8.4.tgz", + "integrity": "sha512-xpwd+T0BODt19hnXW0eX9xf+H/Ns1rdWwZNmuCV9UoTqjZ9mGm1F80pvh/A1r317ooltq8nwqcoVO9jbHWKSdA==", "dev": true, "requires": { "axe-core": "~4.8.3" @@ -11340,16 +11340,16 @@ "requires": {} }, "@capacitor/keyboard": { - "version": "5.0.7", - "resolved": "https://registry.npmjs.org/@capacitor/keyboard/-/keyboard-5.0.7.tgz", - "integrity": "sha512-+6lW8z2nXTM2NOG7D7pOasCfIGicz26+EeDRXIj5AtJibbjwtE1Q5GIY+qGHgzpmwOF0qmcrGJBz4zagDwUapg==", + "version": "5.0.8", + "resolved": "https://registry.npmjs.org/@capacitor/keyboard/-/keyboard-5.0.8.tgz", + "integrity": "sha512-XYyBzGlzjgLPqyPVdu5McGLYV6+G2efVR4I3l5cF1B27M6U/oFqv9CQU74WNG08nee28bfccboNpv6eWCLYn1A==", "dev": true, "requires": {} }, "@capacitor/status-bar": { - "version": "5.0.6", - "resolved": "https://registry.npmjs.org/@capacitor/status-bar/-/status-bar-5.0.6.tgz", - "integrity": "sha512-7od8CxsBnot1XMK3IeOkproFL4hgoKoWAc3pwUvmDOkQsXoxwQm4SR9mLwQavv1XfxtHbFV9Ukd7FwMxOPSViw==", + "version": "5.0.7", + "resolved": "https://registry.npmjs.org/@capacitor/status-bar/-/status-bar-5.0.7.tgz", + "integrity": "sha512-KblB3gV2LDMEjx3fQoNBAzxb+Tr+2mv68SfFLLDCMiMUD3Eile2TAWRWd1yxy496pDFTOs2BJtup8++iuuuJ/w==", "dev": true, "requires": {} }, @@ -12184,9 +12184,9 @@ "requires": {} }, "@stencil/core": { - "version": "4.10.0", - "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.10.0.tgz", - "integrity": "sha512-7lDTPY1IxXN2/C+wQPHt3e/dYgY4YgelA8MxOsU3ZftXtpzWad/QNWhSAtKisJMrSjQh41jMDOgD0yLBwV6E7w==" + "version": "4.12.0", + "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.12.0.tgz", + "integrity": "sha512-qAQcfNmp2sdxAh1DlyUhHfDmIUS7mhI+5LAhPphg74zK9sKgFL5vpLzgjs0wohpjlmI4msgJFYiRB8lxVPqjPg==" }, "@stencil/react-output-target": { "version": "0.5.3", @@ -12196,9 +12196,9 @@ "requires": {} }, "@stencil/sass": { - "version": "3.0.8", - "resolved": "https://registry.npmjs.org/@stencil/sass/-/sass-3.0.8.tgz", - "integrity": "sha512-QJUG4Dr/b3wSizViwQXorrk1PJzxOsKkq5hSqtUHc3NNG3iomC4DQFYGeu15yNfoCDBtt4qkyHSCynsekQ8F6A==", + "version": "3.0.9", + "resolved": "https://registry.npmjs.org/@stencil/sass/-/sass-3.0.9.tgz", + "integrity": "sha512-GtPMjf5r4/BVBCO3LvcoMSIfOa6T+0wq+SrTGEilC4NCZpuZdAlZffWxXi80caZ1jDclwdzJ2qGwEgCAfvGoNA==", "dev": true, "requires": {} }, diff --git a/core/package.json b/core/package.json index 3a4680c85cd..eb3d5d4aa45 100644 --- a/core/package.json +++ b/core/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/core", - "version": "7.6.6", + "version": "7.6.7", "description": "Base components for Ionic", "keywords": [ "ionic", @@ -31,16 +31,16 @@ "loader/" ], "dependencies": { - "@stencil/core": "^4.10.0", + "@stencil/core": "^4.12.0", "ionicons": "^7.2.2", "tslib": "^2.1.0" }, "devDependencies": { - "@axe-core/playwright": "^4.8.3", + "@axe-core/playwright": "^4.8.4", "@capacitor/core": "^5.6.0", "@capacitor/haptics": "^5.0.6", - "@capacitor/keyboard": "^5.0.7", - "@capacitor/status-bar": "^5.0.6", + "@capacitor/keyboard": "^5.0.8", + "@capacitor/status-bar": "^5.0.7", "@ionic/eslint-config": "^0.3.0", "@ionic/prettier-config": "^2.0.0", "@playwright/test": "^1.39.0", @@ -48,7 +48,7 @@ "@rollup/plugin-virtual": "^2.0.3", "@stencil/angular-output-target": "^0.8.3", "@stencil/react-output-target": "^0.5.3", - "@stencil/sass": "^3.0.8", + "@stencil/sass": "^3.0.9", "@stencil/vue-output-target": "^0.8.7", "@types/jest": "^29.5.6", "@types/node": "^14.6.0", diff --git a/core/src/components/accordion/accordion.tsx b/core/src/components/accordion/accordion.tsx index eab83209cd5..92d28848d20 100644 --- a/core/src/components/accordion/accordion.tsx +++ b/core/src/components/accordion/accordion.tsx @@ -382,7 +382,10 @@ export class Accordion implements ComponentInterface { }; private toggleExpanded() { - const { accordionGroupEl, value, state } = this; + const { accordionGroupEl, disabled, readonly, value, state } = this; + + if (disabled || readonly) return; + if (accordionGroupEl) { /** * Because the accordion group may or may diff --git a/core/src/components/accordion/test/a11y/index.html b/core/src/components/accordion/test/a11y/index.html index 0c660ef8ddd..e8bd7a67e01 100644 --- a/core/src/components/accordion/test/a11y/index.html +++ b/core/src/components/accordion/test/a11y/index.html @@ -23,28 +23,22 @@

Accordion Group - a11y

- Name - + - Email - + - Phone - + - Extension - + - Country - + - City/Province - + @@ -56,24 +50,19 @@

Accordion Group - a11y

- Address 1 - + - Address 2 - + - City - + - State - + - Zip Code - + @@ -85,24 +74,19 @@

Accordion Group - a11y

- Address 1 - + - Address 2 - + - City - + - State - + - Zip Code - + diff --git a/core/src/components/accordion/test/accordion.e2e.ts b/core/src/components/accordion/test/accordion.e2e.ts deleted file mode 100644 index f09aa4b1a2f..00000000000 --- a/core/src/components/accordion/test/accordion.e2e.ts +++ /dev/null @@ -1,49 +0,0 @@ -import { expect } from '@playwright/test'; -import { configs, test } from '@utils/test/playwright'; - -configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ config, title }) => { - test.describe(title('accordion: states'), () => { - test.beforeEach(async ({ page }) => { - await page.setContent( - ` - - - Label -
Content
- - - `, - config - ); - }); - test('should properly set readonly on child accordions', async ({ page }) => { - const accordionGroup = page.locator('ion-accordion-group'); - const accordion = page.locator('ion-accordion'); - - await expect(accordion).toHaveJSProperty('readonly', false); - - await accordionGroup.evaluate((el: HTMLIonAccordionGroupElement) => { - el.readonly = true; - }); - - await page.waitForChanges(); - - await expect(accordion).toHaveJSProperty('readonly', true); - }); - - test('should properly set disabled on child accordions', async ({ page }) => { - const accordionGroup = page.locator('ion-accordion-group'); - const accordion = page.locator('ion-accordion'); - - await expect(accordion).toHaveJSProperty('disabled', false); - - await accordionGroup.evaluate((el: HTMLIonAccordionGroupElement) => { - el.disabled = true; - }); - - await page.waitForChanges(); - - await expect(accordion).toHaveJSProperty('disabled', true); - }); - }); -}); diff --git a/core/src/components/accordion/test/disabled/accordion.e2e.ts b/core/src/components/accordion/test/disabled/accordion.e2e.ts new file mode 100644 index 00000000000..3857a1d7b26 --- /dev/null +++ b/core/src/components/accordion/test/disabled/accordion.e2e.ts @@ -0,0 +1,137 @@ +import { expect } from '@playwright/test'; +import { configs, test } from '@utils/test/playwright'; + +// NOTE: these tests cannot be re-written as spec tests because the `getAccordions` method in accordion-group.tsx uses a `:scope` selector +configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ config, title }) => { + test.describe(title('accordion: disabled'), () => { + test('should properly set disabled on child accordions', async ({ page }) => { + await page.setContent( + ` + + + Label +
Content
+ + + `, + config + ); + + const accordionGroup = page.locator('ion-accordion-group'); + const accordion = page.locator('ion-accordion'); + + await expect(accordion).toHaveJSProperty('disabled', false); + + await accordionGroup.evaluate((el: HTMLIonAccordionGroupElement) => { + el.disabled = true; + }); + + await page.waitForChanges(); + + await expect(accordion).toHaveJSProperty('disabled', true); + }); + + test('should not open accordion on click when group is disabled', async ({ page }) => { + await page.setContent( + ` + + + Label +
Content
+ + + `, + config + ); + + const accordion = page.locator('ion-accordion'); + + await expect(accordion).toHaveClass(/accordion-collapsed/); + + accordion.click(); + await page.waitForChanges(); + + await expect(accordion).toHaveClass(/accordion-collapsed/); + }); + + test('should not open accordion on click when accordion is disabled', async ({ page }) => { + await page.setContent( + ` + + + Label +
Content
+ + + `, + config + ); + + const accordion = page.locator('ion-accordion'); + + await expect(accordion).toHaveClass(/accordion-collapsed/); + + accordion.click(); + await page.waitForChanges(); + + await expect(accordion).toHaveClass(/accordion-collapsed/); + }); + + test('should not open accordion via keyboard navigation when group is disabled', async ({ page, browserName }) => { + await page.setContent( + ` + + + Label +
Content
+ + + `, + config + ); + + const accordion = page.locator('ion-accordion'); + const tabKey = browserName === 'webkit' ? 'Alt+Tab' : 'Tab'; + + await expect(accordion).toHaveClass(/accordion-collapsed/); + + await page.keyboard.press(tabKey); + await page.waitForChanges(); + + await page.keyboard.press('Enter'); + await page.waitForChanges(); + + await expect(accordion).toHaveClass(/accordion-collapsed/); + }); + + test('should not open accordion via keyboard navigation when accordion is disabled', async ({ + page, + browserName, + }) => { + await page.setContent( + ` + + + Label +
Content
+ + + `, + config + ); + + const accordion = page.locator('ion-accordion'); + const tabKey = browserName === 'webkit' ? 'Alt+Tab' : 'Tab'; + + await expect(accordion).toHaveClass(/accordion-collapsed/); + + await page.keyboard.press(tabKey); + await page.waitForChanges(); + + await page.keyboard.press('Enter'); + await page.waitForChanges(); + + await expect(accordion).toHaveClass(/accordion-collapsed/); + }); + }); +}); diff --git a/core/src/components/accordion/test/disabled/index.html b/core/src/components/accordion/test/disabled/index.html new file mode 100644 index 00000000000..38452b7adec --- /dev/null +++ b/core/src/components/accordion/test/disabled/index.html @@ -0,0 +1,91 @@ + + + + + Accordion - Disabled + + + + + + + + + + + + Accordion - Disabled + + + + + + Accordion - Disabled + + + +
+
+ + + + First Accordion + +
First Content
+ + + + Second Accordion (Disabled) + +
Second Content
+ + + + Third Accordion + +
Third Content
+ + +
+
+ + + + First Accordion in Disabled Group + +
First Content
+ + + + Second Accordion in Disabled Group + +
Second Content
+ + + + Third Accordion in Disabled Group + +
Third Content
+ + +
+
+ + + Accordion Without Group (Disabled) + +
Second Content
+ +
+
+ + + + diff --git a/core/src/components/accordion/test/readonly/accordion.e2e.ts b/core/src/components/accordion/test/readonly/accordion.e2e.ts new file mode 100644 index 00000000000..00795030468 --- /dev/null +++ b/core/src/components/accordion/test/readonly/accordion.e2e.ts @@ -0,0 +1,137 @@ +import { expect } from '@playwright/test'; +import { configs, test } from '@utils/test/playwright'; + +// NOTE: these tests cannot be re-written as spec tests because the `getAccordions` method in accordion-group.tsx uses a `:scope` selector +configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ config, title }) => { + test.describe(title('accordion: readonly'), () => { + test('should properly set readonly on child accordions', async ({ page }) => { + await page.setContent( + ` + + + Label +
Content
+ + + `, + config + ); + + const accordionGroup = page.locator('ion-accordion-group'); + const accordion = page.locator('ion-accordion'); + + await expect(accordion).toHaveJSProperty('readonly', false); + + await accordionGroup.evaluate((el: HTMLIonAccordionGroupElement) => { + el.readonly = true; + }); + + await page.waitForChanges(); + + await expect(accordion).toHaveJSProperty('readonly', true); + }); + + test('should not open accordion on click when group is readonly', async ({ page }) => { + await page.setContent( + ` + + + Label +
Content
+ + + `, + config + ); + + const accordion = page.locator('ion-accordion'); + + await expect(accordion).toHaveClass(/accordion-collapsed/); + + accordion.click(); + await page.waitForChanges(); + + await expect(accordion).toHaveClass(/accordion-collapsed/); + }); + + test('should not open accordion on click when accordion is readonly', async ({ page }) => { + await page.setContent( + ` + + + Label +
Content
+ + + `, + config + ); + + const accordion = page.locator('ion-accordion'); + + await expect(accordion).toHaveClass(/accordion-collapsed/); + + accordion.click(); + await page.waitForChanges(); + + await expect(accordion).toHaveClass(/accordion-collapsed/); + }); + + test('should not open accordion via keyboard navigation when group is readonly', async ({ page, browserName }) => { + await page.setContent( + ` + + + Label +
Content
+ + + `, + config + ); + + const accordion = page.locator('ion-accordion'); + const tabKey = browserName === 'webkit' ? 'Alt+Tab' : 'Tab'; + + await expect(accordion).toHaveClass(/accordion-collapsed/); + + await page.keyboard.press(tabKey); + await page.waitForChanges(); + + await page.keyboard.press('Enter'); + await page.waitForChanges(); + + await expect(accordion).toHaveClass(/accordion-collapsed/); + }); + + test('should not open accordion via keyboard navigation when accordion is readonly', async ({ + page, + browserName, + }) => { + await page.setContent( + ` + + + Label +
Content
+ + + `, + config + ); + + const accordion = page.locator('ion-accordion'); + const tabKey = browserName === 'webkit' ? 'Alt+Tab' : 'Tab'; + + await expect(accordion).toHaveClass(/accordion-collapsed/); + + await page.keyboard.press(tabKey); + await page.waitForChanges(); + + await page.keyboard.press('Enter'); + await page.waitForChanges(); + + await expect(accordion).toHaveClass(/accordion-collapsed/); + }); + }); +}); diff --git a/core/src/components/accordion/test/readonly/index.html b/core/src/components/accordion/test/readonly/index.html new file mode 100644 index 00000000000..7b1a9ac84c6 --- /dev/null +++ b/core/src/components/accordion/test/readonly/index.html @@ -0,0 +1,91 @@ + + + + + Accordion - Readonly + + + + + + + + + + + + Accordion - Readonly + + + + + + Accordion - Readonly + + + +
+
+ + + + First Accordion + +
First Content
+ + + + Second Accordion (Readonly) + +
Second Content
+ + + + Third Accordion + +
Third Content
+ + +
+
+ + + + First Accordion in Readonly Group + +
First Content
+ + + + Second Accordion in Readonly Group + +
Second Content
+ + + + Third Accordion in Readonly Group + +
Third Content
+ + +
+
+ + + Accordion Without Group (Readonly) + +
Second Content
+ +
+
+ + + + diff --git a/core/src/components/action-sheet/action-sheet-interface.ts b/core/src/components/action-sheet/action-sheet-interface.ts index 465c50e050e..1021895d0e4 100644 --- a/core/src/components/action-sheet/action-sheet-interface.ts +++ b/core/src/components/action-sheet/action-sheet-interface.ts @@ -1,4 +1,4 @@ -import type { AnimationBuilder, Mode } from '../../interface'; +import type { AnimationBuilder, LiteralUnion, Mode } from '../../interface'; export interface ActionSheetOptions { header?: string; @@ -19,7 +19,7 @@ export interface ActionSheetOptions { export interface ActionSheetButton { text?: string; - role?: 'cancel' | 'destructive' | 'selected' | string; + role?: LiteralUnion<'cancel' | 'destructive' | 'selected', string>; icon?: string; cssClass?: string | string[]; id?: string; diff --git a/core/src/components/alert/alert-interface.ts b/core/src/components/alert/alert-interface.ts index 3f9d6cda8d4..326d74484d6 100644 --- a/core/src/components/alert/alert-interface.ts +++ b/core/src/components/alert/alert-interface.ts @@ -1,4 +1,4 @@ -import type { AnimationBuilder, Mode, TextFieldTypes } from '../../interface'; +import type { AnimationBuilder, LiteralUnion, Mode, TextFieldTypes } from '../../interface'; import type { IonicSafeString } from '../../utils/sanitization'; export interface AlertOptions { @@ -45,7 +45,7 @@ type AlertButtonOverlayHandler = boolean | void | { [key: string]: any }; export interface AlertButton { text: string; - role?: 'cancel' | 'destructive' | string; + role?: LiteralUnion<'cancel' | 'destructive', string>; cssClass?: string | string[]; id?: string; htmlAttributes?: { [key: string]: any }; diff --git a/core/src/components/button/test/basic/button.e2e.ts b/core/src/components/button/test/basic/button.e2e.ts index 2480c2fb2f0..51635161b09 100644 --- a/core/src/components/button/test/basic/button.e2e.ts +++ b/core/src/components/button/test/basic/button.e2e.ts @@ -57,7 +57,7 @@ configs({ modes: ['md'] }).forEach(({ config, screenshot, title }) => { await page.mouse.down(); } - await page.waitForSelector('#default.ion-activated'); + await page.locator('#default.ion-activated').waitFor(); await expect(button).toHaveScreenshot(screenshot(`button-ripple-effect`)); }); diff --git a/core/src/components/button/test/wrap/button.e2e.ts-snapshots/button-wrap-item-button-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/button/test/wrap/button.e2e.ts-snapshots/button-wrap-item-button-ios-ltr-Mobile-Firefox-linux.png index d374cb54e10..4df0af8873d 100644 Binary files a/core/src/components/button/test/wrap/button.e2e.ts-snapshots/button-wrap-item-button-ios-ltr-Mobile-Firefox-linux.png and b/core/src/components/button/test/wrap/button.e2e.ts-snapshots/button-wrap-item-button-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/datetime-button/test/basic/datetime-button.e2e.ts b/core/src/components/datetime-button/test/basic/datetime-button.e2e.ts index b52ff42462c..938ce976e54 100644 --- a/core/src/components/datetime-button/test/basic/datetime-button.e2e.ts +++ b/core/src/components/datetime-button/test/basic/datetime-button.e2e.ts @@ -15,7 +15,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); }); test('should switch to a date-only view when the date button is clicked', async ({ page }) => { const datetime = page.locator('ion-datetime'); @@ -45,7 +45,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); await expect(page.locator('#date-button')).toContainText('Jan 1, 2022'); await expect(page.locator('#time-button')).toContainText('6:30 AM'); @@ -58,7 +58,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); await expect(page.locator('#date-button')).toContainText('January 2022'); await expect(page.locator('#time-button')).toBeHidden(); @@ -71,7 +71,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); await expect(page.locator('#date-button')).toContainText('2022'); await expect(page.locator('#time-button')).toBeHidden(); @@ -84,7 +84,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); await expect(page.locator('#date-button')).toContainText('January'); await expect(page.locator('#time-button')).toBeHidden(); @@ -97,7 +97,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); await expect(page.locator('#time-button')).toContainText('6:30 AM'); await expect(page.locator('#date-button')).toBeHidden(); @@ -110,7 +110,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const datetime = page.locator('ion-datetime'); const dateTarget = page.locator('#date-button'); @@ -135,7 +135,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); await expect(page.locator('#date-button')).toContainText('January 2022'); await expect(page.locator('#time-button')).toBeHidden(); @@ -153,7 +153,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); await expect(page.locator('#date-button')).toContainText('2022'); await expect(page.locator('#time-button')).toBeHidden(); @@ -169,7 +169,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); /** * The entire text reads 1 ene 2022, but some browsers will add @@ -187,7 +187,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); await expect(page.locator('#time-button')).toContainText('16:30'); }); @@ -199,7 +199,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const timeTarget = page.locator('#time-button'); await expect(timeTarget).toContainText('6:30'); @@ -223,7 +223,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); await expect(page.locator('#date-button')).toContainText('Jan 1, 2022 6:30 AM'); await expect(page.locator('#time-button')).not.toBeVisible(); @@ -238,7 +238,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); await expect(page.locator('#date-button')).toContainText('Jan 1, 2022 6:30 AM'); await expect(page.locator('#time-button')).not.toBeVisible(); diff --git a/core/src/components/datetime-button/test/buttons/index.html b/core/src/components/datetime-button/test/buttons/index.html index 2b6f1f7bcc3..ca484632b95 100644 --- a/core/src/components/datetime-button/test/buttons/index.html +++ b/core/src/components/datetime-button/test/buttons/index.html @@ -18,7 +18,7 @@ - + diff --git a/core/src/components/datetime-button/test/disabled/datetime-button.e2e.ts b/core/src/components/datetime-button/test/disabled/datetime-button.e2e.ts index 23ef52821f2..f8f45fd49c4 100644 --- a/core/src/components/datetime-button/test/disabled/datetime-button.e2e.ts +++ b/core/src/components/datetime-button/test/disabled/datetime-button.e2e.ts @@ -11,7 +11,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, screenshot, co `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); await expect(page.locator('#date-button')).toBeDisabled(); await expect(page.locator('#time-button')).toBeDisabled(); @@ -24,7 +24,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, screenshot, co `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const datetimeButton = page.locator('ion-datetime-button'); await expect(datetimeButton).toHaveScreenshot(screenshot(`datetime-button-disabled`)); diff --git a/core/src/components/datetime-button/test/multiple/datetime-button.e2e.ts b/core/src/components/datetime-button/test/multiple/datetime-button.e2e.ts index 901ddc74be3..598124b1b00 100644 --- a/core/src/components/datetime-button/test/multiple/datetime-button.e2e.ts +++ b/core/src/components/datetime-button/test/multiple/datetime-button.e2e.ts @@ -20,7 +20,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); await expect(page.locator('#date-button')).toContainText('3 days'); }); @@ -32,7 +32,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); await expect(page.locator('#date-button')).toHaveText('0 days'); }); @@ -49,7 +49,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); await expect(page.locator('#date-button')).toHaveText('Jun 1, 2022'); }); @@ -69,7 +69,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); await expect(page.locator('#date-button')).toHaveText('Selected: 3'); }); @@ -86,7 +86,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const datetime = page.locator('ion-datetime'); const ionValueChange = await page.spyOnEvent('ionValueChange'); @@ -111,7 +111,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); await expect(page.locator('#date-button')).toHaveText('Jun 1, 2022'); await expect(page.locator('#time-button')).toHaveText('4:30 PM'); diff --git a/core/src/components/datetime/test/a11y/datetime.e2e.ts b/core/src/components/datetime/test/a11y/datetime.e2e.ts index 5f4e5ff9e3f..05b10b5e8a3 100644 --- a/core/src/components/datetime/test/a11y/datetime.e2e.ts +++ b/core/src/components/datetime/test/a11y/datetime.e2e.ts @@ -24,7 +24,7 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { const container = page.locator('#container'); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); await expect(container).toHaveScreenshot(screenshot(`datetime-scale`)); }); @@ -87,7 +87,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const clearButton = page.locator('#clear-button button'); const selectedDay = page.locator('.calendar-day-active'); @@ -114,7 +114,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const calendarMonthYear = page.locator('ion-datetime .calendar-month-year'); const calendarBody = page.locator('.calendar-body'); await expect(calendarMonthYear).toHaveText('February 2022'); diff --git a/core/src/components/datetime/test/basic/datetime.e2e.ts b/core/src/components/datetime/test/basic/datetime.e2e.ts index b72a7f2c3a6..48b0b0ceec0 100644 --- a/core/src/components/datetime/test/basic/datetime.e2e.ts +++ b/core/src/components/datetime/test/basic/datetime.e2e.ts @@ -110,7 +110,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const datetime = page.locator('ion-datetime'); const ionChange = await page.spyOnEvent('ionChange'); @@ -255,7 +255,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const calendarBody = page.locator('ion-datetime .calendar-body'); const calendarHeader = page.locator('ion-datetime .calendar-month-year'); @@ -275,7 +275,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const calendarBody = page.locator('ion-datetime .calendar-body'); const calendarHeader = page.locator('ion-datetime .calendar-month-year'); @@ -297,7 +297,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const calendarBody = page.locator('ion-datetime .calendar-body'); const calendarHeader = page.locator('ion-datetime .calendar-month-year'); @@ -331,7 +331,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const monthYearButton = page.locator('ion-datetime .calendar-month-year'); const monthYearInterface = page.locator('ion-datetime .datetime-year'); @@ -349,7 +349,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => await datetime.evaluate((el: HTMLIonDatetimeElement) => el.style.removeProperty('display')); await expect(datetime).toBeVisible(); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); // month/year interface should be reset await expect(monthYearInterface).toBeHidden(); @@ -399,7 +399,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const selectedDay = page.locator('ion-datetime .calendar-day-active'); @@ -428,7 +428,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const ionChange = await page.spyOnEvent('ionChange'); const calendarButtons = page.locator('.calendar-day:not([disabled])'); @@ -447,7 +447,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const ionChange = await page.spyOnEvent('ionChange'); const datetime = page.locator('ion-datetime'); @@ -487,7 +487,7 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { const datetime = page.locator('ion-datetime'); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); await expect(datetime.locator('.calendar-day-today')).toHaveScreenshot( screenshot(`datetime-today-calendar-button`) @@ -517,7 +517,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, screenshot, co const datetime = page.locator('ion-datetime'); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); await expect(datetime).toHaveScreenshot(screenshot(`date-highlight-start-of-month`)); @@ -543,7 +543,7 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const datetime = page.locator('ion-datetime'); diff --git a/core/src/components/datetime/test/basic/index.html b/core/src/components/datetime/test/basic/index.html index 153c85688a7..2023b4a1190 100644 --- a/core/src/components/datetime/test/basic/index.html +++ b/core/src/components/datetime/test/basic/index.html @@ -214,8 +214,7 @@ - Dark Mode - + Dark Mode iOS Mode @@ -225,23 +224,19 @@ - Show Default Title - + Show Default Title - Show Default Buttons - + Show Default Buttons - Locale - + - Color - + Primary Secondary Tertiary diff --git a/core/src/components/datetime/test/datetime.e2e.ts b/core/src/components/datetime/test/datetime.e2e.ts index f6ac137d710..a7653597b19 100644 --- a/core/src/components/datetime/test/datetime.e2e.ts +++ b/core/src/components/datetime/test/datetime.e2e.ts @@ -11,7 +11,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); }); test('should switch the calendar header when moving to a month with a different number of days', async ({ diff --git a/core/src/components/datetime/test/disable-dates/datetime.e2e.ts b/core/src/components/datetime/test/disable-dates/datetime.e2e.ts index 6ae7c54ea9a..3fc4b882186 100644 --- a/core/src/components/datetime/test/disable-dates/datetime.e2e.ts +++ b/core/src/components/datetime/test/disable-dates/datetime.e2e.ts @@ -113,7 +113,7 @@ configs({ directions: ['ltr'], modes: ['ios'] }).forEach(({ title, config }) => test.describe('check example usages', () => { test.beforeEach(async ({ page }) => { await page.goto('/src/components/datetime/test/disable-dates', config); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').first().waitFor(); }); test('should disable a specific date', async ({ page }) => { diff --git a/core/src/components/datetime/test/disabled/datetime.e2e.ts b/core/src/components/datetime/test/disabled/datetime.e2e.ts index d794a2d2ef6..91b48b736cf 100644 --- a/core/src/components/datetime/test/disabled/datetime.e2e.ts +++ b/core/src/components/datetime/test/disabled/datetime.e2e.ts @@ -27,7 +27,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config, scree config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const febFirstButton = page.locator(`.calendar-day[data-day='1'][data-month='2']`); @@ -42,7 +42,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config, scree config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const calendarMonthYear = page.locator('ion-datetime .calendar-month-year'); await expect(calendarMonthYear.locator('button')).toBeDisabled(); }); @@ -71,7 +71,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config, scree config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const clearButton = page.locator('#clear-button button'); @@ -86,7 +86,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config, scree config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const calendarMonthYear = page.locator('ion-datetime .calendar-month-year'); const calendarBody = page.locator('.calendar-body'); await expect(calendarMonthYear).toHaveText('February 2022'); diff --git a/core/src/components/datetime/test/display/datetime.e2e.ts b/core/src/components/datetime/test/display/datetime.e2e.ts index 0fcb9db898f..501bdfeeab0 100644 --- a/core/src/components/datetime/test/display/datetime.e2e.ts +++ b/core/src/components/datetime/test/display/datetime.e2e.ts @@ -15,7 +15,7 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const datetime = page.locator('ion-datetime'); await expect(datetime).toHaveScreenshot(screenshot(`datetime-display-date-time`)); }); @@ -26,7 +26,7 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const datetime = page.locator('ion-datetime'); await expect(datetime).toHaveScreenshot(screenshot(`datetime-display-time-date`)); }); @@ -37,7 +37,7 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const datetime = page.locator('ion-datetime'); await expect(datetime).toHaveScreenshot(screenshot(`datetime-display-time`)); }); @@ -48,7 +48,7 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const datetime = page.locator('ion-datetime'); await expect(datetime).toHaveScreenshot(screenshot(`datetime-display-date`)); }); @@ -69,7 +69,7 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const datetime = page.locator('ion-datetime'); await expect(datetime).toHaveScreenshot(screenshot(`datetime-display-cover-date-time`)); }); @@ -80,7 +80,7 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const datetime = page.locator('ion-datetime'); await expect(datetime).toHaveScreenshot(screenshot(`datetime-display-cover-time-date`)); }); @@ -91,7 +91,7 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const datetime = page.locator('ion-datetime'); await expect(datetime).toHaveScreenshot(screenshot(`datetime-display-cover-time`)); }); @@ -102,7 +102,7 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const datetime = page.locator('ion-datetime'); await expect(datetime).toHaveScreenshot(screenshot(`datetime-display-cover-date`)); }); @@ -119,7 +119,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => test('month selection should work after changing presentation', async ({ page }) => { await page.goto('/src/components/datetime/test/display', config); const ionWorkingPartsDidChange = await page.spyOnEvent('ionWorkingPartsDidChange'); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const select = page.locator('select#presentation'); diff --git a/core/src/components/datetime/test/locale/datetime.e2e.ts b/core/src/components/datetime/test/locale/datetime.e2e.ts index fba13a4137c..37d992d730b 100644 --- a/core/src/components/datetime/test/locale/datetime.e2e.ts +++ b/core/src/components/datetime/test/locale/datetime.e2e.ts @@ -95,7 +95,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const datetimeButtons = page.locator('ion-datetime .calendar-day:not([disabled])'); @@ -111,7 +111,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const datetimeYear = page.locator('ion-datetime .year-column .picker-item[data-value="2022"]'); @@ -147,7 +147,7 @@ class DatetimeLocaleFixture { this.datetime = this.page.locator('ion-datetime'); - await this.page.waitForSelector('.datetime-ready'); + await this.page.locator('.datetime-ready').waitFor(); } async expectLocalizedDatePicker(screenshot: ScreenshotFn) { diff --git a/core/src/components/datetime/test/minmax/datetime.e2e.ts b/core/src/components/datetime/test/minmax/datetime.e2e.ts index ae25f71f492..4f6aa033a5b 100644 --- a/core/src/components/datetime/test/minmax/datetime.e2e.ts +++ b/core/src/components/datetime/test/minmax/datetime.e2e.ts @@ -36,7 +36,7 @@ configs({ directions: ['ltr'], modes: ['ios'] }).forEach(({ title, config }) => config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const prevButton = page.locator('ion-datetime .calendar-next-prev ion-button:nth-child(1)'); const nextButton = page.locator('ion-datetime .calendar-next-prev ion-button:nth-child(2)'); @@ -61,7 +61,7 @@ configs({ directions: ['ltr'], modes: ['ios'] }).forEach(({ title, config }) => await page.goto('/src/components/datetime/test/minmax', config); const calendarMonths = page.locator('ion-datetime#inside .calendar-month'); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').first().waitFor(); await expect(calendarMonths.nth(0)).not.toHaveClass(/calendar-month-disabled/); await expect(calendarMonths.nth(1)).not.toHaveClass(/calendar-month-disabled/); @@ -70,7 +70,7 @@ configs({ directions: ['ltr'], modes: ['ios'] }).forEach(({ title, config }) => test('datetime: minmax navigation disabled', async ({ page }) => { await page.goto('/src/components/datetime/test/minmax', config); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').first().waitFor(); const navButtons = page.locator('ion-datetime#outside .calendar-next-prev ion-button'); @@ -80,7 +80,7 @@ configs({ directions: ['ltr'], modes: ['ios'] }).forEach(({ title, config }) => test('datetime: min including day should not disable month', async ({ page }) => { await page.goto('/src/components/datetime/test/minmax', config); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').first().waitFor(); const calendarMonths = page.locator('ion-datetime#min-with-day .calendar-month'); @@ -102,7 +102,7 @@ configs({ directions: ['ltr'], modes: ['ios'] }).forEach(({ title, config }) => config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const ionPopoverDidPresent = await page.spyOnEvent('ionPopoverDidPresent'); @@ -124,7 +124,7 @@ configs({ directions: ['ltr'], modes: ['ios'] }).forEach(({ title, config }) => test.describe('setting value outside bounds should show in-bounds month', () => { const testDisplayedMonth = async (page: E2EPage, content: string, expectedString = /June 2021/) => { await page.setContent(content, config); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const calendarMonthYear = page.locator('ion-datetime .calendar-month-year'); await expect(calendarMonthYear).toHaveText(expectedString); @@ -174,7 +174,7 @@ configs({ directions: ['ltr'], modes: ['ios'] }).forEach(({ title, config }) => `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const datetimeMonthDidChange = await page.spyOnEvent('datetimeMonthDidChange'); const eventButton = page.locator('button#bind'); @@ -260,7 +260,7 @@ configs({ directions: ['ltr'], modes: ['ios'] }).forEach(({ title, config }) => config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const datetime = page.locator('ion-datetime'); const ionChange = await page.spyOnEvent('ionChange'); @@ -283,7 +283,7 @@ configs({ directions: ['ltr'], modes: ['ios'] }).forEach(({ title, config }) => config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const datetime = page.locator('ion-datetime'); const ionChange = await page.spyOnEvent('ionChange'); @@ -311,7 +311,7 @@ configs({ directions: ['ltr'], modes: ['ios'] }).forEach(({ title, config }) => const monthColumnItems = page.locator('ion-datetime .month-column .picker-item:not(.picker-item-empty)'); const ionChange = await page.spyOnEvent('ionChange'); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); await monthColumnItems.nth(0).click(); // switch to January await ionChange.next(); @@ -346,7 +346,7 @@ configs({ directions: ['ltr'], modes: ['ios'] }).forEach(({ title, config }) => `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); // Select Jan 10, 2022 const maxDate = page.locator('ion-datetime .calendar-day[data-day="10"][data-month="1"][data-year="2022"]'); diff --git a/core/src/components/datetime/test/month-year-picker/datetime.e2e.ts b/core/src/components/datetime/test/month-year-picker/datetime.e2e.ts index 9b421777239..beda3e664b5 100644 --- a/core/src/components/datetime/test/month-year-picker/datetime.e2e.ts +++ b/core/src/components/datetime/test/month-year-picker/datetime.e2e.ts @@ -8,7 +8,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => test.describe(title('datetime: month-year picker'), () => { test.beforeEach(async ({ page }) => { await page.goto('/src/components/datetime/test/month-year-picker', config); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').first().waitFor(); }); test('should hide the footer when picker is open', async ({ page }) => { diff --git a/core/src/components/datetime/test/multiple/datetime.e2e.ts b/core/src/components/datetime/test/multiple/datetime.e2e.ts index c3a195b89b6..0e2c0efb381 100644 --- a/core/src/components/datetime/test/multiple/datetime.e2e.ts +++ b/core/src/components/datetime/test/multiple/datetime.e2e.ts @@ -62,7 +62,7 @@ class DatetimeMultipleFixture { ); this.datetime = this.page.locator('ion-datetime'); - await this.page.waitForSelector('.datetime-ready'); + await this.page.locator('.datetime-ready').waitFor(); return this.datetime; } @@ -304,7 +304,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { `, config ); - await page.waitForSelector(`.datetime-ready`); + await page.locator(`.datetime-ready`).waitFor(); const datetime = page.locator('ion-datetime'); const header = datetime.locator('.datetime-selected-date'); diff --git a/core/src/components/datetime/test/position/datetime.e2e.ts b/core/src/components/datetime/test/position/datetime.e2e.ts index f2f705c3075..c817e3c6d0b 100644 --- a/core/src/components/datetime/test/position/datetime.e2e.ts +++ b/core/src/components/datetime/test/position/datetime.e2e.ts @@ -11,7 +11,7 @@ configs().forEach(({ title, screenshot, config }) => { await openDateTimeBtn.click(); await ionPopoverDidPresent.next(); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); await expect(page).toHaveScreenshot(screenshot(`datetime-position-base`)); diff --git a/core/src/components/datetime/test/prefer-wheel/datetime.e2e.ts b/core/src/components/datetime/test/prefer-wheel/datetime.e2e.ts index f00c313889b..f90337e870c 100644 --- a/core/src/components/datetime/test/prefer-wheel/datetime.e2e.ts +++ b/core/src/components/datetime/test/prefer-wheel/datetime.e2e.ts @@ -23,7 +23,7 @@ configs().forEach(({ title, screenshot, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); await expect(page).toHaveScreenshot(screenshot(`datetime-wheel-date-diff`)); }); @@ -34,7 +34,7 @@ configs().forEach(({ title, screenshot, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); await expect(page).toHaveScreenshot(screenshot(`datetime-wheel-date-time-diff`)); }); @@ -45,7 +45,7 @@ configs().forEach(({ title, screenshot, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); await expect(page).toHaveScreenshot(screenshot(`datetime-wheel-time-date-diff`)); }); @@ -56,7 +56,7 @@ configs().forEach(({ title, screenshot, config }) => { `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const datetime = page.locator('ion-datetime'); @@ -80,7 +80,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const dayValues = page.locator('ion-datetime .day-column .picker-item[data-value]'); expect(await dayValues.count()).toEqual(27); @@ -93,7 +93,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const dayValues = page.locator('ion-datetime .day-column .picker-item[data-value]'); expect(await dayValues.count()).toEqual(1); @@ -116,7 +116,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const disabledMonths = page.locator('.month-column .picker-item[disabled]'); const disabledYears = page.locator('.year-column .picker-item[disabled]'); @@ -141,7 +141,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const monthValues = page.locator('.month-column .picker-item:not(.picker-item-empty)'); const yearValues = page.locator('.year-column .picker-item:not(.picker-item-empty)'); @@ -175,7 +175,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const ionChange = await page.spyOnEvent('ionChange'); const monthValues = page.locator('.month-column .picker-item:not(.picker-item-empty)'); @@ -209,7 +209,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const ionChange = await page.spyOnEvent('ionChange'); const dayValues = page.locator('.day-column .picker-item:not(.picker-item-empty)'); @@ -230,7 +230,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const ionChange = await page.spyOnEvent('ionChange'); const yearValues = page.locator('.year-column .picker-item:not(.picker-item-empty)'); @@ -253,7 +253,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const datetime = page.locator('ion-datetime'); await datetime.evaluate((el: HTMLIonDatetimeElement) => (el.value = '2021-05-25T12:40:00.000Z')); @@ -285,7 +285,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const monthValues = page.locator('.month-column .picker-item:not(.picker-item-empty)'); const dayValues = page.locator('.day-column .picker-item:not(.picker-item-empty)'); @@ -306,7 +306,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const columns = page.locator('ion-picker-column-internal'); @@ -327,7 +327,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const columns = page.locator('ion-picker-column-internal'); @@ -346,7 +346,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const dayValues = page.locator('ion-datetime .date-column .picker-item[data-value]'); expect(await dayValues.count()).toEqual(57); @@ -359,7 +359,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const dayValues = page.locator('ion-datetime .date-column .picker-item[data-value]'); expect(await dayValues.count()).toEqual(41); @@ -382,7 +382,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const disabledDates = page.locator('.date-column .picker-item[disabled]'); @@ -403,7 +403,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const dateValues = page.locator('.date-column .picker-item:not(.picker-item-empty)'); @@ -424,7 +424,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const dateValues = page.locator('.date-column .picker-item:not(.picker-item-empty)'); @@ -444,7 +444,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const dateColumn = page.locator('.date-column'); const dateValues = dateColumn.locator('.picker-item:not(.picker-item-empty)'); @@ -474,7 +474,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const dayValues = page.locator('.date-column .picker-item:not(.picker-item-empty)'); @@ -494,7 +494,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const dayValues = page.locator('.date-column .picker-item:not(.picker-item-empty)'); @@ -511,7 +511,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const ionChange = await page.spyOnEvent('ionChange'); const dayValues = page.locator('.date-column .picker-item:not(.picker-item-empty)'); @@ -531,7 +531,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const dayValues = page.locator('ion-datetime .date-column .picker-item[data-value]'); expect(await dayValues.count()).toEqual(57); @@ -544,7 +544,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const dayValues = page.locator('ion-datetime .date-column .picker-item[data-value]'); expect(await dayValues.count()).toEqual(41); @@ -567,7 +567,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const disabledDates = page.locator('.date-column .picker-item[disabled]'); @@ -588,7 +588,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const dateValues = page.locator('.date-column .picker-item:not(.picker-item-empty)'); @@ -609,7 +609,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const dateValues = page.locator('.date-column .picker-item:not(.picker-item-empty)'); @@ -629,7 +629,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const dateColumn = page.locator('.date-column'); const dateValues = dateColumn.locator('.picker-item:not(.picker-item-empty)'); @@ -659,7 +659,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const dayValues = page.locator('.date-column .picker-item:not(.picker-item-empty)'); @@ -679,7 +679,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const dayValues = page.locator('.date-column .picker-item:not(.picker-item-empty)'); diff --git a/core/src/components/datetime/test/presentation/datetime.e2e.ts b/core/src/components/datetime/test/presentation/datetime.e2e.ts index 7bff588cab4..af0055a8142 100644 --- a/core/src/components/datetime/test/presentation/datetime.e2e.ts +++ b/core/src/components/datetime/test/presentation/datetime.e2e.ts @@ -117,7 +117,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const datetime = page.locator('ion-datetime'); const monthYearButton = page.locator('ion-datetime .calendar-month-year'); @@ -189,7 +189,7 @@ class DatetimePresentationFixture { `, config ); - await this.page.waitForSelector('.datetime-ready'); + await this.page.locator('.datetime-ready').waitFor(); this.datetime = this.page.locator('ion-datetime'); } @@ -214,7 +214,7 @@ class TimePickerFixture { `, config ); - await this.page.waitForSelector('.datetime-ready'); + await this.page.locator('.datetime-ready').waitFor(); this.timePicker = this.page.locator('ion-datetime'); } diff --git a/core/src/components/datetime/test/readonly/datetime.e2e.ts b/core/src/components/datetime/test/readonly/datetime.e2e.ts index f157bd36e32..f16b6faf216 100644 --- a/core/src/components/datetime/test/readonly/datetime.e2e.ts +++ b/core/src/components/datetime/test/readonly/datetime.e2e.ts @@ -27,7 +27,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config, scree config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const febFirstButton = page.locator(`.calendar-day[data-day='1'][data-month='2']`); @@ -43,7 +43,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config, scree ); const ionChange = await page.spyOnEvent('ionChange'); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const calendarMonthYear = page.locator('ion-datetime .calendar-month-year'); await expect(calendarMonthYear).toHaveText('February 2022'); @@ -66,7 +66,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config, scree const tabKey = browserName === 'webkit' ? 'Alt+Tab' : 'Tab'; - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const calendarMonthYear = page.locator('ion-datetime .calendar-month-year'); const monthYearButton = page.locator('.calendar-month-year ion-item'); await expect(calendarMonthYear).toHaveText('February 2022'); @@ -157,7 +157,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config, scree config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const clearButton = page.locator('#clear-button button'); diff --git a/core/src/components/datetime/test/set-value/datetime.e2e.ts b/core/src/components/datetime/test/set-value/datetime.e2e.ts index 798b87144a1..37daadf2b83 100644 --- a/core/src/components/datetime/test/set-value/datetime.e2e.ts +++ b/core/src/components/datetime/test/set-value/datetime.e2e.ts @@ -5,7 +5,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => test.describe(title('datetime: set-value'), () => { test('should update the active date when value is initially set', async ({ page }) => { await page.goto('/src/components/datetime/test/set-value', config); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const datetime = page.locator('ion-datetime'); await datetime.evaluate((el: HTMLIonDatetimeElement) => (el.value = '2021-11-25T12:40:00.000Z')); @@ -18,7 +18,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => test('should update the active time when value is initially set', async ({ page }) => { await page.goto('/src/components/datetime/test/set-value', config); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const datetime = page.locator('ion-datetime'); await datetime.evaluate((el: HTMLIonDatetimeElement) => (el.value = '2021-11-25T12:40:00.000Z')); @@ -37,7 +37,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const datetime = page.locator('ion-datetime'); const activeDayButton = page.locator('.calendar-day-active'); @@ -53,7 +53,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => test('should scroll to new month when value is initially set and then updated', async ({ page }) => { await page.goto('/src/components/datetime/test/set-value', config); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const datetime = page.locator('ion-datetime'); await datetime.evaluate((el: HTMLIonDatetimeElement) => (el.value = '2021-05-25T12:40:00.000Z')); diff --git a/core/src/components/datetime/test/time-label/datetime.e2e.ts b/core/src/components/datetime/test/time-label/datetime.e2e.ts index cf3fb9f7806..88acbbe8570 100644 --- a/core/src/components/datetime/test/time-label/datetime.e2e.ts +++ b/core/src/components/datetime/test/time-label/datetime.e2e.ts @@ -10,7 +10,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const timeLabel = page.locator('ion-datetime .time-header'); await expect(timeLabel).toHaveText('Time'); @@ -22,7 +22,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const timeLabel = page.locator('ion-datetime .time-header'); await expect(timeLabel).toHaveText(''); diff --git a/core/src/components/datetime/test/values/datetime.e2e.ts b/core/src/components/datetime/test/values/datetime.e2e.ts index e785e484e00..ce17cc16019 100644 --- a/core/src/components/datetime/test/values/datetime.e2e.ts +++ b/core/src/components/datetime/test/values/datetime.e2e.ts @@ -10,7 +10,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => `, config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const items = page.locator('.calendar-day:not([disabled])'); @@ -91,7 +91,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const minuteItems = page.locator( 'ion-picker-column-internal:nth-of-type(2) .picker-item:not(.picker-item-empty)' @@ -137,7 +137,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const monthItems = page.locator('.month-column .picker-item:not(.picker-item-empty)'); await expect(monthItems).toHaveText(['January']); @@ -169,7 +169,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => config ); - await page.waitForSelector('.datetime-ready'); + await page.locator('.datetime-ready').waitFor(); const todayButton = page.locator('.calendar-day[data-day="10"][data-month="10"][data-year="2022"]'); diff --git a/core/src/components/header/test/condense/header.e2e.ts b/core/src/components/header/test/condense/header.e2e.ts index c2ac59efd0f..791c1b720af 100644 --- a/core/src/components/header/test/condense/header.e2e.ts +++ b/core/src/components/header/test/condense/header.e2e.ts @@ -16,7 +16,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, screenshot, c await content.evaluate(async (el: HTMLIonContentElement) => { await el.scrollToBottom(); }); - await page.waitForSelector('#largeTitleHeader.header-collapse-condense-inactive'); + await page.locator('#largeTitleHeader.header-collapse-condense-inactive').waitFor(); await expect(smallTitleHeader).toHaveScreenshot(screenshot(`header-condense-large-title-collapsed-diff`)); @@ -30,7 +30,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, screenshot, c await content.evaluate(async (el: HTMLIonContentElement) => { await el.scrollToTop(); }); - await page.waitForSelector('#smallTitleHeader.header-collapse-condense-inactive'); + await page.locator('#smallTitleHeader.header-collapse-condense-inactive').waitFor(); await expect(smallTitleHeader).toHaveAttribute('aria-hidden', 'true'); }); diff --git a/core/src/components/item/item.scss b/core/src/components/item/item.scss index 94329434c35..aa52b7b953e 100644 --- a/core/src/components/item/item.scss +++ b/core/src/components/item/item.scss @@ -51,15 +51,6 @@ * @prop --highlight-color-valid: The color of the highlight on the item when valid. Only applies to inputs and textareas using the legacy form syntax. DEPRECATED: Highlights can be styled on `ion-input` or `ion-textarea` when using the modern form syntax. * @prop --highlight-color-invalid: The color of the highlight on the item when invalid. Only applies to inputs and textareas using the legacy form syntax. DEPRECATED: Highlights can be styled on `ion-input` or `ion-textarea` when using the modern form syntax. */ - - /** - * We change the minimum width as the - * font size changes. Using a fixed minimum - * width means that fewer and fewer characters - * can be displayed in the same space as the - * text grows. - */ - --inner-min-width: 4rem; --border-radius: 0px; --border-width: 0px; --border-style: solid; @@ -230,11 +221,6 @@ display: flex; position: relative; - // Flex wrap is required here in order to wrap - // the start slot + .item-inner content that - // doesn't fit on the same line - flex-wrap: wrap; - align-items: inherit; justify-content: inherit; @@ -258,11 +244,6 @@ box-sizing: border-box; } -// TODO(FW-5289): remove -:host(.item-legacy) .item-native { - flex-wrap: unset; -} - .item-native::-moz-focus-inner { border: 0; } @@ -307,34 +288,13 @@ button, a { // This is required to work with an inset highlight position: relative; - // This flex property is required in order to make - // the elements wrap when there is a slotted start - // element and a label - flex: 1 0 0; + flex: 1; flex-direction: inherit; - // Flex wrap is required here in order to wrap - // .input-wrapper content + the end slot that - // doesn't fit on the same line - flex-wrap: wrap; - align-items: inherit; align-self: stretch; - /** - * The min-width defines when the - * content in the default slot should - * stop wrapping/truncating within its own - * container. At this point the entire - * container will wrap to the next line. - */ - min-width: var(--inner-min-width); - - // Max width must be set to 100%, otherwise the - // elements will overflow this container instead - // of wrapping - max-width: 100%; min-height: inherit; border-width: var(--inner-border-width); @@ -346,15 +306,6 @@ button, a { box-sizing: border-box; } -// TODO(FW-5289): remove -:host(.item-legacy) .item-inner { - flex: 1; - - flex-wrap: unset; - - max-width: unset; -} - // Item Bottom // -------------------------------------------------- @@ -448,38 +399,19 @@ button, a { // This flex property is required in order to keep // the label from shrinking when there are wide // elements next to it - flex: 1 0 auto; + flex: 1; flex-direction: inherit; - // Flex wrap is required here in order to wrap - // content in the default slot (such as a label - // and a button) that doesn't fit on the same line - flex-wrap: wrap; - align-items: inherit; align-self: stretch; - // Max width must be set to 100%, otherwise the - // elements will overflow this container instead - // of wrapping - max-width: 100%; - text-overflow: ellipsis; overflow: inherit; box-sizing: border-box; } -// TODO(FW-5289): remove -:host(.item-legacy) .input-wrapper { - flex: 1; - - flex-wrap: unset; - - max-width: unset; -} - :host(.item-label-stacked), :host(.item-label-floating) { align-items: start; diff --git a/core/src/components/item/item.tsx b/core/src/components/item/item.tsx index ad056c5cdfc..c6c18d4e981 100644 --- a/core/src/components/item/item.tsx +++ b/core/src/components/item/item.tsx @@ -150,6 +150,12 @@ export class Item implements ComponentInterface, AnchorInterface, ButtonInterfac @State() counterString: string | null | undefined; + @Watch('button') + buttonChanged() { + // Update the focusable option when the button option is changed + this.focusable = this.isFocusable(); + } + @Watch('counterFormatter') counterFormatterChanged() { this.updateCounterOutput(this.getFirstInput()); diff --git a/core/src/components/item/test/a11y/index.html b/core/src/components/item/test/a11y/index.html index 9aad84631c2..18fb4d703d9 100644 --- a/core/src/components/item/test/a11y/index.html +++ b/core/src/components/item/test/a11y/index.html @@ -16,23 +16,19 @@

Item

- Item with Input - + - Item disabled with Input - + - Item with Input disabled - + - Item with Select - + No Game Console NES Nintendo64 @@ -44,8 +40,7 @@

Item

 - Item disabled with Select - + No Game Console NES Nintendo64 @@ -57,8 +52,7 @@

Item

 - Item with Select disabled - + No Game Console NES Nintendo64 @@ -70,33 +64,27 @@

Item

 - Item with Toggle - + Item with Toggle - Item disabled with Toggle - + Item disabled with Toggle - Item with Toggle disabled - + Item with Toggle disabled - Item with Radio - + Item with Radio - Item disabled with Radio - + Item disabled with Radio - Item with Radio disabled - + Item with Radio disabled diff --git a/core/src/components/item/test/a11y/item.e2e.ts-snapshots/item-buttons-scale-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/item/test/a11y/item.e2e.ts-snapshots/item-buttons-scale-ios-ltr-Mobile-Chrome-linux.png index 5dcb0bd7265..236a060b294 100644 Binary files a/core/src/components/item/test/a11y/item.e2e.ts-snapshots/item-buttons-scale-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/item/test/a11y/item.e2e.ts-snapshots/item-buttons-scale-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/a11y/item.e2e.ts-snapshots/item-buttons-scale-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/item/test/a11y/item.e2e.ts-snapshots/item-buttons-scale-ios-ltr-Mobile-Firefox-linux.png index 7ca90b8b85e..0eaca5aaeb4 100644 Binary files a/core/src/components/item/test/a11y/item.e2e.ts-snapshots/item-buttons-scale-ios-ltr-Mobile-Firefox-linux.png and b/core/src/components/item/test/a11y/item.e2e.ts-snapshots/item-buttons-scale-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/item/test/a11y/item.e2e.ts-snapshots/item-buttons-scale-ios-ltr-Mobile-Safari-linux.png b/core/src/components/item/test/a11y/item.e2e.ts-snapshots/item-buttons-scale-ios-ltr-Mobile-Safari-linux.png index 6cedd64817b..bd8d901f736 100644 Binary files a/core/src/components/item/test/a11y/item.e2e.ts-snapshots/item-buttons-scale-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/item/test/a11y/item.e2e.ts-snapshots/item-buttons-scale-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/item/test/a11y/item.e2e.ts-snapshots/item-buttons-scale-md-ltr-Mobile-Chrome-linux.png b/core/src/components/item/test/a11y/item.e2e.ts-snapshots/item-buttons-scale-md-ltr-Mobile-Chrome-linux.png index 9e54eac08ad..c98e7f9dfcf 100644 Binary files a/core/src/components/item/test/a11y/item.e2e.ts-snapshots/item-buttons-scale-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/item/test/a11y/item.e2e.ts-snapshots/item-buttons-scale-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/a11y/item.e2e.ts-snapshots/item-buttons-scale-md-ltr-Mobile-Firefox-linux.png b/core/src/components/item/test/a11y/item.e2e.ts-snapshots/item-buttons-scale-md-ltr-Mobile-Firefox-linux.png index a3e9d3e2aa7..89acf693034 100644 Binary files a/core/src/components/item/test/a11y/item.e2e.ts-snapshots/item-buttons-scale-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/item/test/a11y/item.e2e.ts-snapshots/item-buttons-scale-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/item/test/a11y/item.e2e.ts-snapshots/item-buttons-scale-md-ltr-Mobile-Safari-linux.png b/core/src/components/item/test/a11y/item.e2e.ts-snapshots/item-buttons-scale-md-ltr-Mobile-Safari-linux.png index 99cb77ae039..ff14e8e3491 100644 Binary files a/core/src/components/item/test/a11y/item.e2e.ts-snapshots/item-buttons-scale-md-ltr-Mobile-Safari-linux.png and b/core/src/components/item/test/a11y/item.e2e.ts-snapshots/item-buttons-scale-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/item/test/basic/index.html b/core/src/components/item/test/basic/index.html index 7cf41908848..f9d6c77bb72 100644 --- a/core/src/components/item/test/basic/index.html +++ b/core/src/components/item/test/basic/index.html @@ -98,8 +98,9 @@

H4 Title Text

 - PIN: - No Helper/Error - + - Helper and Error - + Helper Text Error Text - Helper Only - + Helper Text - Error Only - + Error Text - Both w/ Custom CSS - + Helper Text Error Text @@ -66,16 +61,14 @@ - Helper and Error (Fill Solid) - + Helper Text Error Text - Helper and Error (Fill Outline) - + Helper Text Error Text @@ -84,8 +77,7 @@ - Toggle Error - + Toggle Error diff --git a/core/src/components/item/test/counter/item.e2e.ts-snapshots/item-counter-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/item/test/counter/item.e2e.ts-snapshots/item-counter-diff-md-ltr-Mobile-Firefox-linux.png index 6d1b1acb875..b7f3579a707 100644 Binary files a/core/src/components/item/test/counter/item.e2e.ts-snapshots/item-counter-diff-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/item/test/counter/item.e2e.ts-snapshots/item-counter-diff-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/item/test/counter/item.e2e.ts-snapshots/item-counter-diff-md-rtl-Mobile-Firefox-linux.png b/core/src/components/item/test/counter/item.e2e.ts-snapshots/item-counter-diff-md-rtl-Mobile-Firefox-linux.png index a290ec89332..19453840539 100644 Binary files a/core/src/components/item/test/counter/item.e2e.ts-snapshots/item-counter-diff-md-rtl-Mobile-Firefox-linux.png and b/core/src/components/item/test/counter/item.e2e.ts-snapshots/item-counter-diff-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/item/test/highlight/item.e2e.ts-snapshots/item-highlight-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/item/test/highlight/item.e2e.ts-snapshots/item-highlight-diff-md-ltr-Mobile-Chrome-linux.png index d5057c87b3c..3d20782dc97 100644 Binary files a/core/src/components/item/test/highlight/item.e2e.ts-snapshots/item-highlight-diff-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/item/test/highlight/item.e2e.ts-snapshots/item-highlight-diff-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/highlight/item.e2e.ts-snapshots/item-highlight-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/item/test/highlight/item.e2e.ts-snapshots/item-highlight-diff-md-ltr-Mobile-Firefox-linux.png index 32cd77abd23..39274d225ba 100644 Binary files a/core/src/components/item/test/highlight/item.e2e.ts-snapshots/item-highlight-diff-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/item/test/highlight/item.e2e.ts-snapshots/item-highlight-diff-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/item/test/highlight/item.e2e.ts-snapshots/item-highlight-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/item/test/highlight/item.e2e.ts-snapshots/item-highlight-diff-md-ltr-Mobile-Safari-linux.png index 3f0b0328599..148333df747 100644 Binary files a/core/src/components/item/test/highlight/item.e2e.ts-snapshots/item-highlight-diff-md-ltr-Mobile-Safari-linux.png and b/core/src/components/item/test/highlight/item.e2e.ts-snapshots/item-highlight-diff-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/item/test/highlight/item.e2e.ts-snapshots/item-highlight-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/item/test/highlight/item.e2e.ts-snapshots/item-highlight-diff-md-rtl-Mobile-Chrome-linux.png index 43487eba48e..0ff00ef8e00 100644 Binary files a/core/src/components/item/test/highlight/item.e2e.ts-snapshots/item-highlight-diff-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/item/test/highlight/item.e2e.ts-snapshots/item-highlight-diff-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/highlight/item.e2e.ts-snapshots/item-highlight-diff-md-rtl-Mobile-Firefox-linux.png b/core/src/components/item/test/highlight/item.e2e.ts-snapshots/item-highlight-diff-md-rtl-Mobile-Firefox-linux.png index 6f4e7e9b987..7c67ea071d0 100644 Binary files a/core/src/components/item/test/highlight/item.e2e.ts-snapshots/item-highlight-diff-md-rtl-Mobile-Firefox-linux.png and b/core/src/components/item/test/highlight/item.e2e.ts-snapshots/item-highlight-diff-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/item/test/highlight/item.e2e.ts-snapshots/item-highlight-diff-md-rtl-Mobile-Safari-linux.png b/core/src/components/item/test/highlight/item.e2e.ts-snapshots/item-highlight-diff-md-rtl-Mobile-Safari-linux.png index d8d0caf5c5e..4f35e512fc5 100644 Binary files a/core/src/components/item/test/highlight/item.e2e.ts-snapshots/item-highlight-diff-md-rtl-Mobile-Safari-linux.png and b/core/src/components/item/test/highlight/item.e2e.ts-snapshots/item-highlight-diff-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/item/test/inputs/index.html b/core/src/components/item/test/inputs/index.html index 5ebe75aea7b..ac621ee8b51 100644 --- a/core/src/components/item/test/inputs/index.html +++ b/core/src/components/item/test/inputs/index.html @@ -39,18 +39,6 @@ Set "undefined" values - - Labels: Default - - - Labels: Floating - - - Labels: Stacked - - - Labels: Fixed - @@ -60,28 +48,23 @@
- Input - + - Textarea - + - Toggle - + Toggle - Checkbox - + Checkbox - Select - + 1 2 3 @@ -93,8 +76,7 @@ - Range - + @@ -147,28 +129,6 @@ toggle.checked = checkbox.checked = false; } - function setLabelDefault() { - setLabelPosition(undefined); - } - - function setLabelFixed() { - setLabelPosition('fixed'); - } - - function setLabelFloating() { - setLabelPosition('floating'); - } - - function setLabelStacked() { - setLabelPosition('stacked'); - } - - function setLabelPosition(position) { - Array.from(document.querySelectorAll('form ion-list ion-label')).forEach( - (label) => (label.position = position) - ); - } - function getFormControls() { return formControlIds.reduce((acc, id) => { acc[id] = document.querySelector(`#${id}`); diff --git a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-ios-ltr-Mobile-Chrome-linux.png index 16fde476d93..5e648162f20 100644 Binary files a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-ios-ltr-Mobile-Firefox-linux.png index f379936b303..0e5120ef3ac 100644 Binary files a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-ios-ltr-Mobile-Firefox-linux.png and b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-ios-ltr-Mobile-Safari-linux.png b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-ios-ltr-Mobile-Safari-linux.png index e536ff2645e..b2eb1638087 100644 Binary files a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-md-ltr-Mobile-Chrome-linux.png b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-md-ltr-Mobile-Chrome-linux.png index c9d778fa327..6f30797958c 100644 Binary files a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-md-ltr-Mobile-Firefox-linux.png b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-md-ltr-Mobile-Firefox-linux.png index 44175208bd9..83873459170 100644 Binary files a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-md-ltr-Mobile-Safari-linux.png b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-md-ltr-Mobile-Safari-linux.png index 574268ee6bc..a19e84eca21 100644 Binary files a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-md-ltr-Mobile-Safari-linux.png and b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-ltr-Mobile-Chrome-linux.png index 2c7ff81cf5d..81ca424c026 100644 Binary files a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-ltr-Mobile-Firefox-linux.png index 880e3366967..c207a965ea6 100644 Binary files a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-ltr-Mobile-Firefox-linux.png and b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-ltr-Mobile-Safari-linux.png b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-ltr-Mobile-Safari-linux.png index f0761cbf214..395057523db 100644 Binary files a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-rtl-Mobile-Chrome-linux.png index 580f45a23bf..2556440e693 100644 Binary files a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-rtl-Mobile-Firefox-linux.png index 473ed40edd9..255d73002b2 100644 Binary files a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-rtl-Mobile-Firefox-linux.png and b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-rtl-Mobile-Safari-linux.png b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-rtl-Mobile-Safari-linux.png index 2f1a7f6454d..4c8b6eee54f 100644 Binary files a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-rtl-Mobile-Safari-linux.png and b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-ltr-Mobile-Chrome-linux.png b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-ltr-Mobile-Chrome-linux.png index a7d5fd00258..1dd3849bdf4 100644 Binary files a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-ltr-Mobile-Firefox-linux.png b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-ltr-Mobile-Firefox-linux.png index 96d4a99df38..cfa42148a7b 100644 Binary files a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-ltr-Mobile-Safari-linux.png b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-ltr-Mobile-Safari-linux.png index 71421992417..4984cd298ea 100644 Binary files a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-ltr-Mobile-Safari-linux.png and b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-rtl-Mobile-Chrome-linux.png b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-rtl-Mobile-Chrome-linux.png index 5035d0f130b..164c214e50d 100644 Binary files a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-rtl-Mobile-Firefox-linux.png b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-rtl-Mobile-Firefox-linux.png index a48d9a81976..dccd74ec01d 100644 Binary files a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-rtl-Mobile-Firefox-linux.png and b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-rtl-Mobile-Safari-linux.png b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-rtl-Mobile-Safari-linux.png index 0859a1f2506..d50fce39762 100644 Binary files a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-rtl-Mobile-Safari-linux.png and b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/item/test/item.spec.tsx b/core/src/components/item/test/item.spec.tsx new file mode 100644 index 00000000000..750930ef828 --- /dev/null +++ b/core/src/components/item/test/item.spec.tsx @@ -0,0 +1,22 @@ +import { h } from '@stencil/core'; +import { newSpecPage } from '@stencil/core/testing'; + +import { Item } from '../item'; + +describe('item', () => { + it('should change focusable option after switching button option status', async () => { + const page = await newSpecPage({ + components: [Item], + template: () => , + }); + + const item = page.body.querySelector('ion-item')!; + // Change button attribute to true + item.setAttribute('button', 'true'); + + await page.waitForChanges(); + + // Check if it has the expected class that gives the highlight style to .item-highlight element + expect(item).toHaveClass('ion-focusable'); + }); +}); diff --git a/core/src/components/item/test/legacy/fill/item.e2e.ts-snapshots/item-fill-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/item/test/legacy/fill/item.e2e.ts-snapshots/item-fill-diff-md-ltr-Mobile-Chrome-linux.png index f9ddb05ee67..988ee7fe52c 100644 Binary files a/core/src/components/item/test/legacy/fill/item.e2e.ts-snapshots/item-fill-diff-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/item/test/legacy/fill/item.e2e.ts-snapshots/item-fill-diff-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/legacy/fill/item.e2e.ts-snapshots/item-fill-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/item/test/legacy/fill/item.e2e.ts-snapshots/item-fill-diff-md-ltr-Mobile-Firefox-linux.png index a9c60045cff..13a99e61f97 100644 Binary files a/core/src/components/item/test/legacy/fill/item.e2e.ts-snapshots/item-fill-diff-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/item/test/legacy/fill/item.e2e.ts-snapshots/item-fill-diff-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/item/test/legacy/fill/item.e2e.ts-snapshots/item-fill-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/item/test/legacy/fill/item.e2e.ts-snapshots/item-fill-diff-md-ltr-Mobile-Safari-linux.png index d2328b380e9..4aac1c769e3 100644 Binary files a/core/src/components/item/test/legacy/fill/item.e2e.ts-snapshots/item-fill-diff-md-ltr-Mobile-Safari-linux.png and b/core/src/components/item/test/legacy/fill/item.e2e.ts-snapshots/item-fill-diff-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/item/test/legacy/fill/item.e2e.ts-snapshots/item-fill-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/item/test/legacy/fill/item.e2e.ts-snapshots/item-fill-diff-md-rtl-Mobile-Chrome-linux.png index 27520c19562..04adf12a468 100644 Binary files a/core/src/components/item/test/legacy/fill/item.e2e.ts-snapshots/item-fill-diff-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/item/test/legacy/fill/item.e2e.ts-snapshots/item-fill-diff-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/legacy/fill/item.e2e.ts-snapshots/item-fill-diff-md-rtl-Mobile-Firefox-linux.png b/core/src/components/item/test/legacy/fill/item.e2e.ts-snapshots/item-fill-diff-md-rtl-Mobile-Firefox-linux.png index 471b7945fde..2051a27ef81 100644 Binary files a/core/src/components/item/test/legacy/fill/item.e2e.ts-snapshots/item-fill-diff-md-rtl-Mobile-Firefox-linux.png and b/core/src/components/item/test/legacy/fill/item.e2e.ts-snapshots/item-fill-diff-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/item/test/legacy/fill/item.e2e.ts-snapshots/item-fill-diff-md-rtl-Mobile-Safari-linux.png b/core/src/components/item/test/legacy/fill/item.e2e.ts-snapshots/item-fill-diff-md-rtl-Mobile-Safari-linux.png index 84422caf0ec..0ac689d7819 100644 Binary files a/core/src/components/item/test/legacy/fill/item.e2e.ts-snapshots/item-fill-diff-md-rtl-Mobile-Safari-linux.png and b/core/src/components/item/test/legacy/fill/item.e2e.ts-snapshots/item-fill-diff-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-ios-ltr-Mobile-Chrome-linux.png index 934f70a4feb..9afb2ddc75b 100644 Binary files a/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-ios-ltr-Mobile-Firefox-linux.png index f3b4bf8f2f0..e4dd9f7f2de 100644 Binary files a/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-ios-ltr-Mobile-Firefox-linux.png and b/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-ios-ltr-Mobile-Safari-linux.png b/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-ios-ltr-Mobile-Safari-linux.png index a818a230643..560b5c3c423 100644 Binary files a/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-ios-rtl-Mobile-Chrome-linux.png index 4e320ee56b6..e63f4f98e46 100644 Binary files a/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-ios-rtl-Mobile-Firefox-linux.png index 23d155a681a..410cbe9f1c5 100644 Binary files a/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-ios-rtl-Mobile-Firefox-linux.png and b/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-ios-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-ios-rtl-Mobile-Safari-linux.png b/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-ios-rtl-Mobile-Safari-linux.png index 28d35df5eaf..c29b9e50873 100644 Binary files a/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-ios-rtl-Mobile-Safari-linux.png and b/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-md-ltr-Mobile-Chrome-linux.png b/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-md-ltr-Mobile-Chrome-linux.png index ffb4b29d4ca..3c34d8be786 100644 Binary files a/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-md-ltr-Mobile-Firefox-linux.png b/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-md-ltr-Mobile-Firefox-linux.png index 34f656388a8..6b9aa6884eb 100644 Binary files a/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-md-ltr-Mobile-Safari-linux.png b/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-md-ltr-Mobile-Safari-linux.png index 9fe5e0465d0..63e7e5d1344 100644 Binary files a/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-md-ltr-Mobile-Safari-linux.png and b/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-md-rtl-Mobile-Chrome-linux.png b/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-md-rtl-Mobile-Chrome-linux.png index 01393f7725c..8a7f9c7e57e 100644 Binary files a/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-md-rtl-Mobile-Firefox-linux.png b/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-md-rtl-Mobile-Firefox-linux.png index 3c2f7449c23..8bb202e4bf3 100644 Binary files a/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-md-rtl-Mobile-Firefox-linux.png and b/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-md-rtl-Mobile-Safari-linux.png b/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-md-rtl-Mobile-Safari-linux.png index 37b1645f758..20468828f59 100644 Binary files a/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-md-rtl-Mobile-Safari-linux.png and b/core/src/components/item/test/slotted-inputs/item.e2e.ts-snapshots/item-slotted-inputs-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/label/test/basic/index.html b/core/src/components/label/test/basic/index.html index 96fba62ee2a..ed1a9cca2f7 100644 --- a/core/src/components/label/test/basic/index.html +++ b/core/src/components/label/test/basic/index.html @@ -41,58 +41,45 @@ Default - Tertiary - Custom - Wrap label this label just goes on and on and on - Fixed - Floating - Floating: Success - Stacked - Stacked: Danger - (Item: Tertiary) Floating - (Item: Primary) Stacked - (Item: Tertiary) Floating: Success - (Item: Primary) Stacked: Danger - diff --git a/core/src/components/label/test/basic/label.e2e.ts b/core/src/components/label/test/basic/label.e2e.ts index ca94e838c27..1deda110544 100644 --- a/core/src/components/label/test/basic/label.e2e.ts +++ b/core/src/components/label/test/basic/label.e2e.ts @@ -34,7 +34,7 @@ configs().forEach(({ title, screenshot, config }) => { ` My Label - + `, config @@ -49,7 +49,7 @@ configs().forEach(({ title, screenshot, config }) => { ` My Label - + `, config diff --git a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-ios-ltr-Mobile-Chrome-linux.png index edb9248e279..6a9650d0462 100644 Binary files a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-ios-ltr-Mobile-Firefox-linux.png index 5acaeaa2076..045042d578b 100644 Binary files a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-ios-ltr-Mobile-Firefox-linux.png and b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-ios-ltr-Mobile-Safari-linux.png b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-ios-ltr-Mobile-Safari-linux.png index cadad3801b1..6b7c624c4fc 100644 Binary files a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-ios-rtl-Mobile-Chrome-linux.png index cb646a9425f..a0685d23f35 100644 Binary files a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-ios-rtl-Mobile-Firefox-linux.png index 6b487599b38..93fbaba3681 100644 Binary files a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-ios-rtl-Mobile-Firefox-linux.png and b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-ios-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-ios-rtl-Mobile-Safari-linux.png b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-ios-rtl-Mobile-Safari-linux.png index 0d2a55d37ba..9ec079e6026 100644 Binary files a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-ios-rtl-Mobile-Safari-linux.png and b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-md-ltr-Mobile-Chrome-linux.png b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-md-ltr-Mobile-Chrome-linux.png index 43f5ec6a9dc..3ef7959c875 100644 Binary files a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-md-ltr-Mobile-Firefox-linux.png b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-md-ltr-Mobile-Firefox-linux.png index d9f5cd86f54..d7c0b7364cf 100644 Binary files a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-md-ltr-Mobile-Safari-linux.png b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-md-ltr-Mobile-Safari-linux.png index 13a83f03ab2..a98ea9c069d 100644 Binary files a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-md-ltr-Mobile-Safari-linux.png and b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-md-rtl-Mobile-Chrome-linux.png b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-md-rtl-Mobile-Chrome-linux.png index cc31a396838..cbdd36e0661 100644 Binary files a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-md-rtl-Mobile-Firefox-linux.png b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-md-rtl-Mobile-Firefox-linux.png index dd1a12c946c..efffe566ad6 100644 Binary files a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-md-rtl-Mobile-Firefox-linux.png and b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-md-rtl-Mobile-Safari-linux.png b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-md-rtl-Mobile-Safari-linux.png index 04e05033867..bdc5dcbc8eb 100644 Binary files a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-md-rtl-Mobile-Safari-linux.png and b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-floating-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-ios-ltr-Mobile-Chrome-linux.png index c85e47860a3..749245a24aa 100644 Binary files a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-ios-ltr-Mobile-Firefox-linux.png index f5bec426b1c..1c407de0a68 100644 Binary files a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-ios-ltr-Mobile-Firefox-linux.png and b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-ios-ltr-Mobile-Safari-linux.png b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-ios-ltr-Mobile-Safari-linux.png index db396488df9..27f590db1cc 100644 Binary files a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-ios-rtl-Mobile-Chrome-linux.png index cd189d2e9e8..3fc6a3b9351 100644 Binary files a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-ios-rtl-Mobile-Firefox-linux.png index dbe831dca44..220043b818e 100644 Binary files a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-ios-rtl-Mobile-Firefox-linux.png and b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-ios-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-ios-rtl-Mobile-Safari-linux.png b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-ios-rtl-Mobile-Safari-linux.png index d279b6a4a22..9deda169e20 100644 Binary files a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-ios-rtl-Mobile-Safari-linux.png and b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-md-ltr-Mobile-Chrome-linux.png b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-md-ltr-Mobile-Chrome-linux.png index 367a766a130..fd1496a11fa 100644 Binary files a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-md-ltr-Mobile-Firefox-linux.png b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-md-ltr-Mobile-Firefox-linux.png index ec3a667863b..8d847d79d82 100644 Binary files a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-md-ltr-Mobile-Safari-linux.png b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-md-ltr-Mobile-Safari-linux.png index 81c44f7edcc..f473cdbe523 100644 Binary files a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-md-ltr-Mobile-Safari-linux.png and b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-md-rtl-Mobile-Chrome-linux.png b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-md-rtl-Mobile-Chrome-linux.png index 9213ffad0b6..885612a082e 100644 Binary files a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-md-rtl-Mobile-Firefox-linux.png b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-md-rtl-Mobile-Firefox-linux.png index 659828a08be..24c74da1c27 100644 Binary files a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-md-rtl-Mobile-Firefox-linux.png and b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-md-rtl-Mobile-Safari-linux.png b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-md-rtl-Mobile-Safari-linux.png index 2ecff7a6358..51aaf2c28e3 100644 Binary files a/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-md-rtl-Mobile-Safari-linux.png and b/core/src/components/label/test/basic/label.e2e.ts-snapshots/label-stacked-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/modal/test/sheet/index.html b/core/src/components/modal/test/sheet/index.html index 8fed5eac09a..2a7eeb022ef 100644 --- a/core/src/components/modal/test/sheet/index.html +++ b/core/src/components/modal/test/sheet/index.html @@ -85,10 +85,7 @@ - - Input outside modal - - + Present Sheet Modal await ionModalDidPresent.next(); - const input = page.locator('#root-input input').first(); + const input = page.locator('#root-input').first(); await input.click(); await expect(input).toBeFocused(); }); diff --git a/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-ios-ltr-Mobile-Chrome-linux.png index d87c4c3893f..699dd3af83c 100644 Binary files a/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-ios-ltr-Mobile-Firefox-linux.png index 22afed2dab4..02ddc5ffef9 100644 Binary files a/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-ios-ltr-Mobile-Firefox-linux.png and b/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-ios-ltr-Mobile-Safari-linux.png b/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-ios-ltr-Mobile-Safari-linux.png index 7d77a2c9d0b..8549847278e 100644 Binary files a/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-md-ltr-Mobile-Chrome-linux.png b/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-md-ltr-Mobile-Chrome-linux.png index cafd8ae3f2d..a8ef5a35df7 100644 Binary files a/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-md-ltr-Mobile-Firefox-linux.png b/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-md-ltr-Mobile-Firefox-linux.png index 5b7ab097e3b..c26490f27bd 100644 Binary files a/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-md-ltr-Mobile-Safari-linux.png b/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-md-ltr-Mobile-Safari-linux.png index ab1a390d428..4ac26115828 100644 Binary files a/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-md-ltr-Mobile-Safari-linux.png and b/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/modal/test/spec/index.html b/core/src/components/modal/test/spec/index.html index d97fdd1de41..3060c5e0125 100644 --- a/core/src/components/modal/test/spec/index.html +++ b/core/src/components/modal/test/spec/index.html @@ -60,8 +60,7 @@ - Use Custom Animation - + Use Custom Animation diff --git a/core/src/components/modal/test/standalone/modal.e2e.ts b/core/src/components/modal/test/standalone/modal.e2e.ts index eaaa7a824f0..d422f4451e5 100644 --- a/core/src/components/modal/test/standalone/modal.e2e.ts +++ b/core/src/components/modal/test/standalone/modal.e2e.ts @@ -15,7 +15,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => await ionModalDidDismiss.next(); - await page.waitForSelector('ion-modal', { state: 'detached' }); + await page.locator('ion-modal').waitFor({ state: 'detached' }); }); }); }); diff --git a/core/src/components/note/test/a11y/note.e2e.ts b/core/src/components/note/test/a11y/note.e2e.ts index bf7839a7632..f3bbb76faab 100644 --- a/core/src/components/note/test/a11y/note.e2e.ts +++ b/core/src/components/note/test/a11y/note.e2e.ts @@ -72,33 +72,33 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { - Really really long note + 123 Label Label - Really really long note + 123 - Note + 123 Really really long label Really really long label - Note + 123 - Really really long note + 123 Really really long label Really really long label - Really really long note + 123 `, diff --git a/core/src/components/note/test/a11y/note.e2e.ts-snapshots/note-wrapping-label-scale-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/note/test/a11y/note.e2e.ts-snapshots/note-wrapping-label-scale-ios-ltr-Mobile-Chrome-linux.png index a5858136096..34ac4080910 100644 Binary files a/core/src/components/note/test/a11y/note.e2e.ts-snapshots/note-wrapping-label-scale-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/note/test/a11y/note.e2e.ts-snapshots/note-wrapping-label-scale-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/note/test/a11y/note.e2e.ts-snapshots/note-wrapping-label-scale-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/note/test/a11y/note.e2e.ts-snapshots/note-wrapping-label-scale-ios-ltr-Mobile-Firefox-linux.png index 4273df06f3c..154ee519c78 100644 Binary files a/core/src/components/note/test/a11y/note.e2e.ts-snapshots/note-wrapping-label-scale-ios-ltr-Mobile-Firefox-linux.png and b/core/src/components/note/test/a11y/note.e2e.ts-snapshots/note-wrapping-label-scale-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/note/test/a11y/note.e2e.ts-snapshots/note-wrapping-label-scale-ios-ltr-Mobile-Safari-linux.png b/core/src/components/note/test/a11y/note.e2e.ts-snapshots/note-wrapping-label-scale-ios-ltr-Mobile-Safari-linux.png index 7e665c4e970..5ffb775f75f 100644 Binary files a/core/src/components/note/test/a11y/note.e2e.ts-snapshots/note-wrapping-label-scale-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/note/test/a11y/note.e2e.ts-snapshots/note-wrapping-label-scale-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/note/test/a11y/note.e2e.ts-snapshots/note-wrapping-label-scale-md-ltr-Mobile-Chrome-linux.png b/core/src/components/note/test/a11y/note.e2e.ts-snapshots/note-wrapping-label-scale-md-ltr-Mobile-Chrome-linux.png index d2f8031710d..9c2ea22a522 100644 Binary files a/core/src/components/note/test/a11y/note.e2e.ts-snapshots/note-wrapping-label-scale-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/note/test/a11y/note.e2e.ts-snapshots/note-wrapping-label-scale-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/note/test/a11y/note.e2e.ts-snapshots/note-wrapping-label-scale-md-ltr-Mobile-Firefox-linux.png b/core/src/components/note/test/a11y/note.e2e.ts-snapshots/note-wrapping-label-scale-md-ltr-Mobile-Firefox-linux.png index 3625d21a1e7..69f53a28ada 100644 Binary files a/core/src/components/note/test/a11y/note.e2e.ts-snapshots/note-wrapping-label-scale-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/note/test/a11y/note.e2e.ts-snapshots/note-wrapping-label-scale-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/note/test/a11y/note.e2e.ts-snapshots/note-wrapping-label-scale-md-ltr-Mobile-Safari-linux.png b/core/src/components/note/test/a11y/note.e2e.ts-snapshots/note-wrapping-label-scale-md-ltr-Mobile-Safari-linux.png index 768ac8a47a6..9581c8d5505 100644 Binary files a/core/src/components/note/test/a11y/note.e2e.ts-snapshots/note-wrapping-label-scale-md-ltr-Mobile-Safari-linux.png and b/core/src/components/note/test/a11y/note.e2e.ts-snapshots/note-wrapping-label-scale-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/index.html b/core/src/components/popover/test/basic/index.html index 9ef6ba840c6..058aa69e08f 100644 --- a/core/src/components/popover/test/basic/index.html +++ b/core/src/components/popover/test/basic/index.html @@ -212,7 +212,7 @@

Translucent Popover

connectedCallback() { this.innerHTML = ` - + `; diff --git a/core/src/components/progress-bar/test/buffer/index.html b/core/src/components/progress-bar/test/buffer/index.html index 9bd10190557..fd1cdfc1956 100644 --- a/core/src/components/progress-bar/test/buffer/index.html +++ b/core/src/components/progress-bar/test/buffer/index.html @@ -60,7 +60,7 @@ - + 0 100 diff --git a/core/src/components/progress-bar/test/determinate/index.html b/core/src/components/progress-bar/test/determinate/index.html index 2ffda64dc34..7b1d9c6b40a 100644 --- a/core/src/components/progress-bar/test/determinate/index.html +++ b/core/src/components/progress-bar/test/determinate/index.html @@ -69,7 +69,7 @@ - + 0 100 diff --git a/core/src/components/radio-group/test/radio-group-events.e2e.ts b/core/src/components/radio-group/test/radio-group-events.e2e.ts index 12fb3243694..09deb2e7dbd 100644 --- a/core/src/components/radio-group/test/radio-group-events.e2e.ts +++ b/core/src/components/radio-group/test/radio-group-events.e2e.ts @@ -7,9 +7,9 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => await page.setContent( ` - - - + + + `, config @@ -29,9 +29,9 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => await page.setContent( ` - - - + + + `, config @@ -51,9 +51,9 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => await page.setContent( ` - - - + + + `, config @@ -72,9 +72,9 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => await page.setContent( ` - - - + + + `, config @@ -94,9 +94,9 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => await page.setContent( ` - - - + + + `, config diff --git a/core/src/components/range/test/label/range.e2e.ts b/core/src/components/range/test/label/range.e2e.ts index 409f4a32584..c8925d35a81 100644 --- a/core/src/components/range/test/label/range.e2e.ts +++ b/core/src/components/range/test/label/range.e2e.ts @@ -7,7 +7,7 @@ configs().forEach(({ title, screenshot, config }) => { test('should render a range with no visible label', async ({ page }) => { await page.setContent( ` - + `, config ); @@ -80,7 +80,7 @@ configs().forEach(({ title, screenshot, config }) => { test('should render a range with no visible label', async ({ page }) => { await page.setContent( ` - + diff --git a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-ios-ltr-Mobile-Chrome-linux.png index a8bd6b11c28..d8a13f78bd5 100644 Binary files a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-ios-ltr-Mobile-Firefox-linux.png index 20b52f6e9ac..5d35bc38507 100644 Binary files a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-ios-ltr-Mobile-Firefox-linux.png and b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-ios-ltr-Mobile-Safari-linux.png b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-ios-ltr-Mobile-Safari-linux.png index bddfe5df4d4..684e7423632 100644 Binary files a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-ios-rtl-Mobile-Chrome-linux.png index 06db2a4e7f9..af420833d1d 100644 Binary files a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-ios-rtl-Mobile-Firefox-linux.png index dc8c9481d0c..f6f965e45f1 100644 Binary files a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-ios-rtl-Mobile-Firefox-linux.png and b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-ios-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-ios-rtl-Mobile-Safari-linux.png b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-ios-rtl-Mobile-Safari-linux.png index dea69f8e08e..7bdc04cbb54 100644 Binary files a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-ios-rtl-Mobile-Safari-linux.png and b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-md-ltr-Mobile-Chrome-linux.png b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-md-ltr-Mobile-Chrome-linux.png index 85d942ab497..4b6e8680328 100644 Binary files a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-md-ltr-Mobile-Firefox-linux.png b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-md-ltr-Mobile-Firefox-linux.png index 7b7895e58a3..ee190b81449 100644 Binary files a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-md-ltr-Mobile-Safari-linux.png b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-md-ltr-Mobile-Safari-linux.png index a90b592471a..cbf9560c2f3 100644 Binary files a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-md-ltr-Mobile-Safari-linux.png and b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-md-rtl-Mobile-Chrome-linux.png b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-md-rtl-Mobile-Chrome-linux.png index f0bd79fc400..76e06285b38 100644 Binary files a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-md-rtl-Mobile-Firefox-linux.png b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-md-rtl-Mobile-Firefox-linux.png index cc3be5f0470..96af4347df1 100644 Binary files a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-md-rtl-Mobile-Firefox-linux.png and b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-md-rtl-Mobile-Safari-linux.png b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-md-rtl-Mobile-Safari-linux.png index 5c72694bf06..ff22d0e6fa6 100644 Binary files a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-md-rtl-Mobile-Safari-linux.png and b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-items-no-label-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-ios-ltr-Mobile-Chrome-linux.png index a5cb69a9bd1..08b3147a598 100644 Binary files a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-ios-ltr-Mobile-Firefox-linux.png index 57d20c5029b..441056c219c 100644 Binary files a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-ios-ltr-Mobile-Firefox-linux.png and b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-ios-ltr-Mobile-Safari-linux.png b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-ios-ltr-Mobile-Safari-linux.png index c19eb0ce6a8..7a9bb8cdcc3 100644 Binary files a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-ios-rtl-Mobile-Chrome-linux.png index 16c3d3cd67e..396aeafc860 100644 Binary files a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-ios-rtl-Mobile-Firefox-linux.png index e2362a244b5..29bcaab3921 100644 Binary files a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-ios-rtl-Mobile-Firefox-linux.png and b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-ios-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-ios-rtl-Mobile-Safari-linux.png b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-ios-rtl-Mobile-Safari-linux.png index a79e1039543..2dc0e0b2909 100644 Binary files a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-ios-rtl-Mobile-Safari-linux.png and b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-md-ltr-Mobile-Chrome-linux.png b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-md-ltr-Mobile-Chrome-linux.png index 424bba0f1b9..19109e87c7e 100644 Binary files a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-md-ltr-Mobile-Firefox-linux.png b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-md-ltr-Mobile-Firefox-linux.png index 146f76f1480..d1478b33a2d 100644 Binary files a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-md-ltr-Mobile-Safari-linux.png b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-md-ltr-Mobile-Safari-linux.png index 1e489e8489c..e522577c7e0 100644 Binary files a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-md-ltr-Mobile-Safari-linux.png and b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-md-rtl-Mobile-Chrome-linux.png b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-md-rtl-Mobile-Chrome-linux.png index 911c53b5502..41640c2beaf 100644 Binary files a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-md-rtl-Mobile-Firefox-linux.png b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-md-rtl-Mobile-Firefox-linux.png index 57b7484ee4a..8a26e9af16d 100644 Binary files a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-md-rtl-Mobile-Firefox-linux.png and b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-md-rtl-Mobile-Safari-linux.png b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-md-rtl-Mobile-Safari-linux.png index 9371b3a85cf..c03f792fea0 100644 Binary files a/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-md-rtl-Mobile-Safari-linux.png and b/core/src/components/range/test/label/range.e2e.ts-snapshots/range-no-items-no-label-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/range/test/range-events.e2e.ts b/core/src/components/range/test/range-events.e2e.ts index 3eeba5437b0..bc019628e12 100644 --- a/core/src/components/range/test/range-events.e2e.ts +++ b/core/src/components/range/test/range-events.e2e.ts @@ -20,7 +20,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => await page.setContent( `
- +
`, config @@ -52,7 +52,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => }); test('should emit start/end events, keyboard', async ({ page }) => { - await page.setContent(``, config); + await page.setContent(``, config); const rangeStart = await page.spyOnEvent('ionKnobMoveStart'); const rangeEnd = await page.spyOnEvent('ionKnobMoveEnd'); diff --git a/core/src/components/refresher/test/test.utils.ts b/core/src/components/refresher/test/test.utils.ts index 7454a889950..9bc15a7f0d2 100644 --- a/core/src/components/refresher/test/test.utils.ts +++ b/core/src/components/refresher/test/test.utils.ts @@ -14,7 +14,7 @@ import { dragElementByYAxis } from '@utils/test/playwright'; const pullToRefresh = async (page: E2EPage, selector = 'body') => { const target = page.locator(selector); - await page.waitForSelector('ion-refresher.hydrated', { state: 'attached' }); + await page.locator('ion-refresher.hydrated').waitFor({ state: 'attached' }); const ev = await page.spyOnEvent('ionRefreshComplete'); diff --git a/core/src/components/reorder-group/test/basic/index.html b/core/src/components/reorder-group/test/basic/index.html index bf44ef490ad..55e034c82ab 100644 --- a/core/src/components/reorder-group/test/basic/index.html +++ b/core/src/components/reorder-group/test/basic/index.html @@ -99,15 +99,13 @@ - Item 11 (the whole item can be dragged) - + Item 11 (the whole item can be dragged) - Item 12 (the whole item can be dragged) - + Item 12 (the whole item can be dragged) diff --git a/core/src/components/ripple-effect/test/basic/ripple-effect.e2e.ts b/core/src/components/ripple-effect/test/basic/ripple-effect.e2e.ts index 5d128bdca1e..763db925d84 100644 --- a/core/src/components/ripple-effect/test/basic/ripple-effect.e2e.ts +++ b/core/src/components/ripple-effect/test/basic/ripple-effect.e2e.ts @@ -29,7 +29,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { } // Waits for the ripple effect to be added - await page.waitForSelector('.ion-activated'); + await page.locator('.ion-activated').waitFor(); await expect(el).toHaveClass(/ion-activated/); }); @@ -56,7 +56,7 @@ const verifyRippleEffect = async (page: E2EPage, config: E2EPageOptions, selecto await page.mouse.down(); } - await page.waitForSelector('.ion-activated'); + await page.locator('.ion-activated').waitFor(); await expect(el).toHaveClass(/ion-activated/); }; diff --git a/core/src/components/router/test/guards/index.html b/core/src/components/router/test/guards/index.html index 0ea2d5ea900..9e9d0a29335 100644 --- a/core/src/components/router/test/guards/index.html +++ b/core/src/components/router/test/guards/index.html @@ -113,18 +113,15 @@ - Allow Navigation - + Allow Navigation - Block Navigation - + Block Navigation - Redirect - + Redirect @@ -136,18 +133,15 @@ - Allow Navigation - + Allow Navigation - Block Navigation - + Block Navigation - Redirect - + Redirect diff --git a/core/src/components/select/test/disabled/select.e2e.ts b/core/src/components/select/test/disabled/select.e2e.ts index 831d471d70f..9bc9389a3ad 100644 --- a/core/src/components/select/test/disabled/select.e2e.ts +++ b/core/src/components/select/test/disabled/select.e2e.ts @@ -14,7 +14,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => await page.setContent( ` - + A B diff --git a/core/src/components/textarea/test/textarea-events.e2e.ts b/core/src/components/textarea/test/textarea-events.e2e.ts index d463061023a..6b30f7a386f 100644 --- a/core/src/components/textarea/test/textarea-events.e2e.ts +++ b/core/src/components/textarea/test/textarea-events.e2e.ts @@ -8,7 +8,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => test.describe(title('textarea: events: ionChange'), () => { test.describe('when the textarea is blurred', () => { test('should emit if the value has changed', async ({ page }) => { - await page.setContent(``, config); + await page.setContent(``, config); const nativeTextarea = page.locator('ion-textarea textarea'); const ionChangeSpy = await page.spyOnEvent('ionChange'); @@ -24,7 +24,10 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => }); test('should emit if the textarea is cleared with an initial value', async ({ page }) => { - await page.setContent(``, config); + await page.setContent( + ``, + config + ); const textarea = page.locator('ion-textarea'); const nativeTextarea = textarea.locator('textarea'); @@ -41,7 +44,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => }); test('should not emit if the value is set programmatically', async ({ page }) => { - await page.setContent(``, config); + await page.setContent(``, config); const textarea = page.locator('ion-textarea'); const ionChangeSpy = await page.spyOnEvent('ionChange'); @@ -67,7 +70,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => }); test.describe(title('textarea: events: ionInput'), () => { test('should emit when the user types', async ({ page }) => { - await page.setContent(``, config); + await page.setContent(``, config); const ionInputSpy = await page.spyOnEvent('ionInput'); diff --git a/core/src/components/toast/toast-interface.ts b/core/src/components/toast/toast-interface.ts index d5ddff69e45..af320f59ba5 100644 --- a/core/src/components/toast/toast-interface.ts +++ b/core/src/components/toast/toast-interface.ts @@ -1,4 +1,4 @@ -import type { AnimationBuilder, Color, Mode } from '../../interface'; +import type { AnimationBuilder, Color, LiteralUnion, Mode } from '../../interface'; import type { IonicSafeString } from '../../utils/sanitization'; export interface ToastOptions { @@ -33,8 +33,7 @@ export interface ToastButton { text?: string; icon?: string; side?: 'start' | 'end'; - role?: 'cancel' | string; - + role?: LiteralUnion<'cancel', string>; /** * @deprecated Use the toast button's CSS Shadow Parts instead. */ diff --git a/core/src/components/toggle/test/enable-on-off-labels/index.html b/core/src/components/toggle/test/enable-on-off-labels/index.html index 4e18d63498d..28483e3203c 100644 --- a/core/src/components/toggle/test/enable-on-off-labels/index.html +++ b/core/src/components/toggle/test/enable-on-off-labels/index.html @@ -177,8 +177,7 @@ - Dark Mode - + Dark Mode diff --git a/core/src/interface.d.ts b/core/src/interface.d.ts index 3ac6705855b..83ae6e2b6b3 100644 --- a/core/src/interface.d.ts +++ b/core/src/interface.d.ts @@ -131,7 +131,7 @@ export type PredefinedColors = | 'medium' | 'dark'; -type LiteralUnion = T | (U & Record); +export type LiteralUnion = T | (U & Record); export type Color = LiteralUnion; export type Mode = 'ios' | 'md'; diff --git a/core/src/themes/test/css-variables/index.html b/core/src/themes/test/css-variables/index.html index 97ce01d8ef8..5b037535b4a 100644 --- a/core/src/themes/test/css-variables/index.html +++ b/core/src/themes/test/css-variables/index.html @@ -250,19 +250,16 @@ - + - Standard - Error Text - + + +
- - Standard + - - Helper Text - + @@ -354,18 +351,15 @@

Street Fighter II

Fruits - Apple - + Apple - Grape, checked, disabled - + Grape, checked, disabled - Cherry - + Cherry @@ -376,37 +370,34 @@

Street Fighter II

Veggies - Celery - + Celery - Lettuce, checked, disabled - + Lettuce, checked, disabled - Onion - + Onion - + - + - + - + @@ -414,65 +405,51 @@

Street Fighter II

- Default - + Default - Primary - + Primary - Secondary - + Secondary - Warning - + Warning - Danger - + Danger - Light - + Light - Dark - + Dark - Unchecked by Default - + Unchecked by Default - Disabled - + Disabled - - Blueberry + Blueberry - - Lettuce + Lettuce - - Apple + Apple - - Radish + Radish - - Blackberry + Blackberry
@@ -485,8 +462,7 @@

Street Fighter II

Colors
- Select a Theme: - + Default Oceanic Vibrant @@ -914,8 +890,7 @@

Street Fighter II

Overlays
- Select a Theme: - + Default Oceanic Vibrant @@ -951,8 +926,7 @@

Street Fighter II

- Select - + 1 2 3 diff --git a/core/src/utils/input-shims/hacks/test/index.html b/core/src/utils/input-shims/hacks/test/index.html index 18640942367..f4b138965a0 100644 --- a/core/src/utils/input-shims/hacks/test/index.html +++ b/core/src/utils/input-shims/hacks/test/index.html @@ -48,37 +48,31 @@ - Input Above Keyboard - + - Textarea Above Keyboard - +
- Input Below Keyboard - + - Textarea Below Keyboard - +
- Input Outside Viewport - + - Textarea Outside Viewport - + diff --git a/core/src/utils/keyboard/test/index.html b/core/src/utils/keyboard/test/index.html index 76656c9cd4a..cd61868ed8d 100644 --- a/core/src/utils/keyboard/test/index.html +++ b/core/src/utils/keyboard/test/index.html @@ -43,8 +43,8 @@ - - + + diff --git a/core/src/utils/test/overlays/index.html b/core/src/utils/test/overlays/index.html index 00885bd5552..51fa62440e7 100644 --- a/core/src/utils/test/overlays/index.html +++ b/core/src/utils/test/overlays/index.html @@ -34,8 +34,7 @@ - Text Input - + Create a Modal @@ -66,8 +65,7 @@ Modal Content - Text Input - + Create a Modal diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 78c0ed27d92..4e0f51a1994 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [7.6.7](https://github.com/ionic-team/ionic-framework/compare/v7.6.6...v7.6.7) (2024-01-31) + +**Note:** Version bump only for package @ionic/docs + + + + + ## [7.6.6](https://github.com/ionic-team/ionic-framework/compare/v7.6.5...v7.6.6) (2024-01-24) **Note:** Version bump only for package @ionic/docs diff --git a/docs/package-lock.json b/docs/package-lock.json index f34e364d371..d79ee44714e 100644 --- a/docs/package-lock.json +++ b/docs/package-lock.json @@ -1,12 +1,12 @@ { "name": "@ionic/docs", - "version": "7.6.6", + "version": "7.6.7", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/docs", - "version": "7.6.6", + "version": "7.6.7", "license": "MIT" } } diff --git a/docs/package.json b/docs/package.json index 09a3e97859e..16b68117dc3 100644 --- a/docs/package.json +++ b/docs/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/docs", - "version": "7.6.6", + "version": "7.6.7", "description": "Pre-packaged API documentation for the Ionic docs.", "main": "core.json", "types": "core.d.ts", diff --git a/lerna.json b/lerna.json index e48dc5be311..cf9b8a22c9b 100644 --- a/lerna.json +++ b/lerna.json @@ -4,5 +4,5 @@ "docs", "packages/*" ], - "version": "7.6.6" + "version": "7.6.7" } diff --git a/packages/angular-server/CHANGELOG.md b/packages/angular-server/CHANGELOG.md index d9a9ce11290..5ef3e2b8810 100644 --- a/packages/angular-server/CHANGELOG.md +++ b/packages/angular-server/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [7.6.7](https://github.com/ionic-team/ionic-framework/compare/v7.6.6...v7.6.7) (2024-01-31) + +**Note:** Version bump only for package @ionic/angular-server + + + + + ## [7.6.6](https://github.com/ionic-team/ionic-framework/compare/v7.6.5...v7.6.6) (2024-01-24) **Note:** Version bump only for package @ionic/angular-server diff --git a/packages/angular-server/package-lock.json b/packages/angular-server/package-lock.json index db3802f538d..fd4a071d5c5 100644 --- a/packages/angular-server/package-lock.json +++ b/packages/angular-server/package-lock.json @@ -1,15 +1,15 @@ { "name": "@ionic/angular-server", - "version": "7.6.6", + "version": "7.6.7", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/angular-server", - "version": "7.6.6", + "version": "7.6.7", "license": "MIT", "dependencies": { - "@ionic/core": "^7.6.6" + "@ionic/core": "^7.6.7" }, "devDependencies": { "@angular-eslint/eslint-plugin": "^14.0.0", @@ -1060,11 +1060,11 @@ "dev": true }, "node_modules/@ionic/core": { - "version": "7.6.6", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.6.6.tgz", - "integrity": "sha512-WstnLHiR8ipW2ASdO/eqSwgMHCuVvJE3qsUNPHWkup9f08/bcbKYZpOfaWNLw/ftNqEpFbjiRuocoYYyLP0/gw==", + "version": "7.6.7", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.6.7.tgz", + "integrity": "sha512-cb5mYBVmD1u5rQJBtT7erkSpOVprb8Qu55fh/vA+PTfD7p7QQxFxn5DJBUFQTIx/E2+BqgxkvZz/p2xmB5dUfg==", "dependencies": { - "@stencil/core": "^4.10.0", + "@stencil/core": "^4.12.0", "ionicons": "^7.2.2", "tslib": "^2.1.0" } @@ -1462,9 +1462,9 @@ "license": "MIT" }, "node_modules/@stencil/core": { - "version": "4.10.0", - "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.10.0.tgz", - "integrity": "sha512-7lDTPY1IxXN2/C+wQPHt3e/dYgY4YgelA8MxOsU3ZftXtpzWad/QNWhSAtKisJMrSjQh41jMDOgD0yLBwV6E7w==", + "version": "4.12.0", + "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.12.0.tgz", + "integrity": "sha512-qAQcfNmp2sdxAh1DlyUhHfDmIUS7mhI+5LAhPphg74zK9sKgFL5vpLzgjs0wohpjlmI4msgJFYiRB8lxVPqjPg==", "bin": { "stencil": "bin/stencil" }, @@ -7330,11 +7330,11 @@ "dev": true }, "@ionic/core": { - "version": "7.6.6", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.6.6.tgz", - "integrity": "sha512-WstnLHiR8ipW2ASdO/eqSwgMHCuVvJE3qsUNPHWkup9f08/bcbKYZpOfaWNLw/ftNqEpFbjiRuocoYYyLP0/gw==", + "version": "7.6.7", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.6.7.tgz", + "integrity": "sha512-cb5mYBVmD1u5rQJBtT7erkSpOVprb8Qu55fh/vA+PTfD7p7QQxFxn5DJBUFQTIx/E2+BqgxkvZz/p2xmB5dUfg==", "requires": { - "@stencil/core": "^4.10.0", + "@stencil/core": "^4.12.0", "ionicons": "^7.2.2", "tslib": "^2.1.0" } @@ -7581,9 +7581,9 @@ } }, "@stencil/core": { - "version": "4.10.0", - "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.10.0.tgz", - "integrity": "sha512-7lDTPY1IxXN2/C+wQPHt3e/dYgY4YgelA8MxOsU3ZftXtpzWad/QNWhSAtKisJMrSjQh41jMDOgD0yLBwV6E7w==" + "version": "4.12.0", + "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.12.0.tgz", + "integrity": "sha512-qAQcfNmp2sdxAh1DlyUhHfDmIUS7mhI+5LAhPphg74zK9sKgFL5vpLzgjs0wohpjlmI4msgJFYiRB8lxVPqjPg==" }, "@types/estree": { "version": "0.0.39", diff --git a/packages/angular-server/package.json b/packages/angular-server/package.json index 0fc0f5cb4c6..fd5a71ddcc8 100644 --- a/packages/angular-server/package.json +++ b/packages/angular-server/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/angular-server", - "version": "7.6.6", + "version": "7.6.7", "description": "Angular SSR Module for Ionic", "keywords": [ "ionic", @@ -62,6 +62,6 @@ }, "prettier": "@ionic/prettier-config", "dependencies": { - "@ionic/core": "^7.6.6" + "@ionic/core": "^7.6.7" } } diff --git a/packages/angular/CHANGELOG.md b/packages/angular/CHANGELOG.md index d4b946feadb..a43b64f65bc 100644 --- a/packages/angular/CHANGELOG.md +++ b/packages/angular/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [7.6.7](https://github.com/ionic-team/ionic-framework/compare/v7.6.6...v7.6.7) (2024-01-31) + +**Note:** Version bump only for package @ionic/angular + + + + + ## [7.6.6](https://github.com/ionic-team/ionic-framework/compare/v7.6.5...v7.6.6) (2024-01-24) **Note:** Version bump only for package @ionic/angular diff --git a/packages/angular/package-lock.json b/packages/angular/package-lock.json index 8e1c04ec1ef..ca02673c49a 100644 --- a/packages/angular/package-lock.json +++ b/packages/angular/package-lock.json @@ -1,15 +1,15 @@ { "name": "@ionic/angular", - "version": "7.6.6", + "version": "7.6.7", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/angular", - "version": "7.6.6", + "version": "7.6.7", "license": "MIT", "dependencies": { - "@ionic/core": "^7.6.6", + "@ionic/core": "^7.6.7", "ionicons": "^7.0.0", "jsonc-parser": "^3.0.0", "tslib": "^2.3.0" @@ -1407,11 +1407,11 @@ "dev": true }, "node_modules/@ionic/core": { - "version": "7.6.6", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.6.6.tgz", - "integrity": "sha512-WstnLHiR8ipW2ASdO/eqSwgMHCuVvJE3qsUNPHWkup9f08/bcbKYZpOfaWNLw/ftNqEpFbjiRuocoYYyLP0/gw==", + "version": "7.6.7", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.6.7.tgz", + "integrity": "sha512-cb5mYBVmD1u5rQJBtT7erkSpOVprb8Qu55fh/vA+PTfD7p7QQxFxn5DJBUFQTIx/E2+BqgxkvZz/p2xmB5dUfg==", "dependencies": { - "@stencil/core": "^4.10.0", + "@stencil/core": "^4.12.0", "ionicons": "^7.2.2", "tslib": "^2.1.0" } @@ -1845,9 +1845,9 @@ } }, "node_modules/@stencil/core": { - "version": "4.10.0", - "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.10.0.tgz", - "integrity": "sha512-7lDTPY1IxXN2/C+wQPHt3e/dYgY4YgelA8MxOsU3ZftXtpzWad/QNWhSAtKisJMrSjQh41jMDOgD0yLBwV6E7w==", + "version": "4.12.0", + "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.12.0.tgz", + "integrity": "sha512-qAQcfNmp2sdxAh1DlyUhHfDmIUS7mhI+5LAhPphg74zK9sKgFL5vpLzgjs0wohpjlmI4msgJFYiRB8lxVPqjPg==", "bin": { "stencil": "bin/stencil" }, @@ -9697,11 +9697,11 @@ "dev": true }, "@ionic/core": { - "version": "7.6.6", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.6.6.tgz", - "integrity": "sha512-WstnLHiR8ipW2ASdO/eqSwgMHCuVvJE3qsUNPHWkup9f08/bcbKYZpOfaWNLw/ftNqEpFbjiRuocoYYyLP0/gw==", + "version": "7.6.7", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.6.7.tgz", + "integrity": "sha512-cb5mYBVmD1u5rQJBtT7erkSpOVprb8Qu55fh/vA+PTfD7p7QQxFxn5DJBUFQTIx/E2+BqgxkvZz/p2xmB5dUfg==", "requires": { - "@stencil/core": "^4.10.0", + "@stencil/core": "^4.12.0", "ionicons": "^7.2.2", "tslib": "^2.1.0" } @@ -9994,9 +9994,9 @@ } }, "@stencil/core": { - "version": "4.10.0", - "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.10.0.tgz", - "integrity": "sha512-7lDTPY1IxXN2/C+wQPHt3e/dYgY4YgelA8MxOsU3ZftXtpzWad/QNWhSAtKisJMrSjQh41jMDOgD0yLBwV6E7w==" + "version": "4.12.0", + "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.12.0.tgz", + "integrity": "sha512-qAQcfNmp2sdxAh1DlyUhHfDmIUS7mhI+5LAhPphg74zK9sKgFL5vpLzgjs0wohpjlmI4msgJFYiRB8lxVPqjPg==" }, "@tootallnate/once": { "version": "2.0.0", diff --git a/packages/angular/package.json b/packages/angular/package.json index 8b3fdfc678a..c064c7585e3 100644 --- a/packages/angular/package.json +++ b/packages/angular/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/angular", - "version": "7.6.6", + "version": "7.6.7", "description": "Angular specific wrappers for @ionic/core", "keywords": [ "ionic", @@ -26,7 +26,6 @@ "scripts": { "build": "npm run clean && npm run build.ng && npm run build.core && npm run clean-generated", "build.core": "node scripts/build-core.js", - "build.link": "npm run build && node scripts/link-copy.js", "build.ng": "ng-packagr -p ng-package.json -c tsconfig.json", "build.watch": "npm run build.ng -- --watch", "clean": "node scripts/clean.js", @@ -48,7 +47,7 @@ } }, "dependencies": { - "@ionic/core": "^7.6.6", + "@ionic/core": "^7.6.7", "ionicons": "^7.0.0", "jsonc-parser": "^3.0.0", "tslib": "^2.3.0" diff --git a/packages/angular/scripts/README.md b/packages/angular/scripts/README.md deleted file mode 100644 index 95acfc6eb6e..00000000000 --- a/packages/angular/scripts/README.md +++ /dev/null @@ -1,21 +0,0 @@ -# Local @ionic/angular test/testapp development - -1. `npm install` at the root of `angular` -2. `npm run build.dev` to build local `@ionic/angular` and `@ionic/core` -3. `cd test/testapp` to the test app -4. `npm install` in the test app directory -5. `npm run serve` copies packages and serve the app (see package.json for more options) -6. [http://localhost:4200/](http://localhost:4200/) - - -# npm link local development - -`npm link` doesn't work as expected due to the `devDependency` on `@angular/core`. This is the work around... - - npm run build.link ../ionic-conference-app - -When the command above is ran from the `angular` directory, it will build `@ionic/angular` and copy the `dist` directory to the correct location of another local project. In the example above, the end result is that it copies the `dist` directory to `../ionic-conference-app/node_modules/@ionic/angular/dist`. The path given should be relative to the root of this mono repo. - -## package.json note - -The `package.json` file in this directory references __Ionic 3__ and is in here to get GitHub to properly show the Used By counts on the repo. __Do not remove it!__ diff --git a/packages/angular/scripts/link-copy.js b/packages/angular/scripts/link-copy.js deleted file mode 100644 index 5465e00a1af..00000000000 --- a/packages/angular/scripts/link-copy.js +++ /dev/null @@ -1,40 +0,0 @@ -const fs = require('fs-extra'); -const path = require('path'); - - -let prjDir = process.argv[2]; -if (!prjDir) { - throw new Error('local path required as last argument to "npm run build.link" command'); -} -prjDir = path.join(__dirname, '../../../', prjDir); - -copyPackage(prjDir, 'angular'); -copyPackage(prjDir, 'core'); - - -function copyPackage(prjDir, pkgName) { - const prjDest = path.join(prjDir, 'node_modules', '@ionic', pkgName); - - const pkgSrcDir = path.join(__dirname, '..', '..', pkgName); - const pkgSrcDist = path.join(pkgSrcDir, 'dist'); - const pkgJsonPath = path.join(pkgSrcDir, 'package.json'); - const pkgJson = require(pkgJsonPath); - - // make sure this local project exists - fs.emptyDirSync(prjDest); - - pkgJson.files.push('package.json'); - - pkgJson.files.forEach(f => { - const src = path.join(pkgSrcDir, f); - const dest = path.join(prjDest, f); - - console.log('copying:', src, 'to', dest); - fs.copySync(src, dest); - }); - - const prjReadme = path.join(prjDest, 'README.md'); - console.log('readme:', prjReadme); - - fs.writeFileSync(prjReadme, '@ionic/' + pkgName + ' copied from ' + pkgSrcDir + ', ' + new Date()); -} diff --git a/packages/angular/test/base/src/app/lazy/form/form.component.html b/packages/angular/test/base/src/app/lazy/form/form.component.html index f5891cb19ff..27b12e39b5c 100644 --- a/packages/angular/test/base/src/app/lazy/form/form.component.html +++ b/packages/angular/test/base/src/app/lazy/form/form.component.html @@ -49,14 +49,12 @@ - Min - + 
errors: {{ profileForm.controls['inputMin'].errors | json }}
 - Max - + 
errors: {{ profileForm.controls['inputMax'].errors | json }}
 diff --git a/packages/angular/test/base/src/app/lazy/modal-example/modal-example.component.html b/packages/angular/test/base/src/app/lazy/modal-example/modal-example.component.html index 4f2bd52a24e..1420dd5b804 100644 --- a/packages/angular/test/base/src/app/lazy/modal-example/modal-example.component.html +++ b/packages/angular/test/base/src/app/lazy/modal-example/modal-example.component.html @@ -25,8 +25,8 @@

{{valueFromParams}}

- Floating Label - + + Floating Label Option 0 Option 1 diff --git a/packages/angular/test/base/src/app/lazy/textarea/textarea.component.html b/packages/angular/test/base/src/app/lazy/textarea/textarea.component.html index 732e018dcb0..0316b3d54b0 100644 --- a/packages/angular/test/base/src/app/lazy/textarea/textarea.component.html +++ b/packages/angular/test/base/src/app/lazy/textarea/textarea.component.html @@ -2,8 +2,7 @@ - Textarea - + diff --git a/packages/angular/test/base/src/app/standalone/value-accessors/checkbox/checkbox.component.html b/packages/angular/test/base/src/app/standalone/value-accessors/checkbox/checkbox.component.html index 2921e06b917..c121dab37a7 100644 --- a/packages/angular/test/base/src/app/standalone/value-accessors/checkbox/checkbox.component.html +++ b/packages/angular/test/base/src/app/standalone/value-accessors/checkbox/checkbox.component.html @@ -6,6 +6,6 @@

IonCheckbox Value Accessors

- + Checkbox
diff --git a/packages/angular/test/base/src/app/standalone/value-accessors/range/range.component.html b/packages/angular/test/base/src/app/standalone/value-accessors/range/range.component.html index 9a496fbcd3c..97edf36a1e7 100644 --- a/packages/angular/test/base/src/app/standalone/value-accessors/range/range.component.html +++ b/packages/angular/test/base/src/app/standalone/value-accessors/range/range.component.html @@ -4,6 +4,6 @@

IonRange Value Accessors

This test checks the form integrations with ion-range to make sure values are correctly assigned to the form group.

- +
diff --git a/packages/angular/test/base/src/app/standalone/value-accessors/toggle/toggle.component.html b/packages/angular/test/base/src/app/standalone/value-accessors/toggle/toggle.component.html index 08888059f99..53e60bcf1e1 100644 --- a/packages/angular/test/base/src/app/standalone/value-accessors/toggle/toggle.component.html +++ b/packages/angular/test/base/src/app/standalone/value-accessors/toggle/toggle.component.html @@ -5,6 +5,6 @@

IonToggle Value Accessors

- + Toggle diff --git a/packages/react-router/CHANGELOG.md b/packages/react-router/CHANGELOG.md index ca0274ab931..45708f67d6f 100644 --- a/packages/react-router/CHANGELOG.md +++ b/packages/react-router/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [7.6.7](https://github.com/ionic-team/ionic-framework/compare/v7.6.6...v7.6.7) (2024-01-31) + +**Note:** Version bump only for package @ionic/react-router + + + + + ## [7.6.6](https://github.com/ionic-team/ionic-framework/compare/v7.6.5...v7.6.6) (2024-01-24) **Note:** Version bump only for package @ionic/react-router diff --git a/packages/react-router/package-lock.json b/packages/react-router/package-lock.json index 42dcdc99def..185e4b13c5c 100644 --- a/packages/react-router/package-lock.json +++ b/packages/react-router/package-lock.json @@ -1,15 +1,15 @@ { "name": "@ionic/react-router", - "version": "7.6.6", + "version": "7.6.7", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/react-router", - "version": "7.6.6", + "version": "7.6.7", "license": "MIT", "dependencies": { - "@ionic/react": "^7.6.6", + "@ionic/react": "^7.6.7", "tslib": "*" }, "devDependencies": { @@ -238,11 +238,11 @@ "dev": true }, "node_modules/@ionic/core": { - "version": "7.6.6", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.6.6.tgz", - "integrity": "sha512-WstnLHiR8ipW2ASdO/eqSwgMHCuVvJE3qsUNPHWkup9f08/bcbKYZpOfaWNLw/ftNqEpFbjiRuocoYYyLP0/gw==", + "version": "7.6.7", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.6.7.tgz", + "integrity": "sha512-cb5mYBVmD1u5rQJBtT7erkSpOVprb8Qu55fh/vA+PTfD7p7QQxFxn5DJBUFQTIx/E2+BqgxkvZz/p2xmB5dUfg==", "dependencies": { - "@stencil/core": "^4.10.0", + "@stencil/core": "^4.12.0", "ionicons": "^7.2.2", "tslib": "^2.1.0" } @@ -414,11 +414,11 @@ } }, "node_modules/@ionic/react": { - "version": "7.6.6", - "resolved": "https://registry.npmjs.org/@ionic/react/-/react-7.6.6.tgz", - "integrity": "sha512-3J18wUMMGBS2jkTwBRWYpkXvhFYpBcLqKF9nq/9aJL55GtFbu3uAnvM8Km3LkQUYqk4ddpGQr5bvzTvhYcxMMQ==", + "version": "7.6.7", + "resolved": "https://registry.npmjs.org/@ionic/react/-/react-7.6.7.tgz", + "integrity": "sha512-nAUc9tX0KfE5GtOcZ8UhBDnFqdYim4XBniZfGwTQL6gHDLWDeISFaOOAANkdZYwnkECOAp944AvqFN+s05LM5g==", "dependencies": { - "@ionic/core": "7.6.6", + "@ionic/core": "7.6.7", "ionicons": "^7.0.0", "tslib": "*" }, @@ -667,9 +667,9 @@ ] }, "node_modules/@stencil/core": { - "version": "4.11.0", - "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.11.0.tgz", - "integrity": "sha512-zsKhgIkTGo+s7IthitxR/MKiMS3Ck1yIypOdXr0aE6ofboKqe9NdffTcxZ0vel0wD2bZYOb6WfPMzuhRKk6+FA==", + "version": "4.12.0", + "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.12.0.tgz", + "integrity": "sha512-qAQcfNmp2sdxAh1DlyUhHfDmIUS7mhI+5LAhPphg74zK9sKgFL5vpLzgjs0wohpjlmI4msgJFYiRB8lxVPqjPg==", "bin": { "stencil": "bin/stencil" }, @@ -4050,11 +4050,11 @@ "dev": true }, "@ionic/core": { - "version": "7.6.6", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.6.6.tgz", - "integrity": "sha512-WstnLHiR8ipW2ASdO/eqSwgMHCuVvJE3qsUNPHWkup9f08/bcbKYZpOfaWNLw/ftNqEpFbjiRuocoYYyLP0/gw==", + "version": "7.6.7", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.6.7.tgz", + "integrity": "sha512-cb5mYBVmD1u5rQJBtT7erkSpOVprb8Qu55fh/vA+PTfD7p7QQxFxn5DJBUFQTIx/E2+BqgxkvZz/p2xmB5dUfg==", "requires": { - "@stencil/core": "^4.10.0", + "@stencil/core": "^4.12.0", "ionicons": "^7.2.2", "tslib": "^2.1.0" } @@ -4156,11 +4156,11 @@ "requires": {} }, "@ionic/react": { - "version": "7.6.6", - "resolved": "https://registry.npmjs.org/@ionic/react/-/react-7.6.6.tgz", - "integrity": "sha512-3J18wUMMGBS2jkTwBRWYpkXvhFYpBcLqKF9nq/9aJL55GtFbu3uAnvM8Km3LkQUYqk4ddpGQr5bvzTvhYcxMMQ==", + "version": "7.6.7", + "resolved": "https://registry.npmjs.org/@ionic/react/-/react-7.6.7.tgz", + "integrity": "sha512-nAUc9tX0KfE5GtOcZ8UhBDnFqdYim4XBniZfGwTQL6gHDLWDeISFaOOAANkdZYwnkECOAp944AvqFN+s05LM5g==", "requires": { - "@ionic/core": "7.6.6", + "@ionic/core": "7.6.7", "ionicons": "^7.0.0", "tslib": "*" } @@ -4297,9 +4297,9 @@ "optional": true }, "@stencil/core": { - "version": "4.11.0", - "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.11.0.tgz", - "integrity": "sha512-zsKhgIkTGo+s7IthitxR/MKiMS3Ck1yIypOdXr0aE6ofboKqe9NdffTcxZ0vel0wD2bZYOb6WfPMzuhRKk6+FA==" + "version": "4.12.0", + "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.12.0.tgz", + "integrity": "sha512-qAQcfNmp2sdxAh1DlyUhHfDmIUS7mhI+5LAhPphg74zK9sKgFL5vpLzgjs0wohpjlmI4msgJFYiRB8lxVPqjPg==" }, "@types/estree": { "version": "1.0.4", diff --git a/packages/react-router/package.json b/packages/react-router/package.json index 7c55257817a..e43bf909562 100644 --- a/packages/react-router/package.json +++ b/packages/react-router/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/react-router", - "version": "7.6.6", + "version": "7.6.7", "description": "React Router wrapper for @ionic/react", "keywords": [ "ionic", @@ -36,7 +36,7 @@ "dist/" ], "dependencies": { - "@ionic/react": "^7.6.6", + "@ionic/react": "^7.6.7", "tslib": "*" }, "peerDependencies": { diff --git a/packages/react-router/rollup.config.mjs b/packages/react-router/rollup.config.mjs index d9ccf1f4af3..6647b5197a3 100644 --- a/packages/react-router/rollup.config.mjs +++ b/packages/react-router/rollup.config.mjs @@ -1,4 +1,5 @@ import typescript from '@rollup/plugin-typescript'; +const external = ['react', 'react-dom', 'react-router', 'react-router-dom', 'history', 'tslib']; export default { input: 'src/index.ts', @@ -9,8 +10,8 @@ export default { sourcemap: true, } ], - external: (id) => !/^(\.|\/)/.test(id), plugins: [ typescript(), ], + external: id => external.includes(id) || id.startsWith('@ionic/core') || id.startsWith('ionicons') || id.startsWith('@ionic/react'), }; diff --git a/packages/react/CHANGELOG.md b/packages/react/CHANGELOG.md index 2f7dbe9c7bb..5a92f20507b 100644 --- a/packages/react/CHANGELOG.md +++ b/packages/react/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [7.6.7](https://github.com/ionic-team/ionic-framework/compare/v7.6.6...v7.6.7) (2024-01-31) + +**Note:** Version bump only for package @ionic/react + + + + + ## [7.6.6](https://github.com/ionic-team/ionic-framework/compare/v7.6.5...v7.6.6) (2024-01-24) **Note:** Version bump only for package @ionic/react diff --git a/packages/react/package-lock.json b/packages/react/package-lock.json index c1660aba65a..8e41cdb9663 100644 --- a/packages/react/package-lock.json +++ b/packages/react/package-lock.json @@ -1,15 +1,15 @@ { "name": "@ionic/react", - "version": "7.6.6", + "version": "7.6.7", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/react", - "version": "7.6.6", + "version": "7.6.7", "license": "MIT", "dependencies": { - "@ionic/core": "^7.6.6", + "@ionic/core": "^7.6.7", "ionicons": "^7.0.0", "tslib": "*" }, @@ -811,11 +811,11 @@ "dev": true }, "node_modules/@ionic/core": { - "version": "7.6.6", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.6.6.tgz", - "integrity": "sha512-WstnLHiR8ipW2ASdO/eqSwgMHCuVvJE3qsUNPHWkup9f08/bcbKYZpOfaWNLw/ftNqEpFbjiRuocoYYyLP0/gw==", + "version": "7.6.7", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.6.7.tgz", + "integrity": "sha512-cb5mYBVmD1u5rQJBtT7erkSpOVprb8Qu55fh/vA+PTfD7p7QQxFxn5DJBUFQTIx/E2+BqgxkvZz/p2xmB5dUfg==", "dependencies": { - "@stencil/core": "^4.10.0", + "@stencil/core": "^4.12.0", "ionicons": "^7.2.2", "tslib": "^2.1.0" } @@ -1674,9 +1674,9 @@ } }, "node_modules/@stencil/core": { - "version": "4.10.0", - "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.10.0.tgz", - "integrity": "sha512-7lDTPY1IxXN2/C+wQPHt3e/dYgY4YgelA8MxOsU3ZftXtpzWad/QNWhSAtKisJMrSjQh41jMDOgD0yLBwV6E7w==", + "version": "4.12.0", + "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.12.0.tgz", + "integrity": "sha512-qAQcfNmp2sdxAh1DlyUhHfDmIUS7mhI+5LAhPphg74zK9sKgFL5vpLzgjs0wohpjlmI4msgJFYiRB8lxVPqjPg==", "bin": { "stencil": "bin/stencil" }, @@ -12857,11 +12857,11 @@ "dev": true }, "@ionic/core": { - "version": "7.6.6", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.6.6.tgz", - "integrity": "sha512-WstnLHiR8ipW2ASdO/eqSwgMHCuVvJE3qsUNPHWkup9f08/bcbKYZpOfaWNLw/ftNqEpFbjiRuocoYYyLP0/gw==", + "version": "7.6.7", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.6.7.tgz", + "integrity": "sha512-cb5mYBVmD1u5rQJBtT7erkSpOVprb8Qu55fh/vA+PTfD7p7QQxFxn5DJBUFQTIx/E2+BqgxkvZz/p2xmB5dUfg==", "requires": { - "@stencil/core": "^4.10.0", + "@stencil/core": "^4.12.0", "ionicons": "^7.2.2", "tslib": "^2.1.0" } @@ -13453,9 +13453,9 @@ } }, "@stencil/core": { - "version": "4.10.0", - "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.10.0.tgz", - "integrity": "sha512-7lDTPY1IxXN2/C+wQPHt3e/dYgY4YgelA8MxOsU3ZftXtpzWad/QNWhSAtKisJMrSjQh41jMDOgD0yLBwV6E7w==" + "version": "4.12.0", + "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.12.0.tgz", + "integrity": "sha512-qAQcfNmp2sdxAh1DlyUhHfDmIUS7mhI+5LAhPphg74zK9sKgFL5vpLzgjs0wohpjlmI4msgJFYiRB8lxVPqjPg==" }, "@szmarczak/http-timer": { "version": "4.0.6", diff --git a/packages/react/package.json b/packages/react/package.json index 87276138cbd..aa516324e60 100644 --- a/packages/react/package.json +++ b/packages/react/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/react", - "version": "7.6.6", + "version": "7.6.7", "description": "React specific wrapper for @ionic/core", "keywords": [ "ionic", @@ -39,7 +39,7 @@ "css/" ], "dependencies": { - "@ionic/core": "^7.6.6", + "@ionic/core": "^7.6.7", "ionicons": "^7.0.0", "tslib": "*" }, diff --git a/packages/react/rollup.config.mjs b/packages/react/rollup.config.mjs index 71f731bdf23..4a5ae0f4196 100644 --- a/packages/react/rollup.config.mjs +++ b/packages/react/rollup.config.mjs @@ -1,4 +1,5 @@ import typescript from '@rollup/plugin-typescript'; +const external = ['react', 'react-dom', 'react-router', 'react-router-dom', 'history', 'tslib']; export default { input: 'src/index.ts', @@ -11,8 +12,8 @@ export default { sourcemap: true, } ], - external: (id) => !/^(\.|\/)/.test(id), plugins: [ typescript(), ], + external: id => external.includes(id) || id.startsWith('@ionic/core') || id.startsWith('ionicons'), }; diff --git a/packages/react/test/base/tests/e2e/specs/overlay-components/IonPicker.cy.ts b/packages/react/test/base/tests/e2e/specs/overlay-components/IonPicker.cy.ts index 8b8621cd4b3..d15ade0e3ef 100644 --- a/packages/react/test/base/tests/e2e/specs/overlay-components/IonPicker.cy.ts +++ b/packages/react/test/base/tests/e2e/specs/overlay-components/IonPicker.cy.ts @@ -1,9 +1,4 @@ -/** - * TODO: Skipping for now to avoid the CE build issue - * where child components do not get registered. - * Re-enable after this is resolved in Stencil 2.9. - */ -describe.skip('IonPicker', () => { +describe('IonPicker', () => { beforeEach(() => { cy.visit('/overlay-components/picker'); }); diff --git a/packages/react/test/base/tests/e2e/specs/overlay-hooks/useIonPicker.cy.ts b/packages/react/test/base/tests/e2e/specs/overlay-hooks/useIonPicker.cy.ts index 5dc59e9f557..27feedfd3c0 100644 --- a/packages/react/test/base/tests/e2e/specs/overlay-hooks/useIonPicker.cy.ts +++ b/packages/react/test/base/tests/e2e/specs/overlay-hooks/useIonPicker.cy.ts @@ -1,10 +1,4 @@ -/** - * TODO: Skipping for now to avoid the CE build issue - * where child components do not get registered. - * Re-enable after this is resolved in Stencil 2.9. - */ - -describe.skip('useIonPicker', () => { +describe('useIonPicker', () => { beforeEach(() => { cy.visit('/overlay-hooks/picker'); }); diff --git a/packages/vue-router/CHANGELOG.md b/packages/vue-router/CHANGELOG.md index 07e43400fbf..34ae6308c73 100644 --- a/packages/vue-router/CHANGELOG.md +++ b/packages/vue-router/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [7.6.7](https://github.com/ionic-team/ionic-framework/compare/v7.6.6...v7.6.7) (2024-01-31) + +**Note:** Version bump only for package @ionic/vue-router + + + + + ## [7.6.6](https://github.com/ionic-team/ionic-framework/compare/v7.6.5...v7.6.6) (2024-01-24) **Note:** Version bump only for package @ionic/vue-router diff --git a/packages/vue-router/package-lock.json b/packages/vue-router/package-lock.json index 1f4e7fbaf29..475dabde115 100644 --- a/packages/vue-router/package-lock.json +++ b/packages/vue-router/package-lock.json @@ -1,15 +1,15 @@ { "name": "@ionic/vue-router", - "version": "7.6.6", + "version": "7.6.7", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/vue-router", - "version": "7.6.6", + "version": "7.6.7", "license": "MIT", "dependencies": { - "@ionic/vue": "^7.6.6" + "@ionic/vue": "^7.6.7" }, "devDependencies": { "@ionic/eslint-config": "^0.3.0", @@ -661,11 +661,11 @@ "dev": true }, "node_modules/@ionic/core": { - "version": "7.6.6", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.6.6.tgz", - "integrity": "sha512-WstnLHiR8ipW2ASdO/eqSwgMHCuVvJE3qsUNPHWkup9f08/bcbKYZpOfaWNLw/ftNqEpFbjiRuocoYYyLP0/gw==", + "version": "7.6.7", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.6.7.tgz", + "integrity": "sha512-cb5mYBVmD1u5rQJBtT7erkSpOVprb8Qu55fh/vA+PTfD7p7QQxFxn5DJBUFQTIx/E2+BqgxkvZz/p2xmB5dUfg==", "dependencies": { - "@stencil/core": "^4.10.0", + "@stencil/core": "^4.12.0", "ionicons": "^7.2.2", "tslib": "^2.1.0" } @@ -852,11 +852,11 @@ } }, "node_modules/@ionic/vue": { - "version": "7.6.6", - "resolved": "https://registry.npmjs.org/@ionic/vue/-/vue-7.6.6.tgz", - "integrity": "sha512-Ct992mndUmyTKq2vBFX/3gFcyNW/QKScYydAvG0Jtl9fPHrMZ7fYj+Hk1OEuLQDbsBMH3gUXjUV0OV5pYABsEA==", + "version": "7.6.7", + "resolved": "https://registry.npmjs.org/@ionic/vue/-/vue-7.6.7.tgz", + "integrity": "sha512-YsKkfn8aqUDuXJauqTjAPaem1ZM9e2dblatheLDHo5yGfYcnK2hO35D95V03v0Q+xiDKGcKJKhk+19wKAXmQ6A==", "dependencies": { - "@ionic/core": "7.6.6", + "@ionic/core": "7.6.7", "ionicons": "^7.0.0" } }, @@ -1508,9 +1508,9 @@ } }, "node_modules/@stencil/core": { - "version": "4.11.0", - "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.11.0.tgz", - "integrity": "sha512-zsKhgIkTGo+s7IthitxR/MKiMS3Ck1yIypOdXr0aE6ofboKqe9NdffTcxZ0vel0wD2bZYOb6WfPMzuhRKk6+FA==", + "version": "4.12.0", + "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.12.0.tgz", + "integrity": "sha512-qAQcfNmp2sdxAh1DlyUhHfDmIUS7mhI+5LAhPphg74zK9sKgFL5vpLzgjs0wohpjlmI4msgJFYiRB8lxVPqjPg==", "bin": { "stencil": "bin/stencil" }, @@ -7878,11 +7878,11 @@ "dev": true }, "@ionic/core": { - "version": "7.6.6", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.6.6.tgz", - "integrity": "sha512-WstnLHiR8ipW2ASdO/eqSwgMHCuVvJE3qsUNPHWkup9f08/bcbKYZpOfaWNLw/ftNqEpFbjiRuocoYYyLP0/gw==", + "version": "7.6.7", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.6.7.tgz", + "integrity": "sha512-cb5mYBVmD1u5rQJBtT7erkSpOVprb8Qu55fh/vA+PTfD7p7QQxFxn5DJBUFQTIx/E2+BqgxkvZz/p2xmB5dUfg==", "requires": { - "@stencil/core": "^4.10.0", + "@stencil/core": "^4.12.0", "ionicons": "^7.2.2", "tslib": "^2.1.0" } @@ -7993,11 +7993,11 @@ "requires": {} }, "@ionic/vue": { - "version": "7.6.6", - "resolved": "https://registry.npmjs.org/@ionic/vue/-/vue-7.6.6.tgz", - "integrity": "sha512-Ct992mndUmyTKq2vBFX/3gFcyNW/QKScYydAvG0Jtl9fPHrMZ7fYj+Hk1OEuLQDbsBMH3gUXjUV0OV5pYABsEA==", + "version": "7.6.7", + "resolved": "https://registry.npmjs.org/@ionic/vue/-/vue-7.6.7.tgz", + "integrity": "sha512-YsKkfn8aqUDuXJauqTjAPaem1ZM9e2dblatheLDHo5yGfYcnK2hO35D95V03v0Q+xiDKGcKJKhk+19wKAXmQ6A==", "requires": { - "@ionic/core": "7.6.6", + "@ionic/core": "7.6.7", "ionicons": "^7.0.0" } }, @@ -8461,9 +8461,9 @@ } }, "@stencil/core": { - "version": "4.11.0", - "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.11.0.tgz", - "integrity": "sha512-zsKhgIkTGo+s7IthitxR/MKiMS3Ck1yIypOdXr0aE6ofboKqe9NdffTcxZ0vel0wD2bZYOb6WfPMzuhRKk6+FA==" + "version": "4.12.0", + "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.12.0.tgz", + "integrity": "sha512-qAQcfNmp2sdxAh1DlyUhHfDmIUS7mhI+5LAhPphg74zK9sKgFL5vpLzgjs0wohpjlmI4msgJFYiRB8lxVPqjPg==" }, "@tootallnate/once": { "version": "2.0.0", diff --git a/packages/vue-router/package.json b/packages/vue-router/package.json index 1b6409fa65e..f80f3a92156 100644 --- a/packages/vue-router/package.json +++ b/packages/vue-router/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/vue-router", - "version": "7.6.6", + "version": "7.6.7", "description": "Vue Router integration for @ionic/vue", "scripts": { "test.spec": "jest", @@ -44,7 +44,7 @@ }, "homepage": "https://github.com/ionic-team/ionic#readme", "dependencies": { - "@ionic/vue": "^7.6.6" + "@ionic/vue": "^7.6.7" }, "devDependencies": { "@ionic/eslint-config": "^0.3.0", diff --git a/packages/vue/CHANGELOG.md b/packages/vue/CHANGELOG.md index 85949b91f11..7d8ad5c08ba 100644 --- a/packages/vue/CHANGELOG.md +++ b/packages/vue/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [7.6.7](https://github.com/ionic-team/ionic-framework/compare/v7.6.6...v7.6.7) (2024-01-31) + +**Note:** Version bump only for package @ionic/vue + + + + + ## [7.6.6](https://github.com/ionic-team/ionic-framework/compare/v7.6.5...v7.6.6) (2024-01-24) diff --git a/packages/vue/package-lock.json b/packages/vue/package-lock.json index ddb6e6476bb..16940fea247 100644 --- a/packages/vue/package-lock.json +++ b/packages/vue/package-lock.json @@ -1,15 +1,15 @@ { "name": "@ionic/vue", - "version": "7.6.6", + "version": "7.6.7", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/vue", - "version": "7.6.6", + "version": "7.6.7", "license": "MIT", "dependencies": { - "@ionic/core": "^7.6.6", + "@ionic/core": "^7.6.7", "ionicons": "^7.0.0" }, "devDependencies": { @@ -208,11 +208,11 @@ "dev": true }, "node_modules/@ionic/core": { - "version": "7.6.6", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.6.6.tgz", - "integrity": "sha512-WstnLHiR8ipW2ASdO/eqSwgMHCuVvJE3qsUNPHWkup9f08/bcbKYZpOfaWNLw/ftNqEpFbjiRuocoYYyLP0/gw==", + "version": "7.6.7", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.6.7.tgz", + "integrity": "sha512-cb5mYBVmD1u5rQJBtT7erkSpOVprb8Qu55fh/vA+PTfD7p7QQxFxn5DJBUFQTIx/E2+BqgxkvZz/p2xmB5dUfg==", "dependencies": { - "@stencil/core": "^4.10.0", + "@stencil/core": "^4.12.0", "ionicons": "^7.2.2", "tslib": "^2.1.0" } @@ -628,9 +628,9 @@ ] }, "node_modules/@stencil/core": { - "version": "4.10.0", - "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.10.0.tgz", - "integrity": "sha512-7lDTPY1IxXN2/C+wQPHt3e/dYgY4YgelA8MxOsU3ZftXtpzWad/QNWhSAtKisJMrSjQh41jMDOgD0yLBwV6E7w==", + "version": "4.12.0", + "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.12.0.tgz", + "integrity": "sha512-qAQcfNmp2sdxAh1DlyUhHfDmIUS7mhI+5LAhPphg74zK9sKgFL5vpLzgjs0wohpjlmI4msgJFYiRB8lxVPqjPg==", "bin": { "stencil": "bin/stencil" }, @@ -3959,11 +3959,11 @@ "dev": true }, "@ionic/core": { - "version": "7.6.6", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.6.6.tgz", - "integrity": "sha512-WstnLHiR8ipW2ASdO/eqSwgMHCuVvJE3qsUNPHWkup9f08/bcbKYZpOfaWNLw/ftNqEpFbjiRuocoYYyLP0/gw==", + "version": "7.6.7", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.6.7.tgz", + "integrity": "sha512-cb5mYBVmD1u5rQJBtT7erkSpOVprb8Qu55fh/vA+PTfD7p7QQxFxn5DJBUFQTIx/E2+BqgxkvZz/p2xmB5dUfg==", "requires": { - "@stencil/core": "^4.10.0", + "@stencil/core": "^4.12.0", "ionicons": "^7.2.2", "tslib": "^2.1.0" }, @@ -4203,9 +4203,9 @@ "optional": true }, "@stencil/core": { - "version": "4.10.0", - "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.10.0.tgz", - "integrity": "sha512-7lDTPY1IxXN2/C+wQPHt3e/dYgY4YgelA8MxOsU3ZftXtpzWad/QNWhSAtKisJMrSjQh41jMDOgD0yLBwV6E7w==" + "version": "4.12.0", + "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.12.0.tgz", + "integrity": "sha512-qAQcfNmp2sdxAh1DlyUhHfDmIUS7mhI+5LAhPphg74zK9sKgFL5vpLzgjs0wohpjlmI4msgJFYiRB8lxVPqjPg==" }, "@types/estree": { "version": "1.0.4", diff --git a/packages/vue/package.json b/packages/vue/package.json index 37da88be765..4deb400ebce 100644 --- a/packages/vue/package.json +++ b/packages/vue/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/vue", - "version": "7.6.6", + "version": "7.6.7", "description": "Vue specific wrapper for @ionic/core", "scripts": { "eslint": "eslint src", @@ -66,7 +66,7 @@ "vue-router": "^4.0.16" }, "dependencies": { - "@ionic/core": "^7.6.6", + "@ionic/core": "^7.6.7", "ionicons": "^7.0.0" }, "vetur": { diff --git a/packages/vue/test/base/src/components/ModalContent.vue b/packages/vue/test/base/src/components/ModalContent.vue index 48586c826bc..6b425e7cd78 100644 --- a/packages/vue/test/base/src/components/ModalContent.vue +++ b/packages/vue/test/base/src/components/ModalContent.vue @@ -10,7 +10,7 @@ {{ title }} - + diff --git a/packages/vue/test/base/src/views/Inputs.vue b/packages/vue/test/base/src/views/Inputs.vue index 70ec41094e9..2cf45a98d09 100644 --- a/packages/vue/test/base/src/views/Inputs.vue +++ b/packages/vue/test/base/src/views/Inputs.vue @@ -30,28 +30,23 @@ - Checkbox - + Checkbox - Toggle - + Toggle - Input - + - Range - + - Textarea - + @@ -61,22 +56,18 @@ - Red - + Red - Green - + Green - Blue - + Blue - Select - + Apples Bananas diff --git a/packages/vue/test/base/src/views/Overlays.vue b/packages/vue/test/base/src/views/Overlays.vue index ccf794d362b..799a44672b5 100644 --- a/packages/vue/test/base/src/views/Overlays.vue +++ b/packages/vue/test/base/src/views/Overlays.vue @@ -18,28 +18,22 @@ - Alert - + Alert - Action Sheet - + Action Sheet - Loading - + Loading - Modal - + Modal - Popover - + Popover - Toast - + Toast @@ -51,12 +45,10 @@ - Controller - + Controller - Component - + Component diff --git a/packages/vue/test/base/src/views/Select.vue b/packages/vue/test/base/src/views/Select.vue index 0f48fcc612b..bb4d9b31f39 100644 --- a/packages/vue/test/base/src/views/Select.vue +++ b/packages/vue/test/base/src/views/Select.vue @@ -7,8 +7,8 @@ - Select Popover