From bef4b38156d1509663e2d6b5485134a9be467e72 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Fri, 2 Feb 2024 11:57:01 -0500 Subject: [PATCH 1/2] fix(select): popover can be scrolled --- .../src/components/select-popover/select-popover.scss | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/core/src/components/select-popover/select-popover.scss b/core/src/components/select-popover/select-popover.scss index 3fba7de13ce..4135db2e49f 100644 --- a/core/src/components/select-popover/select-popover.scss +++ b/core/src/components/select-popover/select-popover.scss @@ -8,3 +8,14 @@ ion-list-header, ion-label { @include margin(0); } + + +/** + * The main content inside of a popover has overflow: hidden + * so that scrolling scroll a descendant ion-content. + * However, select-popover does not use ion-content so we need + * to explicitly make this container scrollable. + */ +:host { + overflow-y: auto; +} From e4fc6e530a1e4b198ef5855efb2e36d983c3c249 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Fri, 2 Feb 2024 12:07:37 -0500 Subject: [PATCH 2/2] Update select-popover.scss --- core/src/components/select-popover/select-popover.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/components/select-popover/select-popover.scss b/core/src/components/select-popover/select-popover.scss index 4135db2e49f..c22aa273211 100644 --- a/core/src/components/select-popover/select-popover.scss +++ b/core/src/components/select-popover/select-popover.scss @@ -12,7 +12,7 @@ ion-label { /** * The main content inside of a popover has overflow: hidden - * so that scrolling scroll a descendant ion-content. + * so that a descendant ion-content can be scrolled. * However, select-popover does not use ion-content so we need * to explicitly make this container scrollable. */