From d5dc901bb98253ca37efb94ddd00bcab9a56fcd8 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 31 Jan 2024 09:44:42 -0500 Subject: [PATCH 01/11] chore(deps-dev): Bump @capacitor/haptics from 5.0.6 to 5.0.7 in /core (#28932) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bumps [@capacitor/haptics](https://github.com/ionic-team/capacitor-plugins) from 5.0.6 to 5.0.7.
Release notes

Sourced from @​capacitor/haptics's releases.

@​capacitor/haptics@​5.0.7

5.0.7 (2024-01-29)

Note: Version bump only for package @​capacitor/haptics

Commits

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@capacitor/haptics&package-manager=npm_and_yarn&previous-version=5.0.6&new-version=5.0.7)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) ---
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- core/package-lock.json | 14 +++++++------- core/package.json | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/core/package-lock.json b/core/package-lock.json index bbc1c89a111..0c47aac1011 100644 --- a/core/package-lock.json +++ b/core/package-lock.json @@ -16,7 +16,7 @@ "devDependencies": { "@axe-core/playwright": "^4.8.4", "@capacitor/core": "^5.6.0", - "@capacitor/haptics": "^5.0.6", + "@capacitor/haptics": "^5.0.7", "@capacitor/keyboard": "^5.0.8", "@capacitor/status-bar": "^5.0.7", "@ionic/eslint-config": "^0.3.0", @@ -643,9 +643,9 @@ } }, "node_modules/@capacitor/haptics": { - "version": "5.0.6", - "resolved": "https://registry.npmjs.org/@capacitor/haptics/-/haptics-5.0.6.tgz", - "integrity": "sha512-UrMcR7p2X10ql4VLlowUuH/VckTeu0lj+RQpekxox14uxDmu5AGIFDK/iDTi8W6QZkxTJRZK6sbCjgwYgNJ7Pw==", + "version": "5.0.7", + "resolved": "https://registry.npmjs.org/@capacitor/haptics/-/haptics-5.0.7.tgz", + "integrity": "sha512-/j+7Qa4BxQA5aOU43cwXuiudfSXfoHFsAVfcehH5DkSjxLykZKWHEuE4uFJXqdkSIbAHjS37D0Sde6ENP6G/MA==", "dev": true, "peerDependencies": { "@capacitor/core": "^5.0.0" @@ -11333,9 +11333,9 @@ } }, "@capacitor/haptics": { - "version": "5.0.6", - "resolved": "https://registry.npmjs.org/@capacitor/haptics/-/haptics-5.0.6.tgz", - "integrity": "sha512-UrMcR7p2X10ql4VLlowUuH/VckTeu0lj+RQpekxox14uxDmu5AGIFDK/iDTi8W6QZkxTJRZK6sbCjgwYgNJ7Pw==", + "version": "5.0.7", + "resolved": "https://registry.npmjs.org/@capacitor/haptics/-/haptics-5.0.7.tgz", + "integrity": "sha512-/j+7Qa4BxQA5aOU43cwXuiudfSXfoHFsAVfcehH5DkSjxLykZKWHEuE4uFJXqdkSIbAHjS37D0Sde6ENP6G/MA==", "dev": true, "requires": {} }, diff --git a/core/package.json b/core/package.json index eb3d5d4aa45..b1e8be54c38 100644 --- a/core/package.json +++ b/core/package.json @@ -38,7 +38,7 @@ "devDependencies": { "@axe-core/playwright": "^4.8.4", "@capacitor/core": "^5.6.0", - "@capacitor/haptics": "^5.0.6", + "@capacitor/haptics": "^5.0.7", "@capacitor/keyboard": "^5.0.8", "@capacitor/status-bar": "^5.0.7", "@ionic/eslint-config": "^0.3.0", From 950fa40c5597c81d5cbaeb9276b09adfea5e79fb Mon Sep 17 00:00:00 2001 From: Shawn Taylor Date: Wed, 31 Jan 2024 10:14:57 -0500 Subject: [PATCH 02/11] fix(overlays): tear down animations after dismiss (#28907) Issue number: resolves #28352 --------- ## What is the current behavior? Not all animations are getting properly destroyed after they run. This means that styles can get stuck at the end value of their animation. Specifically for this reproduction (as reported in the bug ticket), if the modal animates from 1 to 0 opacity and then the modal gets reopened with a different animation where the opacity should be 1 throughout (i.e. the opacity isn't supposed to animate at all), the modal is invisible because the opacity got stuck at 0 and never got reset to the default value of 1. This bug is probably causing some incorrect behavior on other edge cases with overlays, but this is the only one I've identified. ### Reproduction steps Note: you cannot reproduce this when using a modalController 1. Open a modal, e.g. [this one](http://localhost:3333/src/components/modal/test/card-nav?ionic:mode=ios) in `ios` mode on a screen wider than 768px 1. Close the modal 1. Open the same modal on a screen narrower than 768px 1. See that the modal does not appear ## What is the new behavior? - Animations are properly destroyed after the animation completes - The modal now appears as expected after following the reproduction steps above ## Does this introduce a breaking change? - [ ] Yes - [x] No --------- Co-authored-by: Liam DeBeasi --- core/src/components/modal/modal.tsx | 5 --- .../modal/test/animations/modal.e2e.ts | 45 +++++++++++++++++++ core/src/utils/overlays.ts | 6 +++ 3 files changed, 51 insertions(+), 5 deletions(-) create mode 100644 core/src/components/modal/test/animations/modal.e2e.ts diff --git a/core/src/components/modal/modal.tsx b/core/src/components/modal/modal.tsx index bae8648d765..d32e092b195 100644 --- a/core/src/components/modal/modal.tsx +++ b/core/src/components/modal/modal.tsx @@ -10,7 +10,6 @@ import { Style as StatusBarStyle, StatusBar } from '@utils/native/status-bar'; import { GESTURE, BACKDROP, - activeAnimations, dismiss, eventMethod, prepareOverlay, @@ -705,8 +704,6 @@ export class Modal implements ComponentInterface, OverlayInterface { this.keyboardOpenCallback = undefined; } - const enteringAnimation = activeAnimations.get(this) || []; - const dismissed = await dismiss( this, data, @@ -733,8 +730,6 @@ export class Modal implements ComponentInterface, OverlayInterface { if (this.gesture) { this.gesture.destroy(); } - - enteringAnimation.forEach((ani) => ani.destroy()); } this.currentBreakpoint = undefined; this.animation = undefined; diff --git a/core/src/components/modal/test/animations/modal.e2e.ts b/core/src/components/modal/test/animations/modal.e2e.ts new file mode 100644 index 00000000000..8d541003ff8 --- /dev/null +++ b/core/src/components/modal/test/animations/modal.e2e.ts @@ -0,0 +1,45 @@ +import { expect } from '@playwright/test'; +import { configs, test } from '@utils/test/playwright'; + +configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ config, title }) => { + test.describe(title('modal: animations'), () => { + test.beforeEach(async ({ page }) => { + await page.setContent( + ` + + `, + config + ); + }); + test('card modal should clean up animations on dismiss', async ({ page }, testInfo) => { + testInfo.annotations.push({ + type: 'issue', + description: 'https://github.com/ionic-team/ionic-framework/issues/28352', + }); + + const ionModalDidDismiss = await page.spyOnEvent('ionModalDidDismiss'); + + const modal = page.locator('ion-modal'); + + const initialAnimations = await modal.evaluate((el: HTMLIonModalElement) => { + return el.shadowRoot!.getAnimations(); + }); + + // While the modal is open, it should have animations + expect(initialAnimations.length).toBeGreaterThan(0); + + await modal.evaluate((el: HTMLIonModalElement) => { + el.dismiss(); + }); + + await ionModalDidDismiss.next(); + + const currentAnimations = await modal.evaluate((el: HTMLIonModalElement) => { + return el.shadowRoot!.getAnimations(); + }); + + // Once the modal has finished closing, there should be no animations + expect(currentAnimations.length).toBe(0); + }); + }); +}); diff --git a/core/src/utils/overlays.ts b/core/src/utils/overlays.ts index bd56ac36844..bead295cd0b 100644 --- a/core/src/utils/overlays.ts +++ b/core/src/utils/overlays.ts @@ -577,6 +577,12 @@ export const dismiss = async ( overlay.didDismiss.emit({ data, role }); overlay.didDismissShorthand?.emit({ data, role }); + // Get a reference to all animations currently assigned to this overlay + // Then tear them down to return the overlay to its initial visual state + const animations = activeAnimations.get(overlay) || []; + + animations.forEach((ani) => ani.destroy()); + activeAnimations.delete(overlay); /** From 2150188d27837c4c78e1d8333b55ab119ed1721c Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 31 Jan 2024 08:32:42 -0800 Subject: [PATCH 03/11] chore(deps-dev): Bump @stencil/angular-output-target from 0.8.3 to 0.8.4 in /core (#28896) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bumps [@stencil/angular-output-target](https://github.com/ionic-team/stencil-ds-output-targets) from 0.8.3 to 0.8.4.
Release notes

Sourced from @​stencil/angular-output-target's releases.

@​stencil/angular-output-target@​0.8.4

What's Changed

Full Changelog: https://github.com/ionic-team/stencil-ds-output-targets/compare/@​stencil/angular-output-target@​0.8.2...@​stencil/angular-output-target@​0.8.4

Commits

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@stencil/angular-output-target&package-manager=npm_and_yarn&previous-version=0.8.3&new-version=0.8.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) ---
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- core/package-lock.json | 14 +++++++------- core/package.json | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/core/package-lock.json b/core/package-lock.json index 49a9bedc737..1d3558d5da1 100644 --- a/core/package-lock.json +++ b/core/package-lock.json @@ -24,7 +24,7 @@ "@playwright/test": "^1.39.0", "@rollup/plugin-node-resolve": "^8.4.0", "@rollup/plugin-virtual": "^2.0.3", - "@stencil/angular-output-target": "^0.8.3", + "@stencil/angular-output-target": "^0.8.4", "@stencil/react-output-target": "^0.5.3", "@stencil/sass": "^3.0.9", "@stencil/vue-output-target": "^0.8.7", @@ -1816,9 +1816,9 @@ } }, "node_modules/@stencil/angular-output-target": { - "version": "0.8.3", - "resolved": "https://registry.npmjs.org/@stencil/angular-output-target/-/angular-output-target-0.8.3.tgz", - "integrity": "sha512-I/QO1sEx09WWUaNlA30EBhlXYftOSfSBTwYBwC65qlpHDIlD5WU3EAtKhU5IphfwhxnD63kvOoU1YvTUXFHNng==", + "version": "0.8.4", + "resolved": "https://registry.npmjs.org/@stencil/angular-output-target/-/angular-output-target-0.8.4.tgz", + "integrity": "sha512-QvmHTueXXs5vB9W2L12uEzFmAuR8sqATJV2b+SCFmYsjJSaymiSqR3dKo2wnr0tZiTgU1t16BWaUKiSh3wPXpw==", "dev": true, "peerDependencies": { "@stencil/core": ">=2.0.0 || >=3 || >= 4.0.0-beta.0 || >= 4.0.0" @@ -12177,9 +12177,9 @@ } }, "@stencil/angular-output-target": { - "version": "0.8.3", - "resolved": "https://registry.npmjs.org/@stencil/angular-output-target/-/angular-output-target-0.8.3.tgz", - "integrity": "sha512-I/QO1sEx09WWUaNlA30EBhlXYftOSfSBTwYBwC65qlpHDIlD5WU3EAtKhU5IphfwhxnD63kvOoU1YvTUXFHNng==", + "version": "0.8.4", + "resolved": "https://registry.npmjs.org/@stencil/angular-output-target/-/angular-output-target-0.8.4.tgz", + "integrity": "sha512-QvmHTueXXs5vB9W2L12uEzFmAuR8sqATJV2b+SCFmYsjJSaymiSqR3dKo2wnr0tZiTgU1t16BWaUKiSh3wPXpw==", "dev": true, "requires": {} }, diff --git a/core/package.json b/core/package.json index e0fff5f6715..587f6546f5e 100644 --- a/core/package.json +++ b/core/package.json @@ -46,7 +46,7 @@ "@playwright/test": "^1.39.0", "@rollup/plugin-node-resolve": "^8.4.0", "@rollup/plugin-virtual": "^2.0.3", - "@stencil/angular-output-target": "^0.8.3", + "@stencil/angular-output-target": "^0.8.4", "@stencil/react-output-target": "^0.5.3", "@stencil/sass": "^3.0.9", "@stencil/vue-output-target": "^0.8.7", From e62ec509a3ae3db624baacd5e65078691497621a Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Wed, 31 Jan 2024 14:11:23 -0500 Subject: [PATCH 04/11] chore(ci): remove ng12-15 apps, add ng16-17 for stencil nightlies (#28945) Issue number: Internal --------- ## What is the current behavior? The Stencil nightlies are still attempting to run old Angular test apps and does not test ng16/17 ## What is the new behavior? - Removed ng12-15 test apps - Added ng16-17 test apps I opted to remove ng14-15 because we are in the process of dropping support for it in Ionic 8. ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information --- .github/workflows/stencil-nightly.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/stencil-nightly.yml b/.github/workflows/stencil-nightly.yml index c5db4e1bb3d..01ab63bb5e5 100644 --- a/.github/workflows/stencil-nightly.yml +++ b/.github/workflows/stencil-nightly.yml @@ -150,7 +150,7 @@ jobs: strategy: fail-fast: false matrix: - apps: [ng12, ng13, ng14, ng15] + apps: [ng16, ng17] needs: [build-angular, build-angular-server] runs-on: ubuntu-latest steps: From 7f3273f0b2a6e1d703e675f4b166d04ad64d2959 Mon Sep 17 00:00:00 2001 From: Shawn Taylor Date: Thu, 1 Feb 2024 10:49:30 -0500 Subject: [PATCH 05/11] docs(angular test app): include instructions for updating nightly build (#28948) Issue number: None --------- ## What is the current behavior? People adding a new Angular test app don't know they need to update the Stencil nightly build. ## What is the new behavior? - Documentation exists for adding a new Angular version to the Stencil nightly build when creating a new Angular test app.. ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information This is related to #28945 --------- Co-authored-by: Maria Hutt --- packages/angular/test/README.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/angular/test/README.md b/packages/angular/test/README.md index e5efdb1a0db..b2e56ef2ee4 100644 --- a/packages/angular/test/README.md +++ b/packages/angular/test/README.md @@ -113,4 +113,6 @@ Note: You may encounter some other peer dependency issues not covered by the Ang 7. Open `./github/workflows/build.yml` and find the `test-angular-e2e` job. 8. Find the `apps` field under `matrix`. 9. Add "ng14" to the `apps` field. -10. Commit these changes and push. +10. Open `./github/workflows/stencil-nightly.yml` and find the `test-angular-e2e` job. +11. Repeat steps 8 and 9. +12. Commit these changes and push. From 51c729eafc3b290a5daddf7f0ccffd0a2a9fe2aa Mon Sep 17 00:00:00 2001 From: Maria Hutt Date: Thu, 1 Feb 2024 09:04:58 -0800 Subject: [PATCH 06/11] refactor(angular, react, vue): add missing test app msg (#28951) Issue number: N/A --------- ## What is the current behavior? The packages, Angular, React, and Vue, will accept any `app_dir` parameter when passing it to the build script. This can lead to a user to entering a directory that doesn't exist within `test/apps`. If this happens, then the build folder will include an incomplete test app. For example: 1. `./build ng13` 2. This creates a `build/ng13` folder, but the folder only contains the contents from the `base` folder. This causes it to be incomplete. ## What is the new behavior? - Provides a message that the provided app directory doesn't exist. - Does not create the incomplete app when an invalid app directory is given. ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information N/A --- packages/angular/test/build.sh | 6 ++++++ packages/react/test/build.sh | 6 ++++++ packages/vue/test/build.sh | 6 ++++++ 3 files changed, 18 insertions(+) diff --git a/packages/angular/test/build.sh b/packages/angular/test/build.sh index d91b9cb1771..f597a55f9e6 100755 --- a/packages/angular/test/build.sh +++ b/packages/angular/test/build.sh @@ -22,6 +22,12 @@ FULL_BASE_DIR="${BASE_DIR}/." # The full path to the built application. BUILD_APP_DIR="${BUILD_DIR}/${APP_DIR}/" +# Make sure the full app directory exists. +if [ ! -d $FULL_APP_DIR ]; then + echo "Could not find test app: ${FULL_APP_DIR}" + exit 1 +fi + # Make the build directory if it does not already exist. mkdir -p $BUILD_DIR diff --git a/packages/react/test/build.sh b/packages/react/test/build.sh index a646dc74ba8..51467aee36b 100755 --- a/packages/react/test/build.sh +++ b/packages/react/test/build.sh @@ -22,6 +22,12 @@ FULL_BASE_DIR="${BASE_DIR}/." # The full path to the built application. BUILD_APP_DIR="${BUILD_DIR}/${APP_DIR}/" +# Make sure the full app directory exists. +if [ ! -d $FULL_APP_DIR ]; then + echo "Could not find test app: ${FULL_APP_DIR}" + exit 1 +fi + # Make the build directory if it does not already exist. mkdir -p $BUILD_DIR diff --git a/packages/vue/test/build.sh b/packages/vue/test/build.sh index a646dc74ba8..51467aee36b 100755 --- a/packages/vue/test/build.sh +++ b/packages/vue/test/build.sh @@ -22,6 +22,12 @@ FULL_BASE_DIR="${BASE_DIR}/." # The full path to the built application. BUILD_APP_DIR="${BUILD_DIR}/${APP_DIR}/" +# Make sure the full app directory exists. +if [ ! -d $FULL_APP_DIR ]; then + echo "Could not find test app: ${FULL_APP_DIR}" + exit 1 +fi + # Make the build directory if it does not already exist. mkdir -p $BUILD_DIR From 35ab6b4816bd627239de8d8b25ce0c86db8c74b4 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Mon, 5 Feb 2024 14:43:22 -0500 Subject: [PATCH 07/11] fix(select): popover can be scrolled (#28965) Issue number: resolves #28963 --------- ## What is the current behavior? In https://github.com/ionic-team/ionic-framework/pull/28861 I fixed an issue that caused the wrong content inside of a popover to be scrollable. This CSS should have been applied, but it broke back when popover was converted to the Shadow DOM. Fixing this issue revealed a misconfiguration with the select-popover that caused the select-popover to no longer be scrollable. ## What is the new behavior? - Content inside of `ion-select-popover` can now be scrolled Note that I am considering this a bug fix instead of a regression. While scrolling used to work in select-popover, it only worked by chance. The `.popover-viewport` styles should have always applied to the select-popover, thus requiring the use of `overflow-y: auto` in select-popover. ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information Dev build: `7.7.1-dev.11706893059.1bef4b38` --- .../src/components/select-popover/select-popover.scss | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/core/src/components/select-popover/select-popover.scss b/core/src/components/select-popover/select-popover.scss index 3fba7de13ce..c22aa273211 100644 --- a/core/src/components/select-popover/select-popover.scss +++ b/core/src/components/select-popover/select-popover.scss @@ -8,3 +8,14 @@ ion-list-header, ion-label { @include margin(0); } + + +/** + * The main content inside of a popover has overflow: hidden + * so that a descendant ion-content can be scrolled. + * However, select-popover does not use ion-content so we need + * to explicitly make this container scrollable. + */ +:host { + overflow-y: auto; +} From 5777ce258119d2715b1326cdc103bd4ad7612bd1 Mon Sep 17 00:00:00 2001 From: Sean Perkins <13732623+sean-perkins@users.noreply.github.com> Date: Tue, 6 Feb 2024 18:20:57 -0500 Subject: [PATCH 08/11] fix(react): route with redirect will mount page (#28961) Issue number: resolves #28838 --------- ## What is the current behavior? In #28316 we resolved a longstanding misconfiguration where event listeners being added to the page were not removed. This was due to incorrect usage of `.bind` creating a new instance of the callback functions. By removing the event listener for `ionViewDidLeave`, before the component has actually unmounted in react, resulted in the registered destroy callback to not fire: https://github.com/ionic-team/ionic-framework/blob/51c729eafc3b290a5daddf7f0ccffd0a2a9fe2aa/packages/react/src/contexts/IonLifeCycleContext.tsx#L208-L216 and https://github.com/ionic-team/ionic-framework/blob/51c729eafc3b290a5daddf7f0ccffd0a2a9fe2aa/packages/react/src/routing/ViewLifeCycleManager.tsx#L21-L32 This resulted in a scenario that using a `Redirect` could cause the wrong view to be unmounted (the entering view) and leave the user on an empty screen. ## What is the new behavior? - `ionViewDidEnter` event listener *is not* removed while the component is unmounting. The browser will naturally remove the event listener when the element node is detached from the DOM. - Users are no longer presented with a white screen after clicking a route that uses a redirect. ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information Dev-build: `7.6.7-dev.11706567011.11e782a9` --- packages/react/src/routing/PageManager.tsx | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/react/src/routing/PageManager.tsx b/packages/react/src/routing/PageManager.tsx index 1ba3f94b98f..19a184a6364 100644 --- a/packages/react/src/routing/PageManager.tsx +++ b/packages/react/src/routing/PageManager.tsx @@ -54,7 +54,13 @@ export class PageManager extends React.PureComponent { this.ionPageElementRef.current.removeEventListener('ionViewWillEnter', this.ionViewWillEnterHandler); this.ionPageElementRef.current.removeEventListener('ionViewDidEnter', this.ionViewDidEnterHandler); this.ionPageElementRef.current.removeEventListener('ionViewWillLeave', this.ionViewWillLeaveHandler); - this.ionPageElementRef.current.removeEventListener('ionViewDidLeave', this.ionViewDidLeaveHandler); + /** + * We deliberately do not remove the `ionViewDidLeave` listener. + * The registered callback is used to unmount and remove the page. + * Removing the event listener prevents the callback from being called. + * The browser will automatically remove the event listener when the + * page element is removed from the DOM and garbage collected. + */ } } From 7449fb4fed4048f5d01ba068dc6f8e2d7727e95d Mon Sep 17 00:00:00 2001 From: Sean Perkins <13732623+sean-perkins@users.noreply.github.com> Date: Tue, 6 Feb 2024 18:33:14 -0500 Subject: [PATCH 09/11] fix(action-sheet): iOS dismiss animation respects safe area (#28915) Issue number: resolves #28541 --------- ## What is the current behavior? On iOS when dismissing the `ion-action-sheet`, the animation does not account for the safe area of the device. This results in the action sheet not completely animating off the visible viewport on a device with safe area enabled. ## What is the new behavior? - The `ion-action-sheet` will animate consistently off the viewport when dismissing, including the safe area. To better support custom animations not needing to account for the safe area, the safe area has been added to the padding of the action sheet container. This results in the height increasing based on the bottom safe area and animating correctly when translating between [`100%` and `0%`](https://github.com/ionic-team/ionic-framework/blob/9d57758e3ec1095c6eb951d2640b95084b711bbc/core/src/components/action-sheet/animations/ios.enter.ts#L23). |Before|After| |---|---| ||| In the recorded examples the bottom safe area is exaggerated to show the dismiss animation differences. ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information To test this PR, I would recommend adding the following styles to the action sheet basic test: ```html ``` You can then open dev-tools and slow the animation speed to 10%: ![CleanShot 2024-01-29 at 19 49 32@2x](https://github.com/ionic-team/ionic-framework/assets/13732623/535fa663-213c-4a09-b94a-db334e4d3d29) - Open and dismiss the action sheet tied to the "Basic" button. - Verify that the action sheet animates completely off the view when dismissed. - Open the and dismiss the action sheet tied to the "Custom CSS Class" button. This implementation customizes the `--height` of the action sheet. - Verify that the action sheet animates completely off the view when dismissed. --------- Co-authored-by: ionitron Co-authored-by: Liam DeBeasi --- .../action-sheet/action-sheet.ios.scss | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/core/src/components/action-sheet/action-sheet.ios.scss b/core/src/components/action-sheet/action-sheet.ios.scss index 594b735386e..7fd36b1251a 100644 --- a/core/src/components/action-sheet/action-sheet.ios.scss +++ b/core/src/components/action-sheet/action-sheet.ios.scss @@ -26,7 +26,24 @@ // --------------------------------------------------- .action-sheet-wrapper { - @include margin(var(--ion-safe-area-top, 0), auto, var(--ion-safe-area-bottom, 0), auto); + @include margin(var(--ion-safe-area-top, 0), auto, null, auto); + /** + * Bottom safe area is applied as padding so that it impacts the bounding box. + * When the action sheet is shown/hidden, this element is transformed by translating + * 100% of its height. This translation needs to include the bottom safe area + * otherwise part of the action sheet will still be visible at the end of + * the show transition. + * + * If this code is changed, reviewers should verify that the action + * sheet still translates out of the viewport completely when the bottom + * safe area is a positive value. + */ + @include padding(null, null, var(--ion-safe-area-bottom, 0), null); + + // Using content-box to increase the height of the action sheet + // wrapper by the bottom padding (safe area) to animate the + // action sheet completely off the screen when safe area is set. + box-sizing: content-box; } // iOS Action Sheet Container From 66fcb70151ef7fccad7b5574962c74f246be180f Mon Sep 17 00:00:00 2001 From: ionitron Date: Wed, 7 Feb 2024 14:20:32 +0000 Subject: [PATCH 10/11] v7.7.1 --- CHANGELOG.md | 14 ++++++++++++++ core/CHANGELOG.md | 13 +++++++++++++ core/package-lock.json | 4 ++-- core/package.json | 2 +- docs/CHANGELOG.md | 8 ++++++++ docs/package-lock.json | 4 ++-- docs/package.json | 2 +- lerna.json | 2 +- packages/angular-server/CHANGELOG.md | 8 ++++++++ packages/angular-server/package-lock.json | 6 +++--- packages/angular-server/package.json | 4 ++-- packages/angular/CHANGELOG.md | 8 ++++++++ packages/angular/package-lock.json | 6 +++--- packages/angular/package.json | 4 ++-- packages/react-router/CHANGELOG.md | 8 ++++++++ packages/react-router/package-lock.json | 6 +++--- packages/react-router/package.json | 4 ++-- packages/react/CHANGELOG.md | 11 +++++++++++ packages/react/package-lock.json | 6 +++--- packages/react/package.json | 4 ++-- packages/vue-router/CHANGELOG.md | 8 ++++++++ packages/vue-router/package-lock.json | 6 +++--- packages/vue-router/package.json | 4 ++-- packages/vue/CHANGELOG.md | 8 ++++++++ packages/vue/package-lock.json | 6 +++--- packages/vue/package.json | 4 ++-- 26 files changed, 123 insertions(+), 37 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 37b951938dc..6a26de87c68 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,20 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [7.7.1](https://github.com/ionic-team/ionic-framework/compare/v7.7.0...v7.7.1) (2024-02-07) + + +### Bug Fixes + +* **action-sheet:** iOS dismiss animation respects safe area ([#28915](https://github.com/ionic-team/ionic-framework/issues/28915)) ([7449fb4](https://github.com/ionic-team/ionic-framework/commit/7449fb4fed4048f5d01ba068dc6f8e2d7727e95d)), closes [#28541](https://github.com/ionic-team/ionic-framework/issues/28541) +* **overlays:** tear down animations after dismiss ([#28907](https://github.com/ionic-team/ionic-framework/issues/28907)) ([950fa40](https://github.com/ionic-team/ionic-framework/commit/950fa40c5597c81d5cbaeb9276b09adfea5e79fb)), closes [#28352](https://github.com/ionic-team/ionic-framework/issues/28352) +* **react:** route with redirect will mount page ([#28961](https://github.com/ionic-team/ionic-framework/issues/28961)) ([5777ce2](https://github.com/ionic-team/ionic-framework/commit/5777ce258119d2715b1326cdc103bd4ad7612bd1)), closes [#28838](https://github.com/ionic-team/ionic-framework/issues/28838) +* **select:** popover can be scrolled ([#28965](https://github.com/ionic-team/ionic-framework/issues/28965)) ([35ab6b4](https://github.com/ionic-team/ionic-framework/commit/35ab6b4816bd627239de8d8b25ce0c86db8c74b4)), closes [#28963](https://github.com/ionic-team/ionic-framework/issues/28963) + + + + + # [7.7.0](https://github.com/ionic-team/ionic-framework/compare/v7.6.7...v7.7.0) (2024-01-31) diff --git a/core/CHANGELOG.md b/core/CHANGELOG.md index bdc18272f25..c202684d81f 100644 --- a/core/CHANGELOG.md +++ b/core/CHANGELOG.md @@ -3,6 +3,19 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [7.7.1](https://github.com/ionic-team/ionic-framework/compare/v7.7.0...v7.7.1) (2024-02-07) + + +### Bug Fixes + +* **action-sheet:** iOS dismiss animation respects safe area ([#28915](https://github.com/ionic-team/ionic-framework/issues/28915)) ([7449fb4](https://github.com/ionic-team/ionic-framework/commit/7449fb4fed4048f5d01ba068dc6f8e2d7727e95d)), closes [#28541](https://github.com/ionic-team/ionic-framework/issues/28541) +* **overlays:** tear down animations after dismiss ([#28907](https://github.com/ionic-team/ionic-framework/issues/28907)) ([950fa40](https://github.com/ionic-team/ionic-framework/commit/950fa40c5597c81d5cbaeb9276b09adfea5e79fb)), closes [#28352](https://github.com/ionic-team/ionic-framework/issues/28352) +* **select:** popover can be scrolled ([#28965](https://github.com/ionic-team/ionic-framework/issues/28965)) ([35ab6b4](https://github.com/ionic-team/ionic-framework/commit/35ab6b4816bd627239de8d8b25ce0c86db8c74b4)), closes [#28963](https://github.com/ionic-team/ionic-framework/issues/28963) + + + + + # [7.7.0](https://github.com/ionic-team/ionic-framework/compare/v7.6.7...v7.7.0) (2024-01-31) diff --git a/core/package-lock.json b/core/package-lock.json index 1d3558d5da1..58ea6e39dfd 100644 --- a/core/package-lock.json +++ b/core/package-lock.json @@ -1,12 +1,12 @@ { "name": "@ionic/core", - "version": "7.7.0", + "version": "7.7.1", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/core", - "version": "7.7.0", + "version": "7.7.1", "license": "MIT", "dependencies": { "@stencil/core": "^4.12.0", diff --git a/core/package.json b/core/package.json index 587f6546f5e..f6a9fdf962d 100644 --- a/core/package.json +++ b/core/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/core", - "version": "7.7.0", + "version": "7.7.1", "description": "Base components for Ionic", "keywords": [ "ionic", diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 5b90e786beb..87484875974 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [7.7.1](https://github.com/ionic-team/ionic-framework/compare/v7.7.0...v7.7.1) (2024-02-07) + +**Note:** Version bump only for package @ionic/docs + + + + + # [7.7.0](https://github.com/ionic-team/ionic-framework/compare/v7.6.7...v7.7.0) (2024-01-31) **Note:** Version bump only for package @ionic/docs diff --git a/docs/package-lock.json b/docs/package-lock.json index 4351a19d89b..6d1ca11d880 100644 --- a/docs/package-lock.json +++ b/docs/package-lock.json @@ -1,12 +1,12 @@ { "name": "@ionic/docs", - "version": "7.7.0", + "version": "7.7.1", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/docs", - "version": "7.7.0", + "version": "7.7.1", "license": "MIT" } } diff --git a/docs/package.json b/docs/package.json index 5e902cb491f..d3afa712478 100644 --- a/docs/package.json +++ b/docs/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/docs", - "version": "7.7.0", + "version": "7.7.1", "description": "Pre-packaged API documentation for the Ionic docs.", "main": "core.json", "types": "core.d.ts", diff --git a/lerna.json b/lerna.json index b62318314a3..b3704e3f4b8 100644 --- a/lerna.json +++ b/lerna.json @@ -4,5 +4,5 @@ "docs", "packages/*" ], - "version": "7.7.0" + "version": "7.7.1" } diff --git a/packages/angular-server/CHANGELOG.md b/packages/angular-server/CHANGELOG.md index e9992ff9089..a9ba4d3db82 100644 --- a/packages/angular-server/CHANGELOG.md +++ b/packages/angular-server/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [7.7.1](https://github.com/ionic-team/ionic-framework/compare/v7.7.0...v7.7.1) (2024-02-07) + +**Note:** Version bump only for package @ionic/angular-server + + + + + # [7.7.0](https://github.com/ionic-team/ionic-framework/compare/v7.6.7...v7.7.0) (2024-01-31) **Note:** Version bump only for package @ionic/angular-server diff --git a/packages/angular-server/package-lock.json b/packages/angular-server/package-lock.json index 9e0f5f28d60..954a43093be 100644 --- a/packages/angular-server/package-lock.json +++ b/packages/angular-server/package-lock.json @@ -1,15 +1,15 @@ { "name": "@ionic/angular-server", - "version": "7.7.0", + "version": "7.7.1", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/angular-server", - "version": "7.7.0", + "version": "7.7.1", "license": "MIT", "dependencies": { - "@ionic/core": "^7.7.0" + "@ionic/core": "^7.7.1" }, "devDependencies": { "@angular-eslint/eslint-plugin": "^14.0.0", diff --git a/packages/angular-server/package.json b/packages/angular-server/package.json index bc0dcfc002a..bdfd9b28d5e 100644 --- a/packages/angular-server/package.json +++ b/packages/angular-server/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/angular-server", - "version": "7.7.0", + "version": "7.7.1", "description": "Angular SSR Module for Ionic", "keywords": [ "ionic", @@ -62,6 +62,6 @@ }, "prettier": "@ionic/prettier-config", "dependencies": { - "@ionic/core": "^7.7.0" + "@ionic/core": "^7.7.1" } } diff --git a/packages/angular/CHANGELOG.md b/packages/angular/CHANGELOG.md index 20655b7967d..392e4cc28e0 100644 --- a/packages/angular/CHANGELOG.md +++ b/packages/angular/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [7.7.1](https://github.com/ionic-team/ionic-framework/compare/v7.7.0...v7.7.1) (2024-02-07) + +**Note:** Version bump only for package @ionic/angular + + + + + # [7.7.0](https://github.com/ionic-team/ionic-framework/compare/v7.6.7...v7.7.0) (2024-01-31) **Note:** Version bump only for package @ionic/angular diff --git a/packages/angular/package-lock.json b/packages/angular/package-lock.json index eeaa270687a..43c1ad6e794 100644 --- a/packages/angular/package-lock.json +++ b/packages/angular/package-lock.json @@ -1,15 +1,15 @@ { "name": "@ionic/angular", - "version": "7.7.0", + "version": "7.7.1", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/angular", - "version": "7.7.0", + "version": "7.7.1", "license": "MIT", "dependencies": { - "@ionic/core": "^7.7.0", + "@ionic/core": "^7.7.1", "ionicons": "^7.0.0", "jsonc-parser": "^3.0.0", "tslib": "^2.3.0" diff --git a/packages/angular/package.json b/packages/angular/package.json index 4e7803f91ca..b6430aa540e 100644 --- a/packages/angular/package.json +++ b/packages/angular/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/angular", - "version": "7.7.0", + "version": "7.7.1", "description": "Angular specific wrappers for @ionic/core", "keywords": [ "ionic", @@ -47,7 +47,7 @@ } }, "dependencies": { - "@ionic/core": "^7.7.0", + "@ionic/core": "^7.7.1", "ionicons": "^7.0.0", "jsonc-parser": "^3.0.0", "tslib": "^2.3.0" diff --git a/packages/react-router/CHANGELOG.md b/packages/react-router/CHANGELOG.md index 1113f0aec43..aeaeab17f74 100644 --- a/packages/react-router/CHANGELOG.md +++ b/packages/react-router/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [7.7.1](https://github.com/ionic-team/ionic-framework/compare/v7.7.0...v7.7.1) (2024-02-07) + +**Note:** Version bump only for package @ionic/react-router + + + + + # [7.7.0](https://github.com/ionic-team/ionic-framework/compare/v7.6.7...v7.7.0) (2024-01-31) **Note:** Version bump only for package @ionic/react-router diff --git a/packages/react-router/package-lock.json b/packages/react-router/package-lock.json index a79f47931ff..3cf1711bae1 100644 --- a/packages/react-router/package-lock.json +++ b/packages/react-router/package-lock.json @@ -1,15 +1,15 @@ { "name": "@ionic/react-router", - "version": "7.7.0", + "version": "7.7.1", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/react-router", - "version": "7.7.0", + "version": "7.7.1", "license": "MIT", "dependencies": { - "@ionic/react": "^7.7.0", + "@ionic/react": "^7.7.1", "tslib": "*" }, "devDependencies": { diff --git a/packages/react-router/package.json b/packages/react-router/package.json index 11796571b0e..aa9af59abf9 100644 --- a/packages/react-router/package.json +++ b/packages/react-router/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/react-router", - "version": "7.7.0", + "version": "7.7.1", "description": "React Router wrapper for @ionic/react", "keywords": [ "ionic", @@ -36,7 +36,7 @@ "dist/" ], "dependencies": { - "@ionic/react": "^7.7.0", + "@ionic/react": "^7.7.1", "tslib": "*" }, "peerDependencies": { diff --git a/packages/react/CHANGELOG.md b/packages/react/CHANGELOG.md index 964202d859b..09c21727679 100644 --- a/packages/react/CHANGELOG.md +++ b/packages/react/CHANGELOG.md @@ -3,6 +3,17 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [7.7.1](https://github.com/ionic-team/ionic-framework/compare/v7.7.0...v7.7.1) (2024-02-07) + + +### Bug Fixes + +* **react:** route with redirect will mount page ([#28961](https://github.com/ionic-team/ionic-framework/issues/28961)) ([5777ce2](https://github.com/ionic-team/ionic-framework/commit/5777ce258119d2715b1326cdc103bd4ad7612bd1)), closes [#28838](https://github.com/ionic-team/ionic-framework/issues/28838) + + + + + # [7.7.0](https://github.com/ionic-team/ionic-framework/compare/v7.6.7...v7.7.0) (2024-01-31) **Note:** Version bump only for package @ionic/react diff --git a/packages/react/package-lock.json b/packages/react/package-lock.json index 39a60a7c3f0..4eb45087d3f 100644 --- a/packages/react/package-lock.json +++ b/packages/react/package-lock.json @@ -1,15 +1,15 @@ { "name": "@ionic/react", - "version": "7.7.0", + "version": "7.7.1", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/react", - "version": "7.7.0", + "version": "7.7.1", "license": "MIT", "dependencies": { - "@ionic/core": "^7.7.0", + "@ionic/core": "^7.7.1", "ionicons": "^7.0.0", "tslib": "*" }, diff --git a/packages/react/package.json b/packages/react/package.json index 241a4dc256f..1f966eccb2a 100644 --- a/packages/react/package.json +++ b/packages/react/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/react", - "version": "7.7.0", + "version": "7.7.1", "description": "React specific wrapper for @ionic/core", "keywords": [ "ionic", @@ -39,7 +39,7 @@ "css/" ], "dependencies": { - "@ionic/core": "^7.7.0", + "@ionic/core": "^7.7.1", "ionicons": "^7.0.0", "tslib": "*" }, diff --git a/packages/vue-router/CHANGELOG.md b/packages/vue-router/CHANGELOG.md index 4c99d7a3197..4d2fa846275 100644 --- a/packages/vue-router/CHANGELOG.md +++ b/packages/vue-router/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [7.7.1](https://github.com/ionic-team/ionic-framework/compare/v7.7.0...v7.7.1) (2024-02-07) + +**Note:** Version bump only for package @ionic/vue-router + + + + + # [7.7.0](https://github.com/ionic-team/ionic-framework/compare/v7.6.7...v7.7.0) (2024-01-31) **Note:** Version bump only for package @ionic/vue-router diff --git a/packages/vue-router/package-lock.json b/packages/vue-router/package-lock.json index 1037eaedc32..71968a429d4 100644 --- a/packages/vue-router/package-lock.json +++ b/packages/vue-router/package-lock.json @@ -1,15 +1,15 @@ { "name": "@ionic/vue-router", - "version": "7.7.0", + "version": "7.7.1", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/vue-router", - "version": "7.7.0", + "version": "7.7.1", "license": "MIT", "dependencies": { - "@ionic/vue": "^7.7.0" + "@ionic/vue": "^7.7.1" }, "devDependencies": { "@ionic/eslint-config": "^0.3.0", diff --git a/packages/vue-router/package.json b/packages/vue-router/package.json index 9c26335ad64..e1296774121 100644 --- a/packages/vue-router/package.json +++ b/packages/vue-router/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/vue-router", - "version": "7.7.0", + "version": "7.7.1", "description": "Vue Router integration for @ionic/vue", "scripts": { "test.spec": "jest", @@ -44,7 +44,7 @@ }, "homepage": "https://github.com/ionic-team/ionic#readme", "dependencies": { - "@ionic/vue": "^7.7.0" + "@ionic/vue": "^7.7.1" }, "devDependencies": { "@ionic/eslint-config": "^0.3.0", diff --git a/packages/vue/CHANGELOG.md b/packages/vue/CHANGELOG.md index f8d8ab7c250..3255d5e4204 100644 --- a/packages/vue/CHANGELOG.md +++ b/packages/vue/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [7.7.1](https://github.com/ionic-team/ionic-framework/compare/v7.7.0...v7.7.1) (2024-02-07) + +**Note:** Version bump only for package @ionic/vue + + + + + # [7.7.0](https://github.com/ionic-team/ionic-framework/compare/v7.6.7...v7.7.0) (2024-01-31) **Note:** Version bump only for package @ionic/vue diff --git a/packages/vue/package-lock.json b/packages/vue/package-lock.json index 45b2d86a263..b1b4538b11b 100644 --- a/packages/vue/package-lock.json +++ b/packages/vue/package-lock.json @@ -1,15 +1,15 @@ { "name": "@ionic/vue", - "version": "7.7.0", + "version": "7.7.1", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/vue", - "version": "7.7.0", + "version": "7.7.1", "license": "MIT", "dependencies": { - "@ionic/core": "^7.7.0", + "@ionic/core": "^7.7.1", "ionicons": "^7.0.0" }, "devDependencies": { diff --git a/packages/vue/package.json b/packages/vue/package.json index a1ca410239a..a6c0f497a06 100644 --- a/packages/vue/package.json +++ b/packages/vue/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/vue", - "version": "7.7.0", + "version": "7.7.1", "description": "Vue specific wrapper for @ionic/core", "scripts": { "eslint": "eslint src", @@ -66,7 +66,7 @@ "vue-router": "^4.0.16" }, "dependencies": { - "@ionic/core": "^7.7.0", + "@ionic/core": "^7.7.1", "ionicons": "^7.0.0" }, "vetur": { From a0afeeb50e82026a3a2014d2fd54ddf3dbb4653e Mon Sep 17 00:00:00 2001 From: ionitron Date: Wed, 7 Feb 2024 14:21:09 +0000 Subject: [PATCH 11/11] chore(): update package lock files --- packages/angular-server/package-lock.json | 12 +++---- packages/angular/package-lock.json | 12 +++---- packages/react-router/package-lock.json | 40 +++++++++++------------ packages/react/package-lock.json | 12 +++---- packages/vue-router/package-lock.json | 40 +++++++++++------------ packages/vue/package-lock.json | 12 +++---- 6 files changed, 64 insertions(+), 64 deletions(-) diff --git a/packages/angular-server/package-lock.json b/packages/angular-server/package-lock.json index 954a43093be..38a93108bf6 100644 --- a/packages/angular-server/package-lock.json +++ b/packages/angular-server/package-lock.json @@ -1060,9 +1060,9 @@ "dev": true }, "node_modules/@ionic/core": { - "version": "7.7.0", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.7.0.tgz", - "integrity": "sha512-ewbvX8u4+FNRBAw1nqBuCy4dI8OLTxoqZgm4qRs4zbrNLJInwTpYjCPzYueN0KE9ufP0n9HhS23lfcrQzJC7Hg==", + "version": "7.7.1", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.7.1.tgz", + "integrity": "sha512-Su4VFwztN8vKyHsIgHMmzQ1ZrIajNzMR7hg2fcv15Y2yrzLpK06PcUf9QutBM9KyP0wQIngwfnO68vrAnqR+xQ==", "dependencies": { "@stencil/core": "^4.12.0", "ionicons": "^7.2.2", @@ -7330,9 +7330,9 @@ "dev": true }, "@ionic/core": { - "version": "7.7.0", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.7.0.tgz", - "integrity": "sha512-ewbvX8u4+FNRBAw1nqBuCy4dI8OLTxoqZgm4qRs4zbrNLJInwTpYjCPzYueN0KE9ufP0n9HhS23lfcrQzJC7Hg==", + "version": "7.7.1", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.7.1.tgz", + "integrity": "sha512-Su4VFwztN8vKyHsIgHMmzQ1ZrIajNzMR7hg2fcv15Y2yrzLpK06PcUf9QutBM9KyP0wQIngwfnO68vrAnqR+xQ==", "requires": { "@stencil/core": "^4.12.0", "ionicons": "^7.2.2", diff --git a/packages/angular/package-lock.json b/packages/angular/package-lock.json index 43c1ad6e794..b189b318b2e 100644 --- a/packages/angular/package-lock.json +++ b/packages/angular/package-lock.json @@ -1407,9 +1407,9 @@ "dev": true }, "node_modules/@ionic/core": { - "version": "7.7.0", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.7.0.tgz", - "integrity": "sha512-ewbvX8u4+FNRBAw1nqBuCy4dI8OLTxoqZgm4qRs4zbrNLJInwTpYjCPzYueN0KE9ufP0n9HhS23lfcrQzJC7Hg==", + "version": "7.7.1", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.7.1.tgz", + "integrity": "sha512-Su4VFwztN8vKyHsIgHMmzQ1ZrIajNzMR7hg2fcv15Y2yrzLpK06PcUf9QutBM9KyP0wQIngwfnO68vrAnqR+xQ==", "dependencies": { "@stencil/core": "^4.12.0", "ionicons": "^7.2.2", @@ -9697,9 +9697,9 @@ "dev": true }, "@ionic/core": { - "version": "7.7.0", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.7.0.tgz", - "integrity": "sha512-ewbvX8u4+FNRBAw1nqBuCy4dI8OLTxoqZgm4qRs4zbrNLJInwTpYjCPzYueN0KE9ufP0n9HhS23lfcrQzJC7Hg==", + "version": "7.7.1", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.7.1.tgz", + "integrity": "sha512-Su4VFwztN8vKyHsIgHMmzQ1ZrIajNzMR7hg2fcv15Y2yrzLpK06PcUf9QutBM9KyP0wQIngwfnO68vrAnqR+xQ==", "requires": { "@stencil/core": "^4.12.0", "ionicons": "^7.2.2", diff --git a/packages/react-router/package-lock.json b/packages/react-router/package-lock.json index 3cf1711bae1..44c846a066a 100644 --- a/packages/react-router/package-lock.json +++ b/packages/react-router/package-lock.json @@ -238,9 +238,9 @@ "dev": true }, "node_modules/@ionic/core": { - "version": "7.7.0", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.7.0.tgz", - "integrity": "sha512-ewbvX8u4+FNRBAw1nqBuCy4dI8OLTxoqZgm4qRs4zbrNLJInwTpYjCPzYueN0KE9ufP0n9HhS23lfcrQzJC7Hg==", + "version": "7.7.1", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.7.1.tgz", + "integrity": "sha512-Su4VFwztN8vKyHsIgHMmzQ1ZrIajNzMR7hg2fcv15Y2yrzLpK06PcUf9QutBM9KyP0wQIngwfnO68vrAnqR+xQ==", "dependencies": { "@stencil/core": "^4.12.0", "ionicons": "^7.2.2", @@ -414,11 +414,11 @@ } }, "node_modules/@ionic/react": { - "version": "7.7.0", - "resolved": "https://registry.npmjs.org/@ionic/react/-/react-7.7.0.tgz", - "integrity": "sha512-ULZLQwuUDz/qDzzdBAn15zKs9LUEp5nl6hMIx8kdWgsEzW95vSKwGaH5Rf1GmYjIhmZfQrW1by02mmho4ahSQg==", + "version": "7.7.1", + "resolved": "https://registry.npmjs.org/@ionic/react/-/react-7.7.1.tgz", + "integrity": "sha512-rfTUAUSqVMzg+R1CEMclSOLwXByJ06qtRXhpyVvJetQFUUVHA8inHdULTJqKN10c0XeZr+WyapGX04IktB9WfQ==", "dependencies": { - "@ionic/core": "7.7.0", + "@ionic/core": "7.7.1", "ionicons": "^7.0.0", "tslib": "*" }, @@ -667,9 +667,9 @@ ] }, "node_modules/@stencil/core": { - "version": "4.12.0", - "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.12.0.tgz", - "integrity": "sha512-qAQcfNmp2sdxAh1DlyUhHfDmIUS7mhI+5LAhPphg74zK9sKgFL5vpLzgjs0wohpjlmI4msgJFYiRB8lxVPqjPg==", + "version": "4.12.1", + "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.12.1.tgz", + "integrity": "sha512-l7UUCEV+4Yr1i6BL2DGSQPAzM3x/V4Fx9n9Z0/gdAgX11I25xY0MnH5jbQ69ug6ms/8KUV6SouS1R7MjjM/JnQ==", "bin": { "stencil": "bin/stencil" }, @@ -4050,9 +4050,9 @@ "dev": true }, "@ionic/core": { - "version": "7.7.0", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.7.0.tgz", - "integrity": "sha512-ewbvX8u4+FNRBAw1nqBuCy4dI8OLTxoqZgm4qRs4zbrNLJInwTpYjCPzYueN0KE9ufP0n9HhS23lfcrQzJC7Hg==", + "version": "7.7.1", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.7.1.tgz", + "integrity": "sha512-Su4VFwztN8vKyHsIgHMmzQ1ZrIajNzMR7hg2fcv15Y2yrzLpK06PcUf9QutBM9KyP0wQIngwfnO68vrAnqR+xQ==", "requires": { "@stencil/core": "^4.12.0", "ionicons": "^7.2.2", @@ -4156,11 +4156,11 @@ "requires": {} }, "@ionic/react": { - "version": "7.7.0", - "resolved": "https://registry.npmjs.org/@ionic/react/-/react-7.7.0.tgz", - "integrity": "sha512-ULZLQwuUDz/qDzzdBAn15zKs9LUEp5nl6hMIx8kdWgsEzW95vSKwGaH5Rf1GmYjIhmZfQrW1by02mmho4ahSQg==", + "version": "7.7.1", + "resolved": "https://registry.npmjs.org/@ionic/react/-/react-7.7.1.tgz", + "integrity": "sha512-rfTUAUSqVMzg+R1CEMclSOLwXByJ06qtRXhpyVvJetQFUUVHA8inHdULTJqKN10c0XeZr+WyapGX04IktB9WfQ==", "requires": { - "@ionic/core": "7.7.0", + "@ionic/core": "7.7.1", "ionicons": "^7.0.0", "tslib": "*" } @@ -4297,9 +4297,9 @@ "optional": true }, "@stencil/core": { - "version": "4.12.0", - "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.12.0.tgz", - "integrity": "sha512-qAQcfNmp2sdxAh1DlyUhHfDmIUS7mhI+5LAhPphg74zK9sKgFL5vpLzgjs0wohpjlmI4msgJFYiRB8lxVPqjPg==" + "version": "4.12.1", + "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.12.1.tgz", + "integrity": "sha512-l7UUCEV+4Yr1i6BL2DGSQPAzM3x/V4Fx9n9Z0/gdAgX11I25xY0MnH5jbQ69ug6ms/8KUV6SouS1R7MjjM/JnQ==" }, "@types/estree": { "version": "1.0.4", diff --git a/packages/react/package-lock.json b/packages/react/package-lock.json index 4eb45087d3f..d86c2bb7e9e 100644 --- a/packages/react/package-lock.json +++ b/packages/react/package-lock.json @@ -811,9 +811,9 @@ "dev": true }, "node_modules/@ionic/core": { - "version": "7.7.0", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.7.0.tgz", - "integrity": "sha512-ewbvX8u4+FNRBAw1nqBuCy4dI8OLTxoqZgm4qRs4zbrNLJInwTpYjCPzYueN0KE9ufP0n9HhS23lfcrQzJC7Hg==", + "version": "7.7.1", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.7.1.tgz", + "integrity": "sha512-Su4VFwztN8vKyHsIgHMmzQ1ZrIajNzMR7hg2fcv15Y2yrzLpK06PcUf9QutBM9KyP0wQIngwfnO68vrAnqR+xQ==", "dependencies": { "@stencil/core": "^4.12.0", "ionicons": "^7.2.2", @@ -12857,9 +12857,9 @@ "dev": true }, "@ionic/core": { - "version": "7.7.0", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.7.0.tgz", - "integrity": "sha512-ewbvX8u4+FNRBAw1nqBuCy4dI8OLTxoqZgm4qRs4zbrNLJInwTpYjCPzYueN0KE9ufP0n9HhS23lfcrQzJC7Hg==", + "version": "7.7.1", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.7.1.tgz", + "integrity": "sha512-Su4VFwztN8vKyHsIgHMmzQ1ZrIajNzMR7hg2fcv15Y2yrzLpK06PcUf9QutBM9KyP0wQIngwfnO68vrAnqR+xQ==", "requires": { "@stencil/core": "^4.12.0", "ionicons": "^7.2.2", diff --git a/packages/vue-router/package-lock.json b/packages/vue-router/package-lock.json index 71968a429d4..edfda093081 100644 --- a/packages/vue-router/package-lock.json +++ b/packages/vue-router/package-lock.json @@ -661,9 +661,9 @@ "dev": true }, "node_modules/@ionic/core": { - "version": "7.7.0", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.7.0.tgz", - "integrity": "sha512-ewbvX8u4+FNRBAw1nqBuCy4dI8OLTxoqZgm4qRs4zbrNLJInwTpYjCPzYueN0KE9ufP0n9HhS23lfcrQzJC7Hg==", + "version": "7.7.1", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.7.1.tgz", + "integrity": "sha512-Su4VFwztN8vKyHsIgHMmzQ1ZrIajNzMR7hg2fcv15Y2yrzLpK06PcUf9QutBM9KyP0wQIngwfnO68vrAnqR+xQ==", "dependencies": { "@stencil/core": "^4.12.0", "ionicons": "^7.2.2", @@ -852,11 +852,11 @@ } }, "node_modules/@ionic/vue": { - "version": "7.7.0", - "resolved": "https://registry.npmjs.org/@ionic/vue/-/vue-7.7.0.tgz", - "integrity": "sha512-Uf+z7h0LbYV0ljBEewkSwScRIXVzKqbSSBcEzji1Hrkefoymwyiw+8uVF9wN0uNlC+sXLDSiPp/VF0vq3+dzpQ==", + "version": "7.7.1", + "resolved": "https://registry.npmjs.org/@ionic/vue/-/vue-7.7.1.tgz", + "integrity": "sha512-hEfmCwuLJTH0QSiSp4jhZApOvZ3RtHBzTvN2LAD+xJ0kPPj2aAtEgR7fqp/7/7ZRbGhSZO5XTzwskQsZTS5HdQ==", "dependencies": { - "@ionic/core": "7.7.0", + "@ionic/core": "7.7.1", "ionicons": "^7.0.0" } }, @@ -1508,9 +1508,9 @@ } }, "node_modules/@stencil/core": { - "version": "4.12.0", - "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.12.0.tgz", - "integrity": "sha512-qAQcfNmp2sdxAh1DlyUhHfDmIUS7mhI+5LAhPphg74zK9sKgFL5vpLzgjs0wohpjlmI4msgJFYiRB8lxVPqjPg==", + "version": "4.12.1", + "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.12.1.tgz", + "integrity": "sha512-l7UUCEV+4Yr1i6BL2DGSQPAzM3x/V4Fx9n9Z0/gdAgX11I25xY0MnH5jbQ69ug6ms/8KUV6SouS1R7MjjM/JnQ==", "bin": { "stencil": "bin/stencil" }, @@ -7878,9 +7878,9 @@ "dev": true }, "@ionic/core": { - "version": "7.7.0", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.7.0.tgz", - "integrity": "sha512-ewbvX8u4+FNRBAw1nqBuCy4dI8OLTxoqZgm4qRs4zbrNLJInwTpYjCPzYueN0KE9ufP0n9HhS23lfcrQzJC7Hg==", + "version": "7.7.1", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.7.1.tgz", + "integrity": "sha512-Su4VFwztN8vKyHsIgHMmzQ1ZrIajNzMR7hg2fcv15Y2yrzLpK06PcUf9QutBM9KyP0wQIngwfnO68vrAnqR+xQ==", "requires": { "@stencil/core": "^4.12.0", "ionicons": "^7.2.2", @@ -7993,11 +7993,11 @@ "requires": {} }, "@ionic/vue": { - "version": "7.7.0", - "resolved": "https://registry.npmjs.org/@ionic/vue/-/vue-7.7.0.tgz", - "integrity": "sha512-Uf+z7h0LbYV0ljBEewkSwScRIXVzKqbSSBcEzji1Hrkefoymwyiw+8uVF9wN0uNlC+sXLDSiPp/VF0vq3+dzpQ==", + "version": "7.7.1", + "resolved": "https://registry.npmjs.org/@ionic/vue/-/vue-7.7.1.tgz", + "integrity": "sha512-hEfmCwuLJTH0QSiSp4jhZApOvZ3RtHBzTvN2LAD+xJ0kPPj2aAtEgR7fqp/7/7ZRbGhSZO5XTzwskQsZTS5HdQ==", "requires": { - "@ionic/core": "7.7.0", + "@ionic/core": "7.7.1", "ionicons": "^7.0.0" } }, @@ -8461,9 +8461,9 @@ } }, "@stencil/core": { - "version": "4.12.0", - "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.12.0.tgz", - "integrity": "sha512-qAQcfNmp2sdxAh1DlyUhHfDmIUS7mhI+5LAhPphg74zK9sKgFL5vpLzgjs0wohpjlmI4msgJFYiRB8lxVPqjPg==" + "version": "4.12.1", + "resolved": "https://registry.npmjs.org/@stencil/core/-/core-4.12.1.tgz", + "integrity": "sha512-l7UUCEV+4Yr1i6BL2DGSQPAzM3x/V4Fx9n9Z0/gdAgX11I25xY0MnH5jbQ69ug6ms/8KUV6SouS1R7MjjM/JnQ==" }, "@tootallnate/once": { "version": "2.0.0", diff --git a/packages/vue/package-lock.json b/packages/vue/package-lock.json index b1b4538b11b..e05c5fe41e0 100644 --- a/packages/vue/package-lock.json +++ b/packages/vue/package-lock.json @@ -208,9 +208,9 @@ "dev": true }, "node_modules/@ionic/core": { - "version": "7.7.0", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.7.0.tgz", - "integrity": "sha512-ewbvX8u4+FNRBAw1nqBuCy4dI8OLTxoqZgm4qRs4zbrNLJInwTpYjCPzYueN0KE9ufP0n9HhS23lfcrQzJC7Hg==", + "version": "7.7.1", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.7.1.tgz", + "integrity": "sha512-Su4VFwztN8vKyHsIgHMmzQ1ZrIajNzMR7hg2fcv15Y2yrzLpK06PcUf9QutBM9KyP0wQIngwfnO68vrAnqR+xQ==", "dependencies": { "@stencil/core": "^4.12.0", "ionicons": "^7.2.2", @@ -3959,9 +3959,9 @@ "dev": true }, "@ionic/core": { - "version": "7.7.0", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.7.0.tgz", - "integrity": "sha512-ewbvX8u4+FNRBAw1nqBuCy4dI8OLTxoqZgm4qRs4zbrNLJInwTpYjCPzYueN0KE9ufP0n9HhS23lfcrQzJC7Hg==", + "version": "7.7.1", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-7.7.1.tgz", + "integrity": "sha512-Su4VFwztN8vKyHsIgHMmzQ1ZrIajNzMR7hg2fcv15Y2yrzLpK06PcUf9QutBM9KyP0wQIngwfnO68vrAnqR+xQ==", "requires": { "@stencil/core": "^4.12.0", "ionicons": "^7.2.2",