From d3df4280582c99b2a54eb52da3110241319ec91d Mon Sep 17 00:00:00 2001 From: Sean Perkins Date: Thu, 7 Mar 2024 14:51:21 +0000 Subject: [PATCH 1/3] fix(nav): add missing ionNavWillChange and ionNavDidChange types --- .../angular/common/src/directives/navigation/nav.ts | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/packages/angular/common/src/directives/navigation/nav.ts b/packages/angular/common/src/directives/navigation/nav.ts index 585bffc0400..3dd9a88df34 100644 --- a/packages/angular/common/src/directives/navigation/nav.ts +++ b/packages/angular/common/src/directives/navigation/nav.ts @@ -1,4 +1,4 @@ -import { ElementRef, Injector, EnvironmentInjector, NgZone, ChangeDetectorRef, Directive } from '@angular/core'; +import { ElementRef, Injector, EnvironmentInjector, NgZone, ChangeDetectorRef, Directive, EventEmitter } from '@angular/core'; import type { Components } from '@ionic/core'; import { AngularDelegate } from '../../providers/angular-delegate'; @@ -23,7 +23,16 @@ const NAV_METHODS = [ ]; // eslint-disable-next-line @typescript-eslint/no-empty-interface -export declare interface IonNav extends Components.IonNav {} +export declare interface IonNav extends Components.IonNav { + /** + * Event fired when the nav will change components + */ + ionNavWillChange: EventEmitter>; + /** + * Event fired when the nav has changed components + */ + ionNavDidChange: EventEmitter>; +} @ProxyCmp({ inputs: NAV_INPUTS, From 4026335e4408e1f3a463604e37ada44331e67bc9 Mon Sep 17 00:00:00 2001 From: Sean Perkins Date: Thu, 7 Mar 2024 15:04:52 +0000 Subject: [PATCH 2/3] chore: prettier --- .../angular/common/src/directives/navigation/nav.ts | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/packages/angular/common/src/directives/navigation/nav.ts b/packages/angular/common/src/directives/navigation/nav.ts index 3dd9a88df34..7f32afc4e20 100644 --- a/packages/angular/common/src/directives/navigation/nav.ts +++ b/packages/angular/common/src/directives/navigation/nav.ts @@ -1,4 +1,12 @@ -import { ElementRef, Injector, EnvironmentInjector, NgZone, ChangeDetectorRef, Directive, EventEmitter } from '@angular/core'; +import { + ElementRef, + Injector, + EnvironmentInjector, + NgZone, + ChangeDetectorRef, + Directive, + EventEmitter, +} from '@angular/core'; import type { Components } from '@ionic/core'; import { AngularDelegate } from '../../providers/angular-delegate'; From 73f4cf339bb0cd1edd2fc248ed76c651ea191295 Mon Sep 17 00:00:00 2001 From: Sean Perkins Date: Mon, 11 Mar 2024 13:15:47 -0400 Subject: [PATCH 3/3] chore: remove unneeded eslint rule --- packages/angular/common/src/directives/navigation/nav.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/angular/common/src/directives/navigation/nav.ts b/packages/angular/common/src/directives/navigation/nav.ts index 7f32afc4e20..78cfaa240fc 100644 --- a/packages/angular/common/src/directives/navigation/nav.ts +++ b/packages/angular/common/src/directives/navigation/nav.ts @@ -30,7 +30,6 @@ const NAV_METHODS = [ 'getPrevious', ]; -// eslint-disable-next-line @typescript-eslint/no-empty-interface export declare interface IonNav extends Components.IonNav { /** * Event fired when the nav will change components