diff --git a/core/src/components/list/list.ionic.scss b/core/src/components/list/list.ionic.scss index afae5e370a1..256c51a97d6 100644 --- a/core/src/components/list/list.ionic.scss +++ b/core/src/components/list/list.ionic.scss @@ -24,6 +24,14 @@ ion-list { @include globals.margin(globals.$ionic-space-100); } +// Ionic No Lines List +// -------------------------------------------------- + +.list-ionic-lines-none .item-lines-default { + --inner-border-width: 0px; + --border-width: 0px; +} + // Ionic Shapes // // The border radius is applied to the list, excluding diff --git a/core/src/components/radio-group/test/basic/index.html b/core/src/components/radio-group/test/basic/index.html index 650695cd2b9..0abe7545e8d 100644 --- a/core/src/components/radio-group/test/basic/index.html +++ b/core/src/components/radio-group/test/basic/index.html @@ -12,6 +12,12 @@ + + @@ -23,29 +29,12 @@ - - - - Radio Group Header - - - - Item 1 - - - - Item 2 - - - - Item 3 - - - - Item 4 - - - + + Label
+ Label
+ Label
+ Label
+
diff --git a/core/src/components/radio-group/test/basic/radio-group.e2e.ts b/core/src/components/radio-group/test/basic/radio-group.e2e.ts index 96b7b5d9556..fd717dc9666 100644 --- a/core/src/components/radio-group/test/basic/radio-group.e2e.ts +++ b/core/src/components/radio-group/test/basic/radio-group.e2e.ts @@ -18,9 +18,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => await page.setContent( ` - - One - + One `, config @@ -34,9 +32,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => await page.setContent( ` - - One - + One `, config @@ -50,9 +46,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => await page.setContent( ` - - One - + One `, config @@ -66,9 +60,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => await page.setContent( ` - - One - + One `, config @@ -82,17 +74,11 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => await page.setContent( ` - - Item 1 - + Item 1 - - Item 2 - + Item 2 - - Item 3 - + Item 3 `, config diff --git a/core/src/components/radio-group/test/item/index.html b/core/src/components/radio-group/test/item/index.html new file mode 100644 index 00000000000..6544cdb5ee9 --- /dev/null +++ b/core/src/components/radio-group/test/item/index.html @@ -0,0 +1,52 @@ + + + + + Radio Group - Item + + + + + + + + + + + + + Radio Group - Item + + + + + + + + Radio Group Header + + + + Item 1 + + + + Item 2 + + + + Item 3 + + + + Item 4 + + + + + + + diff --git a/core/src/components/radio/radio.ionic.scss b/core/src/components/radio/radio.ionic.scss index c7a9b6f4e97..4be5f210629 100644 --- a/core/src/components/radio/radio.ionic.scss +++ b/core/src/components/radio/radio.ionic.scss @@ -142,6 +142,13 @@ max-width: calc(100% / 0.75); } +// Radio Not In Item +// ----------------------------------------- + +:host(:not(.in-item):not(:last-of-type)) { + @include globals.margin(null, null, globals.$ionic-space-200, null); +} + // Ionic Radio: Disabled // ----------------------------------------- diff --git a/core/src/components/radio/test/basic/radio.e2e.ts b/core/src/components/radio/test/basic/radio.e2e.ts new file mode 100644 index 00000000000..78c9cf9f11d --- /dev/null +++ b/core/src/components/radio/test/basic/radio.e2e.ts @@ -0,0 +1,30 @@ +import { expect } from '@playwright/test'; +import { configs, test } from '@utils/test/playwright'; + +configs({ directions: ['ltr'], modes: ['ionic-md'] }).forEach(({ title, screenshot, config }) => { + test.describe(title('radio'), () => { + test('should render multiple correctly', async ({ page }) => { + await page.setContent( + ` + + +
+ + Enable Notifications
+ Enable Notifications +
+
+ `, + config + ); + const container = page.locator('#container'); + await expect(container).toHaveScreenshot(screenshot(`radio-multiple`)); + }); + }); +}); diff --git a/core/src/components/radio/test/basic/radio.e2e.ts-snapshots/radio-multiple-ionic-md-ltr-light-Mobile-Chrome-linux.png b/core/src/components/radio/test/basic/radio.e2e.ts-snapshots/radio-multiple-ionic-md-ltr-light-Mobile-Chrome-linux.png new file mode 100644 index 00000000000..e40520855bc Binary files /dev/null and b/core/src/components/radio/test/basic/radio.e2e.ts-snapshots/radio-multiple-ionic-md-ltr-light-Mobile-Chrome-linux.png differ diff --git a/core/src/components/radio/test/basic/radio.e2e.ts-snapshots/radio-multiple-ionic-md-ltr-light-Mobile-Firefox-linux.png b/core/src/components/radio/test/basic/radio.e2e.ts-snapshots/radio-multiple-ionic-md-ltr-light-Mobile-Firefox-linux.png new file mode 100644 index 00000000000..22e5f79e91d Binary files /dev/null and b/core/src/components/radio/test/basic/radio.e2e.ts-snapshots/radio-multiple-ionic-md-ltr-light-Mobile-Firefox-linux.png differ diff --git a/core/src/components/radio/test/basic/radio.e2e.ts-snapshots/radio-multiple-ionic-md-ltr-light-Mobile-Safari-linux.png b/core/src/components/radio/test/basic/radio.e2e.ts-snapshots/radio-multiple-ionic-md-ltr-light-Mobile-Safari-linux.png new file mode 100644 index 00000000000..ed069073dbd Binary files /dev/null and b/core/src/components/radio/test/basic/radio.e2e.ts-snapshots/radio-multiple-ionic-md-ltr-light-Mobile-Safari-linux.png differ diff --git a/core/src/components/radio/test/item/radio.e2e.ts b/core/src/components/radio/test/item/radio.e2e.ts index 409204eb2ff..4426f013238 100644 --- a/core/src/components/radio/test/item/radio.e2e.ts +++ b/core/src/components/radio/test/item/radio.e2e.ts @@ -19,6 +19,25 @@ configs({ modes: ['ios', 'md', 'ionic-md'] }).forEach(({ title, screenshot, conf const list = page.locator('ion-list'); await expect(list).toHaveScreenshot(screenshot(`radio-list`)); }); + test('should render multiple correctly in list', async ({ page }) => { + await page.setContent( + ` + + + + Enable Notifications + + + Enable Notifications + + + + `, + config + ); + const list = page.locator('ion-list'); + await expect(list).toHaveScreenshot(screenshot(`radio-list-multiple`)); + }); test('should render correctly in inset list', async ({ page }) => { await page.setContent( ` diff --git a/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ionic-md-ltr-light-Mobile-Chrome-linux.png b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ionic-md-ltr-light-Mobile-Chrome-linux.png new file mode 100644 index 00000000000..d92637062a5 Binary files /dev/null and b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ionic-md-ltr-light-Mobile-Chrome-linux.png differ diff --git a/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ionic-md-ltr-light-Mobile-Firefox-linux.png b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ionic-md-ltr-light-Mobile-Firefox-linux.png new file mode 100644 index 00000000000..cb813bb4d4e Binary files /dev/null and b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ionic-md-ltr-light-Mobile-Firefox-linux.png differ diff --git a/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ionic-md-ltr-light-Mobile-Safari-linux.png b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ionic-md-ltr-light-Mobile-Safari-linux.png new file mode 100644 index 00000000000..16cace09141 Binary files /dev/null and b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ionic-md-ltr-light-Mobile-Safari-linux.png differ diff --git a/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ionic-md-rtl-light-Mobile-Chrome-linux.png b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ionic-md-rtl-light-Mobile-Chrome-linux.png new file mode 100644 index 00000000000..e41c892e737 Binary files /dev/null and b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ionic-md-rtl-light-Mobile-Chrome-linux.png differ diff --git a/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ionic-md-rtl-light-Mobile-Firefox-linux.png b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ionic-md-rtl-light-Mobile-Firefox-linux.png new file mode 100644 index 00000000000..25e00907ece Binary files /dev/null and b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ionic-md-rtl-light-Mobile-Firefox-linux.png differ diff --git a/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ionic-md-rtl-light-Mobile-Safari-linux.png b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ionic-md-rtl-light-Mobile-Safari-linux.png new file mode 100644 index 00000000000..1d560092322 Binary files /dev/null and b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ionic-md-rtl-light-Mobile-Safari-linux.png differ diff --git a/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ios-ltr-Mobile-Chrome-linux.png new file mode 100644 index 00000000000..0f2fb2d227c Binary files /dev/null and b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ios-ltr-Mobile-Firefox-linux.png new file mode 100644 index 00000000000..0194f4123fd Binary files /dev/null and b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ios-ltr-Mobile-Safari-linux.png b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ios-ltr-Mobile-Safari-linux.png new file mode 100644 index 00000000000..cd937c40560 Binary files /dev/null and b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ios-rtl-Mobile-Chrome-linux.png new file mode 100644 index 00000000000..4570c62f8a8 Binary files /dev/null and b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ios-rtl-Mobile-Firefox-linux.png new file mode 100644 index 00000000000..a4c36941113 Binary files /dev/null and b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ios-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ios-rtl-Mobile-Safari-linux.png b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ios-rtl-Mobile-Safari-linux.png new file mode 100644 index 00000000000..e421eaa0f59 Binary files /dev/null and b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-md-ltr-Mobile-Chrome-linux.png b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-md-ltr-Mobile-Chrome-linux.png new file mode 100644 index 00000000000..bcda7a1ea1c Binary files /dev/null and b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-md-ltr-Mobile-Firefox-linux.png b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-md-ltr-Mobile-Firefox-linux.png new file mode 100644 index 00000000000..d497d4aa16c Binary files /dev/null and b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-md-ltr-Mobile-Safari-linux.png b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-md-ltr-Mobile-Safari-linux.png new file mode 100644 index 00000000000..a7d620c1608 Binary files /dev/null and b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-md-rtl-Mobile-Chrome-linux.png b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-md-rtl-Mobile-Chrome-linux.png new file mode 100644 index 00000000000..f6b49cacc2d Binary files /dev/null and b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-md-rtl-Mobile-Firefox-linux.png b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-md-rtl-Mobile-Firefox-linux.png new file mode 100644 index 00000000000..27c883fb6cf Binary files /dev/null and b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-md-rtl-Mobile-Safari-linux.png b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-md-rtl-Mobile-Safari-linux.png new file mode 100644 index 00000000000..559de387a52 Binary files /dev/null and b/core/src/components/radio/test/item/radio.e2e.ts-snapshots/radio-list-multiple-md-rtl-Mobile-Safari-linux.png differ