Skip to content

feat(avatar): support new badge hint feature #30223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Mar 3, 2025
Merged

feat(avatar): support new badge hint feature #30223

merged 20 commits into from
Mar 3, 2025

Conversation

@BenOsodrac
Copy link
Contributor

@BenOsodrac BenOsodrac commented Feb 28, 2025 •
edited
Loading

Issue number: internal

What is the new behavior?

  • Added css on avatar to support the new badge vertical prop on md, ios and ionic theme
  • Added support on ionic theme for different position, according to the Avatar size.
  • There's no figma for md/iOS implementation, so just added for now a best effort on how it looks.
  • re-organized tests and added new screenshots for the avatar use-case.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@BenOsodrac BenOsodrac added type: feature request a new feature, enhancement, or improvement package: core @ionic/core package labels Feb 28, 2025
@vercel
Copy link

vercel bot commented Feb 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 5:59pm

@BenOsodrac BenOsodrac requested a review from thetaPC February 28, 2025 10:01
@BenOsodrac BenOsodrac marked this pull request as ready for review February 28, 2025 10:02
@BenOsodrac BenOsodrac requested a review from a team as a code owner February 28, 2025 10:02
thetaPC
thetaPC requested changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sync this branch to ROU-11604, there are files in this PR that shouldn't appear if the branches were in sync.

Also waiting on the badge hint border to be updated.

@BenOsodrac
Copy link
Contributor Author

BenOsodrac commented Mar 2, 2025

Please sync this branch to ROU-11604, there are files in this PR that shouldn't appear if the branches were in sync.

Also waiting on the badge hint border to be updated.

Sorry for that, I believe its correct now 👍

@BenOsodrac BenOsodrac requested a review from thetaPC March 2, 2025 20:41
thetaPC
thetaPC approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenOsodrac BenOsodrac merged commit 2db15bb into ROU-11604 Mar 3, 2025
47 checks passed
@BenOsodrac BenOsodrac deleted the ROU-11628 branch March 3, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thetaPC thetaPC thetaPC approved these changes

Assignees

No one assigned

Labels

package: core @ionic/core package type: feature request a new feature, enhancement, or improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BenOsodrac @thetaPC