New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help us help you please! #2159

Closed
Remco75 opened this Issue Nov 30, 2017 · 10 comments

Comments

Projects
None yet
6 participants
@Remco75

Remco75 commented Nov 30, 2017

I'm submitting a ... (check one with "x")
[ X] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://ionicworldwide.herokuapp.com/

Current behavior:
I am (and lot's of others) submitting issues to this repo. Except some very rare cases, no contributer or member reacts or responds, even if solutions / PR are being made

Expected behavior:
Someone reacts and reviews our code, helping us to help you and keep this code updated

Steps to reproduce:
File an issue, resolve it, comment back, fork and then wait for weeks and weeks

Sorry for taking this approach, but I have multiple issues open with multiple users reacting, I have created solutions, trying to help out. But this is really demotivating. So I just wanna ask:
can we help out? what needs to be done to get things moving on this repo?
greetz, remco

@Jahrenski

This comment has been minimized.

Jahrenski commented Nov 30, 2017

+1 Yes indeed. It feels somehow abandoned.
Documentation has outdated parts and won't explain basic things like why should I use ionic's background location instead of the Mauron85's plugin directly and other stuff.

@janpio

This comment has been minimized.

Contributor

janpio commented Dec 1, 2017

As an onlooker (and pretty little knowledge of Ionic Native [and no commit rights to this repo!]):

  • Make sure your PR and issues mention the plugin being worked on. (Most do, but some don't)
  • Most PRs are unreviewed. Help the maintainers by checking the code and content of other PRs (of other users) and test the changes locally, comment if you successfully used it in your app.
  • Add links to the code/source of the plugin if you make changes to the Ionic Native wrapper where one can see that you are using/adding/modifying the correct methods/options etc - often one first has to find the actual plugin, read or search the docs, sometimes even the code to find out if the suggested changes actually match the plugin
  • If there is a list of PRs you are sure are good to merge, create an issue where you list them. Mention if code was reviewed, locally tested, if the changes are documented with link to the plugin source - this will make it much easier for a maintainer to go through all of them.

Update: To put some money where my mouth is I just went through page 2 of the PRs and commented or reviewed most of them so a maintainer will have it a lot easier to go through those.

@Remco75

This comment has been minimized.

Remco75 commented Dec 1, 2017

@janpio Cool thnx, wherever I can I help out. This is a very broad repo, so only a few now about a subject (the maintainers prob have the most knowledge!)

Problem is not that the community is not reacting: They do, and they help each other out.
Once there is some more reaction from the maintainers I (and others) will be prepared to contribute / get involved even more. But for now it really seems a waste of my time

@janpio

This comment has been minimized.

Contributor

janpio commented Dec 1, 2017

Looking at the closed PRs and issues it was ~3 weeks ago that a maintainer did a load of work. My guess is they are currently working on something else (different project, new stuff) and will come back to this repo later. No sign at all that this is actually abandoned or anything.

@Remco75

This comment has been minimized.

Remco75 commented Dec 1, 2017

hehe, I think we will just have to agree to disagree here. I have issues open for months, created a fork for a dependency that many user now use, I have asked in my issues many times if there was a maintainer who would step in. Other issues are confirmed by other users, again with the same result.

And just look at the comments in the issue que: it's pretty hard to even find a contributer reacting / helping out, let alone a member.

It is just not maintained. (btw: I really appreciate the effort you put in here!) At least someone is reacting :-)

@janpio

This comment has been minimized.

Contributor

janpio commented Dec 1, 2017

And page 1 is also reviewed/commented. Let's see what happens.

@mlynch

This comment has been minimized.

Member

mlynch commented Dec 1, 2017

The project isn't abandoned at all, it's used in every single default Ionic app. We're incredibly busy right now and we don't spend all of our time on ionic-native (though the last release was only 15 days ago). A PR being submitted is incredibly helpful for the community, and we very much appreciate it, but we never guarantee that we'll merge them.

We would love to find additional maintainers to focus on the project. If that interests you, please let me know and we can talk about getting you on the repo and our long term plans.

@mlynch mlynch closed this Dec 1, 2017

@darthdie

This comment has been minimized.

darthdie commented Dec 1, 2017

@mlynch I'd be glad to be a maintainer to help out.

@joshbabb

This comment has been minimized.

Contributor

joshbabb commented Dec 8, 2017

Ionic Native is a core piece of Ionic. If you need additional hands, just ask. I can (and try to) help when I encounter an issue in the wild, anyways.

@mlynch

This comment has been minimized.

Member

mlynch commented Dec 8, 2017

Thanks @darthdie and @joshbabb. I think I got an email from one of you but could you two email me again so we can chat privately about next steps? max@ionicframework.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment