fix(angular): do not navigate to same tab if already active (#21085)

fixes #21074, fixes #19943
ionic-team · Apr 27, 2020 · 15203de · 15203de
1 parent 671802f
commit 15203de
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/angular/src/directives/navigation/ion-tabs.ts b/angular/src/directives/navigation/ion-tabs.ts
@@ -91,6 +91,12 @@ export class IonTabs {
     const alreadySelected = this.outlet.getActiveStackId() === tab;
     const tabRootUrl = `${this.outlet.tabsPrefix}/${tab}`;
     if (alreadySelected) {
+      const activeStackId = this.outlet.getActiveStackId();
+      const activeView = this.outlet.getLastRouteView(activeStackId);
+
+      // If on root tab, do not navigate to root tab again
+      if (activeView.url === tabRootUrl) { return; }
+
       const rootView = this.outlet.getRootView(tab);
       const navigationExtras = rootView && tabRootUrl === rootView.url && rootView.savedExtras;
       return this.navCtrl.navigateRoot(tabRootUrl, {