Skip to content
Permalink
Browse files

fix(popover): update placement per md spec (#17429)

  • Loading branch information...
daem0ndev authored and liamdebeasi committed Feb 27, 2019
1 parent 484d92c commit a99d17952ba646a9dc58f52bd3ca9dd37f99380f
Showing with 4 additions and 3 deletions.
  1. +4 −3 core/src/components/popover/animations/md.enter.ts
@@ -22,9 +22,10 @@ export function mdEnterAnimation(AnimationC: Animation, baseEl: HTMLElement, ev?
const targetDim =
ev && ev.target && (ev.target as HTMLElement).getBoundingClientRect();

// As per MD spec, by default position the popover below the target (trigger) element
const targetTop =
targetDim != null && 'top' in targetDim
? targetDim.top
targetDim != null && 'bottom' in targetDim
? targetDim.bottom
: bodyHeight / 2 - contentHeight / 2;

const targetLeft =
@@ -60,7 +61,7 @@ export function mdEnterAnimation(AnimationC: Animation, baseEl: HTMLElement, ev?
targetTop + targetHeight + contentHeight > bodyHeight &&
targetTop - contentHeight > 0
) {
popoverCSS.top = targetTop - contentHeight;
popoverCSS.top = targetTop - contentHeight - targetHeight;
baseEl.className = baseEl.className + ' popover-bottom';
originY = 'bottom';
// If there isn't room for it to pop up above the target cut it off

0 comments on commit a99d179

Please sign in to comment.
You can’t perform that action at this time.