Skip to content
Permalink
Browse files

fix(radio-group): get radios before caching value to avoid infinite l…

…oop (#19448)

fixes #19277
  • Loading branch information...
liamdebeasi committed Sep 25, 2019
1 parent 446cf78 commit cf223e40c19ad12d2ee0c2f9c1964dbf5d3d5154
Showing with 7 additions and 1 deletion.
  1. +7 −1 core/src/components/radio-group/radio-group.tsx
@@ -83,8 +83,14 @@ export class RadioGroup implements ComponentInterface {
}

private async updateRadios() {
const { value } = this;
/**
* Make sure we get all radios first
* so values are up to date prior
* to caching the radio group value
*/
const radios = await this.getRadios();
const { value } = this;

let hasChecked = false;

// Walk the DOM in reverse order, since the last selected one wins!

0 comments on commit cf223e4

Please sign in to comment.
You can’t perform that action at this time.