New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I need to tap twice to trigger the event #11616

Closed
devfelipereis opened this Issue May 11, 2017 · 9 comments

Comments

Projects
None yet
5 participants
@devfelipereis

devfelipereis commented May 11, 2017

Ionic version:
[x] 1.x
[ ] 2.x
[ ] 3.x

I'm submitting a ...
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

Current behavior:
I need to tap twice(fast) to trigger the event(to open menu, any button in my screen, etc...).

Expected behavior:
One tap to trigger the event.

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):

Cordova CLI: 6.4.0
Ionic CLI Version: 2.2.3
Ionic App Lib Version: 2.2.1
ios-deploy version: Not installed
ios-sim version: Not installled
OS: macOS Sierra
Node Version: v7.9.0
Xcode version: Xcode 8.2.1 Build version 8C1002

It has the same behavior on emulator and device(iOS). On Android it's working fine.

@jgw96

This comment has been minimized.

Contributor

jgw96 commented May 11, 2017

Hello, thanks for using Ionic. Could you post a repo we could use to reproduce this?

@devfelipereis

This comment has been minimized.

devfelipereis commented May 11, 2017

Hello! It's a private project, I can not post any code here :/

Can I help with some information about libs, etc?

@jgw96

This comment has been minimized.

Contributor

jgw96 commented May 11, 2017

Thats fine, no need to post a full project, in fact that would make triaging this issue hard. If you could just post a minimal repo that reproduces this issue that would be great!

@daveshirman

This comment has been minimized.

daveshirman commented May 14, 2017

Your Ionic info output looks like it's version 2, not 1.
If that's the case, then change your bug report to check the right box and:

Add the tappable attribute to your element. It's likely you've got the same problem I had, here's my blog post about it:

http://www.codingandclimbing.co.uk/blog/ionic-2-fix-ios-side-menu-double-tap-bug

@jgw96

This comment has been minimized.

Contributor

jgw96 commented May 15, 2017

Hello all! As it seems it has been a while since there was any activity on this issue i will be closing it for now. Feel free to comment if you are still running into this issue. Thanks for using Ionic!

PS: nice blog post @daveshirman !

@jgw96 jgw96 closed this May 15, 2017

@patrickmcd

This comment has been minimized.

Contributor

patrickmcd commented May 15, 2017

@daveshirman re: your blog post, I don't think suggesting tappable for ion-item is good advice.

Rather, those should be converted to <button ion-item>, while reserving tappable for out-of-the-ordinary use cases.


As the link to the Ionic docs that you mentioned in your blog post says:

In general, we recommend only adding (click) events to elements that are normally clickable. This includes "button" and "a" elements. This improves accessibility as a screen reader will be able to tell that the element is clickable.

So it seems suggesting tappable for ion-item would hurt accessibility, and the best choice would be to use buttons as your first choice.

@daveshirman

This comment has been minimized.

daveshirman commented May 15, 2017

@chandanch

This comment has been minimized.

chandanch commented May 15, 2017

For components that are clickable we must add the tappableattribute. Or you can also use the tap event.

@ionitron-bot

This comment has been minimized.

ionitron-bot bot commented Sep 3, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 3, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.