Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.0.0-beta.13] AlertController: input date no longer accepts min & max dates #15986

Closed
abennouna opened this issue Oct 17, 2018 · 1 comment
Labels

Comments

@abennouna
Copy link
Contributor

abennouna commented Oct 17, 2018

Bug Report

Ionic Info

Ionic:

   ionic (Ionic CLI)             : 4.2.1 (~/.nvm/versions/node/v10.12.0/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.0.0-beta.13
   @angular-devkit/build-angular : 0.7.5
   @angular-devkit/schematics    : 0.7.5
   @angular/cli                  : 6.2.5
   @ionic/angular-toolkit        : 1.0.0

System:

   NodeJS : v10.12.0 (~/.nvm/versions/node/v10.12.0/bin/node)
   npm    : 6.4.1
   OS     : macOS High Sierra

Describe the Bug
The AlertController inputs no longer accept min and max dates for a date input.

Steps to Reproduce
Steps to reproduce the behavior:

  1. Create a blank project
  2. Use the Angular example from the docs
  3. See the TS Lint error Type 'string' is not assignable to type 'number'.

Related Code
None.

Expected Behavior
The min and max properties are supported for date inputs.

Additional Context
The commit 1d001a3 strong-typed min and max as number instead of string | number like it was before.
Issue is solved by using string | number again.

@ionitron-bot
Copy link

ionitron-bot bot commented Nov 22, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant