Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ionic 4 textarea: MD design looks wrong #16187

Closed
brandyscarney opened this issue Nov 1, 2018 · 2 comments

Comments

1 participant
@brandyscarney
Copy link
Member

commented Nov 1, 2018

Material Design textarea doesn't look good in this test:

screen shot 2018-11-01 at 2 59 43 pm

I believe this is mostly attribute issues that need to be updated, maybe some styles as well

@ionitron-bot ionitron-bot bot added the triage label Nov 1, 2018

@brandyscarney brandyscarney changed the title textarea: MD design looks wrong Ionic 4 textarea: MD design looks wrong Nov 1, 2018

@ionitron-bot ionitron-bot bot removed the triage label Dec 4, 2018

@brandyscarney

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2019

Also need to look into the animation when value is changed on a floating label after a 1 second timeout. It is nonexistent there and if you up the timeout then it still looks off.

@brandyscarney brandyscarney self-assigned this Apr 15, 2019

@brandyscarney brandyscarney added this to Backlog 🤖 in Ionic Core via automation Apr 15, 2019

@brandyscarney brandyscarney moved this from Backlog 🤖 to Needs review 🤔 in Ionic Core Apr 15, 2019

Ionic Core automation moved this from Needs review 🤔 to Done 🎉 Apr 16, 2019

Kiku-git added a commit to Kiku-git/ionic that referenced this issue May 16, 2019

fix(textarea): update label alignment for inputs and textareas (ionic…
…-team#18042)

- aligns label and textarea to baseline
- updates floating and stacked labels in items to align closer to the md spec

fixes ionic-team#16187
@ionitron-bot

This comment has been minimized.

Copy link

commented May 16, 2019

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators May 16, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.