New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.0-beta.15 ionic-split-pane bad positioning for slides #16252

Open
peterennis opened this Issue Nov 7, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@peterennis

peterennis commented Nov 7, 2018

Bug Report

Ionic Info
Run ionic info from a terminal/cmd prompt and paste the output below.

C:\ae\adaept.com\aetabs>ionic info

Ionic:

   ionic (Ionic CLI)             : 4.3.1 (C:\Users\peter\AppData\Roaming\npm\node_modules\ionic)
   Ionic Framework               : @ionic/angular 4.0.0-beta.15
   @angular-devkit/build-angular : 0.10.4
   @angular-devkit/schematics    : 7.0.4
   @angular/cli                  : 7.0.4
   @ionic/angular-toolkit        : 1.1.0

System:

   NodeJS : v8.12.0 (C:\Program Files\nodejs\node.exe)
   npm    : 6.4.1
   OS     : Windows 10


C:\ae\adaept.com\aetabs>

Describe the Bug
A clear and concise description of what the bug is.

Steps to Reproduce
Steps to reproduce the behavior:
https://aetabs.adaept.com
slide-position

Compare with:
https://aeion4.adaept.com
slide-position3

Related Code
https://github.com/peterennis/aetabs
https://github.com/peterennis/aeion4

Expected Behavior
Correct resizing and positioning of slides when using split-pane.

@ionitron-bot ionitron-bot bot added the triage label Nov 7, 2018

@almothafar

This comment has been minimized.

almothafar commented Nov 7, 2018

Yeah got the same issue even in previous versions, I noticed that the issue kinda better if you use https://github.com/zefoy/ngx-swiper-wrapper instead of ionic swiper (they both are the same), just try it and use the component version, not the directive.

You will get some other issues, but give it a try, from my side I gave up the split at all and removed it, and used Platform from import { Platform } from '@ionic/angular' and *ngIf="platform.is('mobile')" to render menu and its button for mobile and *ngIf="!platform.is('mobile')" for desktop, not really best practice but it gives me some progress instead of wasting time catching that component issues.

@peterennis

This comment has been minimized.

peterennis commented Nov 8, 2018

@almothafar
Thanks for that! It works on mobile with the split-pane code still in place. I can live with the poor desktop slide presentation on PWA at the moment, but it's good to know a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment