New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0.0-beta.15] content resize method missing #16258

Open
meta0102 opened this Issue Nov 7, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@meta0102

meta0102 commented Nov 7, 2018

Bug Report

Ionic:

ionic (Ionic CLI) : 4.0.6

System:

NodeJS : v8.11.3
npm : 6.4.1
OS : Windows 10

Describe the Bug
the resize method for ion-content is missing. i need to call this method to resize the searchbar
see #7706

@ionitron-bot ionitron-bot bot added the triage label Nov 7, 2018

@brandyscarney

This comment has been minimized.

Member

brandyscarney commented Nov 7, 2018

Thanks for the issue! In Ionic 4, the ion-content layout is based on flex. This means the size of the content will automatically adjust without the need to call resize(). I'm not able to see any issues with this and removing the toolbar. Could you please provide a way for us to reproduce if you're seeing issues with this? Thanks!

@ionitron-bot ionitron-bot bot removed the triage label Nov 7, 2018

@meta0102

This comment has been minimized.

meta0102 commented Nov 7, 2018

hi, sure.
the problem appears only on big screens, on mobile width all looks fine

<ion-header no-border>
  <ion-toolbar class="transparent-toolbar">
    <ion-buttons slot="end">
      <ion-button *ngIf="!showSearchBar" icon-only (click)="presentSearch()">
        <ion-icon class="md-icon" name="search"></ion-icon>
      </ion-button>
    </ion-buttons>
    <ion-title *ngIf="!showSearchBar">{{title}}</ion-title>
    <ion-searchbar showCancelButton *ngIf="showSearchBar" placeholder="Suchen" (ionClear)="onSearchCancel($event)" [(ngModel)]="searchstring" (search)="search()"></ion-searchbar>
  </ion-toolbar>
</ion-header>

<ion-content fullscreen>
</ion-content>


presentSearch() {
      this.showSearchBar = true;
}
onSearchCancel() {
      this.showSearchBar = false;
      this.searchstring = '';
}
search() {

}

thanks

@ionitron-bot ionitron-bot bot added triage and removed needs reply labels Nov 7, 2018

@peterpeterparker

This comment has been minimized.

Contributor

peterpeterparker commented Nov 9, 2018

I think resize is not needed anymore in v4, duplicate #14875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment