New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] Unable to set default mode for platform #16272

Open
ireade opened this Issue Nov 8, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@ireade
Contributor

ireade commented Nov 8, 2018

Bug Report

Ionic Info
Run ionic info from a terminal/cmd prompt and paste the output below.

Ionic:

   ionic (Ionic CLI)          : 4.1.2 (/usr/local/lib/node_modules/ionic)
   Ionic Framework            : @ionic/angular 4.0.0-beta.15-0
   @angular-devkit/core       : 0.7.5
   @angular-devkit/schematics : 0.7.5
   @angular/cli               : 6.1.5
   @ionic/ng-toolkit          : 1.0.8
   @ionic/schematics-angular  : 1.0.6

Cordova:

   cordova (Cordova CLI) : 8.0.0
   Cordova Platforms     : android 7.1.0, ios 4.5.5
   Cordova Plugins       : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 2.2.0, (and 15 other plugins)

System:

   ios-deploy : 2.0.0
   NodeJS     : v8.11.3 (/usr/local/bin/node)
   npm        : 5.6.0
   OS         : macOS
   Xcode      : Xcode 10.0 Build version 10A255

Describe the Bug
The IonicModule config no longer allows me to set a mode for the core platform. In previous versions of Ionic, I could do this like:

// Older versions of Ionic
IonicModule.forRoot(MyApp, {
    platforms: {
        core: { mode: 'ios'},
    },
})

In v4, I'm no longer able to set the platforms key in the config.

// Doesn't work because there is no `platforms` in the config
IonicModule.forRoot({
    platforms: {
        core: { mode: 'ios'},
    },
}),

@ionitron-bot ionitron-bot bot added the triage label Nov 8, 2018

@DreamPWJ

This comment has been minimized.

DreamPWJ commented Nov 9, 2018

    IonicModule.forRoot({
            mode: 'ios', // android 是 md
            backButtonText: '',
        }
@ireade

This comment has been minimized.

Contributor

ireade commented Nov 9, 2018

@DreamPWJ That sets the mode globally. I only want to set the mode for the web application, i.e. the core platform

@DreamPWJ

This comment has been minimized.

DreamPWJ commented Nov 9, 2018

see #15388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment