Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flat modules for ionic/angular #17001

Closed
manucorporat opened this issue Jan 8, 2019 · 3 comments

Comments

@manucorporat
Copy link
Member

commented Jan 8, 2019

  • Ship fesm5.js (es5) legacy build
  • Ship fesm2015.js (es2017) modern build
  • Use angular's flatModule feature, exporting a single .metadata.json file

https://github.com/angular/angular/blob/f5471107d94a5a2ec9d024e076cc4f1a4882013f/packages/core/tsconfig-build.json#L28-L29

GOAL:

  • Speed up build using ionic/angular
  • Reduce webpack overhead
  • Improve treeshakability
  • Ship untranspiled async/await and classes for modern build
@adamduren

This comment has been minimized.

Copy link
Contributor

commented Jan 8, 2019

@manucorporat did this PR have the desired effect of reducing build times? Would you mind sharing any stats?

@tonyawad88

This comment has been minimized.

Copy link

commented Jan 11, 2019

@manucorporat #16979 great job! thank you, the compile time has improved by about 2 seconds for me, much more acceptable. Any ideas if there's time for another round of optimizations before the final release?

@ionitron-bot

This comment has been minimized.

Copy link

commented Feb 10, 2019

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Feb 10, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.