Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ion-item doesn't have `ripple-color` css variable #17523

Closed
bilalrazamoon opened this issue Feb 17, 2019 · 1 comment

Comments

2 participants
@bilalrazamoon
Copy link

commented Feb 17, 2019

Bug Report

Ionic version:

[x] 4.0.1

Current behavior:

ion-item doesn't have ripple-color css variable

Expected behavior:

ion-item should have ripple-color css variable

Steps to reproduce:

check below code.

Related code:

<ion-item href="#">
  <ion-label>
    Daily
  </ion-label>
</ion-item>
ion-item {
  --ripple-color: red;
}

Other information:

Ionic info:

Ionic:

   ionic (Ionic CLI)             : 4.10.2 (/Users/bilal/.config/yarn/global/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.0.1
   @angular-devkit/build-angular : 0.12.4
   @angular-devkit/schematics    : 7.2.4
   @angular/cli                  : 7.3.1
   @ionic/angular-toolkit        : 1.2.3

Cordova:

   cordova (Cordova CLI) : 8.1.2 (cordova-lib@8.1.1)
   Cordova Platforms     : android 7.1.4, ios 4.5.5
   Cordova Plugins       : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 3.1.1, (and 22 other plugins)

System:

   Android SDK Tools : 26.1.1 (/Users/bilal/Library/Android/sdk)
   ios-sim           : 6.1.3
   NodeJS            : v8.12.0 (/Users/bilal/.nvm/versions/node/v8.12.0/bin/node)
   npm               : 6.5.0
   OS                : macOS Mojave
   Xcode             : Xcode 10.1 Build version 10B61

@ionitron-bot ionitron-bot bot added the triage label Feb 17, 2019

@brandyscarney brandyscarney added this to Backlog 🤖 in Ionic Core via automation Feb 18, 2019

@ionitron-bot ionitron-bot bot removed the triage label Feb 18, 2019

@brandyscarney brandyscarney moved this from Backlog 🤖 to On deck ⚾️ in Ionic Core Mar 7, 2019

@brandyscarney brandyscarney moved this from On deck ⚾️ to In progress 🤺 in Ionic Core Mar 18, 2019

@brandyscarney brandyscarney self-assigned this Mar 18, 2019

@brandyscarney brandyscarney moved this from In progress 🤺 to Needs review 🤔 in Ionic Core Mar 18, 2019

Ionic Core automation moved this from Needs review 🤔 to Done 🎉 Mar 19, 2019

brandyscarney added a commit that referenced this issue Mar 19, 2019

fix(item): add missing ripple color CSS property (#17814)
Adds missing --ripple-color var to item

fixes #17523
@ionitron-bot

This comment has been minimized.

Copy link

commented Apr 18, 2019

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Apr 18, 2019

Kiku-git added a commit to Kiku-git/ionic that referenced this issue May 16, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.