Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] toast action button #17611

Closed
dangerdan opened this issue Feb 25, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@dangerdan
Copy link

commented Feb 25, 2019

Feature Request

Ionic version:
[x] 4.x

Describe the Feature Request
I believe the toast component should have an 'action' option, that fires when the toast is tapped, either on the displayed message text or a separate button that can be shown in addition to the close button.

Describe Preferred Solution
Described above. This is necessary when using the toast component for displaying things like notifications, that then need an option to show more detail.

Describe Alternatives
I've not been able to find anything.

Related Code
I've already started implementing this here: https://github.com/dangerdan/ionic/tree/toast-added-action-button

@ionitron-bot

This comment has been minimized.

Copy link

commented May 11, 2019

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators May 11, 2019

Kiku-git added a commit to Kiku-git/ionic that referenced this issue May 16, 2019

feat(toast): add header and additional custom toast buttons (ionic-te…
…am#17147)

Adds a `header` and `buttons` property to toast. This allows for a toast header to be passed and multiple buttons including action buttons and icon only buttons which matches the Material Design spec. Adds hover states to the button to match the spec. Updates usage section to recommend the new way of passing a close button using the buttons array and `cancel` role. If a button is passed using the cancel role default the color to match the spec. Buttons will default to the `end` side but have the option of being placed on the `start` side.

Co-authored-by: Simon Hänisch <simonhaenisch@users.noreply.github.com>
Co-authored-by: Brandy Carney <brandy@ionic.io>

closes ionic-team#16791 closes ionic-team#16237 closes ionic-team#17611
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.