Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinner icons: incorrect default spinners in MD #17659

Closed
abennouna opened this issue Mar 2, 2019 · 1 comment

Comments

2 participants
@abennouna
Copy link
Contributor

commented Mar 2, 2019

Bug Report

Ionic version:
[x] 4.x

Current behavior:
The default spinner icon uses the iOS platform default (lines), even in MD mode, for the following components:

  • refresher
  • infinite-scroll

Expected behavior:
In MD mode, the default spinner icon should be crescent.

Steps to reproduce:
Use one of these components in MD mode, without specifying an icon.

Related code:

<ion-refresher slot="fixed" (ionRefresh)="doRefresh($event)">
  <ion-refresher-content></ion-refresher-content>
</ion-refresher>

<ion-infinite-scroll threshold="100px" (ionInfinite)="loadData($event)">
  <ion-infinite-scroll-content></ion-infinite-scroll-content>
</ion-infinite-scroll>

Other information:
I'm submitting a PR for it.

Ionic info:

Ionic:

   ionic (Ionic CLI)             : 4.10.3 (~/.nvm/versions/node/v10.12.0/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.1.0-dev.201902272232.d66b12b
   @angular-devkit/build-angular : 0.13.4
   @angular-devkit/schematics    : 7.3.4
   @angular/cli                  : 7.3.4
   @ionic/angular-toolkit        : 1.4.0

System:

   NodeJS : v10.12.0 (~/.nvm/versions/node/v10.12.0/bin/node)
   npm    : 6.4.1
   OS     : macOS High Sierra

@ionitron-bot ionitron-bot bot added the triage label Mar 2, 2019

@ionitron-bot ionitron-bot bot removed the triage label Mar 4, 2019

@brandyscarney brandyscarney added this to Backlog 🤖 in Ionic Core via automation Mar 15, 2019

Ionic Core automation moved this from Backlog 🤖 to Done 🎉 Mar 15, 2019

santoshyadav198613 added a commit to santoshyadav198613/ionic that referenced this issue Mar 16, 2019

fix(spinner): fix default spinner logic for relevant components (ioni…
…c-team#17660)

- In the **`loading`** component, fallback to `spinner` icon config before platform default.
- In both **`refresher`** & **`infinite-scroll`** components, use platform default as final fallback.
- In **`infinite-scroll`** test templates, and the _basic_ **`virtual-scroll`** test template, fix loading _spinner_ and _text_ attributes.

fixes ionic-team#17659
@ionitron-bot

This comment has been minimized.

Copy link

commented Apr 14, 2019

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Apr 14, 2019

Kiku-git added a commit to Kiku-git/ionic that referenced this issue May 16, 2019

fix(spinner): fix default spinner logic for relevant components (ioni…
…c-team#17660)

- In the **`loading`** component, fallback to `spinner` icon config before platform default.
- In both **`refresher`** & **`infinite-scroll`** components, use platform default as final fallback.
- In **`infinite-scroll`** test templates, and the _basic_ **`virtual-scroll`** test template, fix loading _spinner_ and _text_ attributes.

fixes ionic-team#17659
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.