Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't reorder if ion-reorder-group is located in a shadow dom component #17746

Closed
adamlacombe opened this issue Mar 10, 2019 · 1 comment

Comments

2 participants
@adamlacombe
Copy link
Contributor

commented Mar 10, 2019

Bug Report

Ionic version:

[x] 4.1.1

Current behavior:

ion-reorder-group / ion-reorder doesn't function if located within a shadow dom component. I am unable to grab & move ion-items.

Expected behavior:

Should be able to reorder items even if ion-reorder-group is located within a shadow dom component.

Steps to reproduce:

Related code:

git clone https://github.com/adamlacombe/ionic-reorder-group-shadow-dom-issue.git && cd ionic-reorder-group-shadow-dom-issue && npm install && npm run start

Other information:

I'm building my application using @stencil/core@0.18.1-2.

I will be submitting a PR to Ionic that solves this issue.

@ionitron-bot ionitron-bot bot added the triage label Mar 10, 2019

adamlacombe added a commit to InteractiveTraining/ionic that referenced this issue Mar 10, 2019

@ionitron-bot ionitron-bot bot removed triage labels Mar 11, 2019

@brandyscarney brandyscarney added this to Backlog 🤖 in Ionic Core via automation Mar 26, 2019

@liamdebeasi liamdebeasi moved this from Backlog 🤖 to Done 🎉 in Ionic Core Mar 28, 2019

@ionitron-bot

This comment has been minimized.

Copy link

commented Apr 25, 2019

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Apr 25, 2019

Kiku-git added a commit to Kiku-git/ionic that referenced this issue May 16, 2019

fix(reorder-group): add ability to reorder items inside shadow (ionic…
…-team#17747)

- adds ability to reorder items from within a shadow dom component
- adds interactive test

fixes ionic-team#17746
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.