Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CSS theming variables for focused & hover elements #18279

Open
brandyscarney opened this issue May 14, 2019 · 1 comment

Comments

@brandyscarney
Copy link
Member

commented May 14, 2019

Feature Request

Ionic version:

[x] 4.x

Describe the Feature Request

We need a way to change the toolbar button's focused properties.

Describe Preferred Solution

I think this will require us to add global CSS variables here: https://github.com/ionic-team/ionic/blob/master/core/src/themes/ionic.theme.default.md.scss#L25-L28

Describe Alternatives

Related Code

https://github.com/ionic-team/ionic/blob/master/core/src/themes/ionic.theme.default.md.scss#L25-L28

Additional Context

Found in the PR here: #18191

@brandyscarney

This comment has been minimized.

Copy link
Member Author

commented May 15, 2019

Also look into some of the missing hover/focused variables on things like menu button

@brandyscarney brandyscarney added this to Backlog 🤖 in Ionic Core via automation May 29, 2019

@brandyscarney brandyscarney moved this from Backlog 🤖 to In progress 🤺 in Ionic Core May 30, 2019

@brandyscarney brandyscarney self-assigned this May 30, 2019

brandyscarney added a commit that referenced this issue May 31, 2019

feat(menu-button): add variables for hover and focused states
updates to match the MD spec, adds styles for background hover and rounds the button, moves width and height to the host element, fixes the color so it uses Ionic colors instead of adding color to the icon

references #18279

brandyscarney added a commit that referenced this issue May 31, 2019

brandyscarney added a commit that referenced this issue Jun 3, 2019

feat(back-button): add variables and support for focused and hover
also adds e2e tests and adds them to screenshot

references #18279

brandyscarney added a commit that referenced this issue Jun 10, 2019

feat(back-button): add variables and support for focused and hover st…
…ates (#18451)

- updates MD spacing for back button text
- also adds e2e tests and adds them to screenshot

references #18279 references #17624 fixes #18465

abennouna added a commit to abennouna/ionic that referenced this issue Jun 11, 2019

feat(back-button): add variables and support for focused and hover st…
…ates (ionic-team#18451)

- updates MD spacing for back button text
- also adds e2e tests and adds them to screenshot

references ionic-team#18279 references ionic-team#17624 fixes ionic-team#18465

@brandyscarney brandyscarney moved this from In progress 🤺 to On deck ⚾️ in Ionic Core Jun 13, 2019

@brandyscarney brandyscarney added this to the Ionic for Desktop milestone Jun 13, 2019

@brandyscarney brandyscarney moved this from On deck ⚾️ to In progress 🤺 in Ionic Core Jun 24, 2019

brandyscarney added a commit that referenced this issue Jun 25, 2019

brandyscarney added a commit that referenced this issue Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.