Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: some elements like ion-header won't work with elm-lang #18444

Open
ciekawy opened this issue Jun 2, 2019 · 1 comment

Comments

Projects
None yet
4 participants
@ciekawy
Copy link
Contributor

commented Jun 2, 2019

Bug Report

Ionic version:

[x] 4.x

Current behavior:

Trying to use ionic with elm-lang may lead to "Cannot read property 'childNodes' of undefined" for some elements like ion-header due to the fact that underlying VDOM changes which makes elm-lang unable to track the reference.

Expected behavior:

predictable error-less behaviour for all ion elements

Steps to reproduce:

try to use ion-header in elm app.

Related code:

A sample application via GitHub: https://github.com/ciekawy/diegy

it's enough to use Ion.header around this place and run the app to see the error. https://github.com/ciekawy/diegy/blob/master/src/Main.elm#L192

Other information:

while there is definitely some conflict in the approach, it would be great to figure out a solution together with elm-lang community.

Corresponding report on the elm-lang side can be found here https://discourse.elm-lang.org/t/web-components-interop-childnode-issues/3730

Ionic info:

$ ionic info

Ionic:

   ionic (Ionic CLI)             : 4.10.2 (/Users/szymon/.nvm/versions/node/v10.13.0/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.0.2
   @angular-devkit/build-angular : 0.12.4
   @angular-devkit/schematics    : 7.2.4
   @angular/cli                  : 7.2.4
   @ionic/angular-toolkit        : 1.4.0

Cordova:

   cordova (Cordova CLI) : 8.1.2 (cordova-lib@8.1.1)
   Cordova Platforms     : android 7.1.4, browser 5.0.4, ios 4.5.4
   Cordova Plugins       : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 4.0.0, (and 17 other plugins)

System:

   ios-deploy : 2.0.0
   ios-sim    : 8.0.1
   NodeJS     : v10.13.0 (/Users/szymon/.nvm/versions/node/v10.13.0/bin/node)
   npm        : 6.9.0
   OS         : macOS Mojave
   Xcode      : Xcode 10.2.1 Build version 10E1001

@ionitron-bot ionitron-bot bot added the triage label Jun 2, 2019

@clojj

This comment has been minimized.

Copy link

commented Jun 4, 2019

https://github.com/ionic-team/ionic/blob/master/core/src/components/header/header.tsx

I guess it's because ion-header uses hostData() and thereby interferes with the DOM that Elm needs to have full control over.. ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.