Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: [Android] back button get's pushed out of toolbar #18465

Closed
carstenbaumhoegger opened this issue Jun 5, 2019 · 0 comments

Comments

2 participants
@carstenbaumhoegger
Copy link
Contributor

commented Jun 5, 2019

Bug Report

Ionic version:

[x] 4.x

Current behavior:

When I add text to a back button, the button itself get's pushed out of the page, only the text is shown. On iOS, the button is still visible.
When the text is removed, the back button is visible on both platforms.

Expected behavior:

Back button keeps visible, even if I add text.

Steps to reproduce:

  1. Use an Ionic page with a back button
  2. Add text to the back button manually

Related code:

<ion-header>
  <ion-toolbar>
    <ion-buttons slot="start">
      <ion-back-button defaultHref="/tabs/search" text="Zurück"></ion-back-button>
    </ion-buttons>
    <ion-title>Artikeltyp anzeigen</ion-title>
  </ion-toolbar>
</ion-header>

Other information:

Android:
image

iOS:
image

Ionic info:

Ionic:

   Ionic CLI                     : 5.0.0 (/usr/local/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.4.2
   @angular-devkit/build-angular : 0.13.9
   @angular-devkit/schematics    : 7.3.9
   @angular/cli                  : 7.3.9
   @ionic/angular-toolkit        : 1.5.1

Cordova:

   Cordova CLI       : 9.0.0 (cordova-lib@9.0.1)
   Cordova Platforms : android 8.0.0, ios 5.0.1
   Cordova Plugins   : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 4.0.1, (and 12 other plugins)

Utility:

   cordova-res : not installed
   native-run  : 0.2.2

System:

   ios-deploy : 1.9.4
   ios-sim    : 8.0.1
   NodeJS     : v10.15.3 (/usr/local/bin/node)
   npm        : 6.9.0
   OS         : macOS Mojave
   Xcode      : Xcode 10.2.1 Build version 10E1001

@ionitron-bot ionitron-bot bot added the triage label Jun 5, 2019

@ionitron-bot ionitron-bot bot removed the triage label Jun 5, 2019

@brandyscarney brandyscarney self-assigned this Jun 5, 2019

@brandyscarney brandyscarney added this to Backlog 🤖 in Ionic Core via automation Jun 5, 2019

@brandyscarney brandyscarney moved this from Backlog 🤖 to In progress 🤺 in Ionic Core Jun 5, 2019

Ionic Core automation moved this from In progress 🤺 to Done 🎉 Jun 10, 2019

brandyscarney added a commit that referenced this issue Jun 10, 2019

feat(back-button): add variables and support for focused and hover st…
…ates (#18451)

- updates MD spacing for back button text
- also adds e2e tests and adds them to screenshot

references #18279 references #17624 fixes #18465

abennouna added a commit to abennouna/ionic that referenced this issue Jun 11, 2019

feat(back-button): add variables and support for focused and hover st…
…ates (ionic-team#18451)

- updates MD spacing for back button text
- also adds e2e tests and adds them to screenshot

references ionic-team#18279 references ionic-team#17624 fixes ionic-team#18465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.