Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: navigateForward, navigateBack in navigation controller not passing options to angular router #18469

Closed
MarkChrisLevy opened this issue Jun 5, 2019 · 1 comment

Comments

2 participants
@MarkChrisLevy
Copy link
Contributor

commented Jun 5, 2019

Bug Report

When navigateForward or navigateBack is called with url as string or UrlTree, navigation options are not passed to angular router. When url is an array, options are passed properly.

Ionic version:
[x] 4.4.2

Current behavior:
When navigateForward or navigateBack is called with url as string or UrlTree, navigation options are not passed to angular router. When url is an array, options are passed properly.

Expected behavior:
Navigation options must be always passed to angular router.

Steps to reproduce:
navigateForward("/some/url", {replaceUrl: true});

Related code:

insert short code snippets here

Other information:

Ionic info:

Ionic 4.4.2
@liamdebeasi

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

Good catch -- thank you! I left you some comments on your PR. 🎉

@liamdebeasi liamdebeasi added this to Backlog 👀 in Ionic Angular via automation Jun 6, 2019

@liamdebeasi liamdebeasi moved this from Backlog 👀 to Needs Review 🤔 in Ionic Angular Jun 6, 2019

Ionic Angular automation moved this from Needs Review 🤔 to Done 🎉 Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.