Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ion-item-divider (iOS) has no "--padding-inline-end" variable #18484

Closed
davideas opened this issue Jun 7, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@davideas
Copy link

commented Jun 7, 2019

Bug Report

Ionic version:
4.4.2

Current behavior:
For element <ion-item-divider> when I set --padding-inline-end: 0; in the styles it doesn't not work for iOS because no variable exists for the padding-inline-end that now has 8px hard coded (no issues for Android):

image

Expected behavior:
Please make padding-inline-end a variable: --padding-inline-end

@ionitron-bot ionitron-bot bot added the triage label Jun 7, 2019

@davideas davideas changed the title bug: ion-item-divider has no "--padding-inline-end" variable bug: ion-item-divider (iOS) has no "--padding-inline-end" variable Jun 7, 2019

@brandyscarney

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

Thanks for the issue! The item-divider-inner code needs to be changed to use the following to match item:

  @include padding(
    var(--inner-padding-top),
    calc(var(--ion-safe-area-right, 0px) + var(--inner-padding-end)),
    var(--inner-padding-bottom),
    var(--inner-padding-start)
  );

@ionitron-bot ionitron-bot bot removed the triage label Jun 7, 2019

corollari added a commit to corollari/ionic that referenced this issue Jun 8, 2019

brandyscarney added a commit that referenced this issue Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.