Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ionic 4.6.0 Regressions #18655

Closed
brandyscarney opened this issue Jun 28, 2019 · 20 comments

Comments

@brandyscarney
Copy link
Member

commented Jun 28, 2019

Ionic 4.6.0 introduced some regressions due to the update to Stencil One. This issue is to track and resolve them for our hotfix release.

✔️ Issues that have been checked off have been resolved in Stencil or Ionic, but not yet released until 4.6.1 is out.

  • ion-infinite-scroll no longer firing ionInfinite event. Issue: #18632
  • ion-searchbar styling breaks when navigating to another page and then navigating back. Issue: #18642
  • Swipe to go back is broken
  • Overlay opts are now required, breaking some angular builds. Issue: #18631
  • white screen after updating. issue: #18649
  • ion-slide not working properly. Issue: #18633
  • scss files missing (add back to stencil config in Ionic): #18639
  • Disabled fab buttons no longer have opacity set #18682; PR #18685
  • Ionicons not loaded w/ baseHref: #18650 and #18637
  • target was removed from ion-router-link, PR #18659
  • Item is entirely disabled if checkbox is #18670
  • default tab not being selected #18689
  • content flashing when switching between tabs
  • cannot bind ion-icon name #18707

Reporting a Regression

If you are running into a bug that worked in 4.5.0 but is not working in 4.6.0 and is not in the list above please create a new issue:

  • Fill out the provided template with steps for us to reproduce
  • Provide the minimal amount of code needed to reproduce the issue in a starter
  • Or provide a simple code repository that only highlights the bug

Please tag @ionic-team/framework on the issue to bring it to our attention.

@ionitron-bot ionitron-bot bot added the triage label Jun 28, 2019

@brandyscarney brandyscarney pinned this issue Jun 28, 2019

@lincolnthree

This comment has been minimized.

Copy link

commented Jun 28, 2019

@brandyscarney I think I have another one. Haven't reproduced in a sample app yet, but <ion-img> does not reliably appear in 4.6.0 either. It's in the DOM but the image is never loaded (until the DOM is manually manipulated, height or width, etc, at which point it'll show up.) Working on condensing it into something reproducible.

brandyscarney added a commit that referenced this issue Jun 28, 2019

@brandyscarney brandyscarney referenced this issue Jun 28, 2019
6 of 13 tasks complete
@bashoogzaad bashoogzaad referenced this issue Jun 29, 2019
@tanoabeleyra

This comment has been minimized.

Copy link

commented Jun 30, 2019

ion-tabs seems to be broken too, there's no tab selected on first load.

image

@UTSOURCE

This comment has been minimized.

Copy link

commented Jul 1, 2019

image
4.6.0 The configuration here seems to be no longer working

@liamdebeasi

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

Hi @UTSOURCE and @tanoabeleyra,

Can you provide reproductions for these? I am not able to reproduce either.

Thanks!

@liamdebeasi

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

Hi everyone,

We published a nightly build of Ionic with these fixes. You can install it using the latest dev tag.

For Angular users: npm i @ionic/angular@dev
For Stencil + Ionic users: npm i @ionic/core@dev

Any feedback from testing this build is greatly appreciated!
Thanks!

@positlabs

This comment has been minimized.

Copy link

commented Jul 1, 2019

What were the regressions? Can we build tests against them?

@tanoabeleyra

This comment has been minimized.

Copy link

commented Jul 1, 2019

Hi @UTSOURCE and @tanoabeleyra,

Can you provide reproductions for these? I am not able to reproduce either.

Thanks!

I opened an issue: #18689.
I'm going to test the nightly build as soon as possible.

@peterpeterparker

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

@liamdebeasi I could confirm that #18632 aka the ionInfinite not fired issue is resolved, thx a lot 👍 (tested with core in a Stencil PWA)

@nerdic-coder

This comment has been minimized.

Copy link

commented Jul 1, 2019

I can confirm that "ion-slide not working properly. Issue: #18633" is resolved with the latest @ionic/core@dev

@ashinpaugh

This comment has been minimized.

Copy link

commented Jul 1, 2019

I've got a directive that I apply IonInput / IonTextAreas, the constructor of the directive receives an ElementRef. In v4.6.0 element.getInputElement returns an Object with two properties state and value. The value property holds the input element. After Reverting to v4.5.0 getInputElement returns the textarea or the input.

edit: cleared up my comment.

@petrot

This comment has been minimized.

Copy link

commented Jul 1, 2019

"ion-searchbar styling breaks" issue is resolved with the latest @ionic/core@dev!

Thank you!

@UTSOURCE

This comment has been minimized.

Copy link

commented Jul 2, 2019

@liamdebeasi
If you create a new 4.6.1 project or a 4.6.0 project, the configuration will be invalid.
Such as the following configuration

 IonicModule.forRoot({
            menuType: 'overlay',
            mode: 'ios',
            backButtonText: '',
            // swipeBackEnabled: false, 
            // _forceStatusbarPadding: true 
        }),
@liamdebeasi

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

@UTSOURCE,

As I mentioned in my previous comment, I am unable to reproduce the issue you are describing using the code snippet you have provided. Please provide a full reproduction of the issue (a link to a GitHub repo would be fine), and we can take a look.

Thanks! 🙂

brandyscarney added a commit that referenced this issue Jul 2, 2019

brandyscarney added a commit that referenced this issue Jul 2, 2019

@simion

This comment has been minimized.

Copy link

commented Jul 2, 2019

The workaround from this comment #15953 (comment) does not work anymore. Content renders partially, and it's damn ugly.
I had to rollback :(

@brandyscarney

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2019

If anyone is running into issues that worked in 4.5.0 but are not working in 4.6.0 or the latest dev build & not already in the original list please create a new issue and fill out the provided template with steps for us to reproduce. If we cannot reproduce the issue, we cannot fix it. Please help us by providing the minimal amount of code needed to reproduce the issue in a starter or a simple code repository that only highlights the bug. 🙂

Please tag @ionic-team/framework on the issue to bring it to our attention. I'd like to avoid back and forth comments here to reproduce issues since there are a lot of people subscribed to this issue.

Thank you!

@thiennm2905

This comment has been minimized.

Copy link

commented Jul 3, 2019

I use angular v7.1.2 and ionic v4.6
I code a base service, when I use http request, I create and present a Loading overlay, stop it by dismiss when finish by pipe(), it’s working on ionic v4.5, but in v4.6 it seem create more than one http request after one request finished when a change tab

@brandyscarney brandyscarney added this to Backlog 🤖 in Ionic Core via automation Jul 3, 2019

@ionitron-bot ionitron-bot bot removed the triage label Jul 3, 2019

@brandyscarney brandyscarney moved this from Backlog 🤖 to In progress 🤺 in Ionic Core Jul 3, 2019

@alaa-alshamy

This comment has been minimized.

Copy link

commented Jul 4, 2019

@brandyscarney
autoGrow directive also has a bug after 4.6.0 version, when enter characters in a textarea it's growing up but when remove them not shrinking back

@tmk1991

This comment has been minimized.

Copy link

commented Jul 5, 2019

I use a different infinite scroller than the ionic one but there are now issues with it in 4.6.0 that do not exist in 4.5.0.

  1. Similar to #18632, the bottom event is not firing for my infinite scroller. I think this may be related to and it's inner scroll container
  2. items seem to show for a brief second and then disappear when in the . These items are showing via *ngTemplateOutlet into the ion-content. Just bringing attention to this in case it's unrelated to #18632

I'll re-test the hotfix when released. If there continues to be a bunch of issues (aside from mine specifically), is there a possibility to back out stencil one from the ionic/angular package?

EDIT:

tried the latest dev kit and both issues still appear

Side note: the update from 4.4.0 to 4.4.1 brought some slower performance to items appearing and disappearing on the DOM. I'm thinking it's related to the angular change detection modifications made in 4.4.1. Not sure if that'll be resolved with the 4.6.X release. (should I make a separate issue for this specific side note issue?)

@brandyscarney

This comment has been minimized.

Copy link
Member Author

commented Jul 5, 2019

Hi all, we released a new dev build which should fix every issue listed in the original issue above. Please try it out and let us know: 4.6.1-dev.201907052128.7953088

Please make separate issues for anything found not in the original list, thank you!

@brandyscarney

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2019

Ionic 4.6.1 has been released, please update to this version if you are having any of the issues listed here: https://github.com/ionic-team/ionic/releases/tag/v4.6.1

I am going to close this since the original list is fixed, anyone having issues still please create a new issue, thank you!

Ionic Core automation moved this from In progress 🤺 to Done 🎉 Jul 9, 2019

@ionic-team ionic-team locked as resolved and limited conversation to collaborators Jul 9, 2019

@liamdebeasi liamdebeasi unpinned this issue Jul 11, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.