Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: iOS toolbar small title #18898

Closed
brandyscarney opened this issue Jul 25, 2019 · 2 comments · Fixed by #19215

Comments

@brandyscarney
Copy link
Member

commented Jul 25, 2019

Feature Request

Ionic version:

[x] 4.x

Describe the Feature Request

Add the iOS 13 subtitle to the toolbar:

"Choose a contact to add to Favorites"

Screen Shot 2019-07-25 at 5 28 04 PM

Related Code

Additional Context

@brandyscarney brandyscarney added this to the iOS Design Improvements milestone Jul 25, 2019
@brandyscarney brandyscarney added this to Backlog 🤖 in Ionic Core via automation Jul 25, 2019
brandyscarney added a commit that referenced this issue Aug 28, 2019
closes #18898
@brandyscarney brandyscarney referenced this issue Aug 28, 2019
6 of 13 tasks complete
brandyscarney added a commit that referenced this issue Aug 30, 2019
@brandyscarney

This comment has been minimized.

Copy link
Member Author

commented Sep 5, 2019

PR: #19215

Usage:

<ion-header>
  <ion-toolbar>
    <ion-title size="small">Choose a contact to add to Favorites</ion-title>
  </ion-toolbar>
  <ion-toolbar>
    <ion-title>Contacts</ion-title>
    <ion-buttons slot="end">
      <ion-button>Cancel</ion-button>
    </ion-buttons>
  </ion-toolbar>
  <ion-toolbar>
    <ion-searchbar></ion-searchbar>
  </ion-toolbar>
</ion-header>

Plan to get this in 4.10.0

@brandyscarney brandyscarney moved this from Backlog 🤖 to Needs review 🤔 in Ionic Core Sep 5, 2019
@brandyscarney brandyscarney changed the title feat: iOS toolbar sub title feat: iOS toolbar small title Sep 5, 2019
@brandyscarney brandyscarney removed this from the Next milestone Sep 5, 2019
Ionic Core automation moved this from Needs review 🤔 to Done 🎉 Sep 5, 2019
brandyscarney added a commit that referenced this issue Sep 5, 2019
Updates title to include `small` size and updates searchbar and UI to match native.

closes #18898
brandyscarney added a commit that referenced this issue Sep 16, 2019
Updates title to include `small` size and updates searchbar and UI to match native.

closes #18898
brandyscarney added a commit that referenced this issue Oct 2, 2019
Updates title to include `small` size and updates searchbar and UI to match native.

closes #18898
@ionitron-bot

This comment has been minimized.

Copy link

commented Oct 5, 2019

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Ionic Core
  
Done 🎉
1 participant
You can’t perform that action at this time.