Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: @ionic/core Electron is not recognized as a platform #19043

Closed
robingenz opened this issue Aug 8, 2019 · 1 comment

Comments

@robingenz
Copy link
Contributor

commented Aug 8, 2019

Bug Report

Ionic version:

[x] 4.x

Current behavior:

Electron is not recognized as a platform in my ionic v4 app inside Electron.

this.platform.is('electron') returns false.

this.platform.platforms() returns ["cordova", "mobile", "hybrid"].

Expected behavior:

Electron should be recognized as a platform.
this.platform.is('electron') should return true.

Steps to reproduce:

  1. cordova platform add cordova-electron
  2. cordova run cordova-electron
  3. console.log(this.platform.platforms()); in app.component.ts

Other information:

$ window.document.defaultView.navigator.userAgent
"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.128 Electron/4.2.9 Safari/537.36"

Related issue: #14517

Ionic info:

Ionic:

   Ionic CLI                     : 5.2.3
   Ionic Framework               : @ionic/angular 4.6.2
   @angular-devkit/build-angular : 0.13.9
   @angular-devkit/schematics    : 7.3.9
   @angular/cli                  : 7.3.9
   @ionic/angular-toolkit        : 1.5.1

Cordova:

   Cordova CLI       : 8.1.2 (cordova-lib@8.1.1)
   Cordova Platforms : android 7.1.4, cordova-electron 1.1.0
   Cordova Plugins   : cordova-plugin-ionic-keyboard 2.0.5, cordova-plugin-ionic-webview 2.3.3, (and 22 other plugins)

Utility:

   cordova-res : 0.6.0
   native-run  : 0.2.8

System:

 (C:\Users\robin.genz\AppData\Local\Android\android-sdk)
   NodeJS            : v10.15.0 (C:\Program Files\nodejs\node.exe)
   npm               : 6.10.3
   OS                : Windows 10

@ionitron-bot ionitron-bot bot added the triage label Aug 8, 2019

@robingenz robingenz referenced this issue Aug 8, 2019
2 of 13 tasks complete
@ionitron-bot

This comment has been minimized.

Copy link

commented Sep 7, 2019

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant
You can’t perform that action at this time.