Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Animcations in 4.8.1 errors: "undefined is not a function (near '...element.animate...')" #19205

Closed
morganswood opened this issue Aug 27, 2019 · 9 comments

Comments

@morganswood
Copy link

commented Aug 27, 2019

Bug Report

Ionic version:

[x] 4.x

Current behavior:
Navigation animations do not load correctly, ie: modals don't render and some navigations have choppy or non-existent animations.

Expected behavior:
Modals should load correctly and navigation should animate correctly.

Steps to reproduce:
Modals created do NOT animate or open properly.

Other information:
We reverted to 4.7.4 and the animations work and modals are now working correctly again.

Ionic info:


   Ionic CLI                     : 5.2.6
   Ionic Framework               : @ionic/angular 4.7.4 (/Users/morgan.wood/Source/CRM_WebApp/node_modules/@ionic/angular)
   @angular-devkit/build-angular : 0.12.4
   @angular-devkit/schematics    : 7.2.4
   @angular/cli                  : 7.3.9 (/Users/morgan.wood/Source/CRM_WebApp/node_modules/@angular/cli)
   @ionic/angular-toolkit        : 1.2.3 (/Users/morgan.wood/Source/CRM_WebApp/node_modules/@ionic/angular-toolkit)

Capacitor:

   Capacitor CLI   : 1.1.1
   @capacitor/core : 1.1.1 (/Users/morgan.wood/Source/CRM_WebApp/node_modules/@capacitor/core)

Cordova:

   Cordova CLI       : 9.0.0
   Cordova Platforms : ios 5.0.1
   Cordova Plugins   : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 4.0.1, (and 10 other plugins)

Utility:

   cordova-res : not installed
   native-run  : not installed

System:

   NodeJS : v12.9.0 (/usr/local/bin/node)
   npm    : 6.10.2
   OS     : macOS Mojave
   Xcode  : Xcode 10.3 Build version 10G8

@ionitron-bot ionitron-bot bot added the triage label Aug 27, 2019

@liamdebeasi

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

Thanks for the issue. Can you provide a code reproduction? Otherwise it's going to be difficult for us to fix this issue.

@ionitron-bot ionitron-bot bot removed the triage label Aug 28, 2019

@liamdebeasi

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

Actually I think I have a hunch as to what the issue might be. Give this dev build a try and let me know if it fixes your issue:

npm i @ionic/angular@4.9.0-dev.201908281552.5dcb9be

@ionitron-bot ionitron-bot bot added triage and removed needs: reply labels Aug 28, 2019

@ionitron-bot ionitron-bot bot removed the triage label Aug 28, 2019

@morganswood

This comment has been minimized.

Copy link
Author

commented Aug 28, 2019

It appears that your hunch was correct, thanks!

@ionitron-bot ionitron-bot bot added triage and removed needs: reply labels Aug 28, 2019

@liamdebeasi

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

Great! This fix will be available in the next stable release of Ionic. Until then, feel free to keep using this dev build.

liamdebeasi added a commit that referenced this issue Aug 28, 2019
@adamduren

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

@liamdebeasi Noticed this in production through our error reporting service for Safari browsers. Seems to be partially fixed in @ionic/angular@4.9.0-dev.201908281552.5dcb9be.

The explicit error on .animate being undefined no longer exists but my modal that is presented auto dismisses now. This behavior is not present on 4.7.4.

I will attempt to reproduce it in a starter project although I suspect it has to do with the fact that I 'm presenting two modals on top of each other.

@adamduren

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

Unable to reproduce in a starter project. Reverting to 4.7.4 for now until I am able to investigate further.

@liamdebeasi

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

Ok no problem. When you're able to reproduce feel free to open a new issue, and we can continue the conversation there. Thanks!

@goelectricstations

This comment has been minimized.

Copy link

commented Sep 4, 2019

same issue on 4.9.0 only if run on device from xcode

@liamdebeasi

This comment has been minimized.

Copy link
Member

commented Sep 4, 2019

@goelectricstations This issue has been closed. Please create a new issue if you are experiencing further problems. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.