Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: False positive on CSS deprecation warning #19499

Closed
cjpollard opened this issue Sep 30, 2019 · 0 comments · Fixed by #19535

Comments

@cjpollard
Copy link

commented Sep 30, 2019

Bug Report

Ionic version:
[x] 4.10.0

Current behavior:
Deprecation warning for CSS attributes generates false positive when using:
<ion-textarea wrap="soft"></ion-textarea>

Expected behavior:
Should ignore attributes with an assigned value.

Steps to reproduce:
Create an empty page with the above ion-textarea code. See warning appear in the console.

Related code:
See above.

Other information:

Ionic info:

Ionic:

   Ionic CLI                     : 5.2.3 (C:\Users\cpollard\AppData\Roaming\npm\node_modules\ionic)
   Ionic Framework               : @ionic/angular 4.10.0
   @angular-devkit/build-angular : 0.803.6
   @angular-devkit/schematics    : 8.3.6
   @angular/cli                  : 8.3.6
   @ionic/angular-toolkit        : 2.0.0

Cordova:

   Cordova CLI       : 9.0.0 (cordova-lib@9.0.1)
   Cordova Platforms : android 8.1.0
   Cordova Plugins   : cordova-plugin-ionic 5.4.4, cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 4.1.1, (and 16 other plugins)

Utility:

   cordova-res : 0.3.0 
   native-run  : 0.2.2

System:

   Android SDK Tools : 26.1.1 (C:\Users\cpollard\AppData\Local\Android\Sdk)
   NodeJS            : v12.11.0 (C:\Program Files\nodejs\node.exe)
   npm               : 6.11.3
   OS                : Windows 10
@ionitron-bot ionitron-bot bot added the triage label Sep 30, 2019
@brandyscarney brandyscarney added this to Backlog 🤖 in Ionic Core via automation Oct 2, 2019
@ionitron-bot ionitron-bot bot removed the triage label Oct 2, 2019
@brandyscarney brandyscarney moved this from Backlog 🤖 to Needs review 🤔 in Ionic Core Oct 2, 2019
brandyscarney added a commit that referenced this issue Oct 2, 2019
the wrap attribute is still deprecated from global CSS but it improperly throws errors on textarea where it's valid

fixes #19499
@brandyscarney brandyscarney moved this from Needs review 🤔 to Ready to Merge 🚀 in Ionic Core Oct 2, 2019
Ionic Core automation moved this from Ready to Merge 🚀 to Done 🎉 Oct 2, 2019
brandyscarney added a commit that referenced this issue Oct 2, 2019
the wrap attribute is still deprecated from global CSS but it improperly throws errors on textarea where it's valid

fixes #19499
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Ionic Core
  
Done 🎉
2 participants
You can’t perform that action at this time.