Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: 4.10.1 breaks ionViewDidEnter in modals #19576

Closed
7freaks-otte opened this issue Oct 8, 2019 · 6 comments

Comments

@7freaks-otte
Copy link

commented Oct 8, 2019

Bug Report

Ionic version:

[x] 4.10.1

Current behavior:

When a page is opened via modalCtrl ionViewDidEnter is not triggered anymore.

Expected behavior:

With the exact same code ionViewDidEnter is triggered in 4.10.0 and below.

@ionitron-bot ionitron-bot bot added the triage label Oct 8, 2019
@chrisbinnefeld

This comment has been minimized.

Copy link

commented Oct 8, 2019

Just wanted to create an issue about this topic.

I've created an stackblitz which is showcasing this bug: https://stackblitz.com/edit/ionic-v4-modal-didenter-bug

All lifecycles are called except ionViewDidEnter.

image

@liamdebeasi

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

Thanks for the issue. I am able to reproduce this. It looks like ionModalDidPresent is not firing, which may be why ionViewDidEnter does not fire. I am investigating and will update this thread when I have more to share.

@liamdebeasi

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

Can you all give this dev build a try, and let me know if it resolves the issue for your apps?

npm i @ionic/angular@4.11.0-dev.201910081329.02c1724

Thanks!

@chrisbinnefeld

This comment has been minimized.

Copy link

commented Oct 8, 2019

I can confirm that with @ionic/angular@4.11.0-dev.201910081329.02c1724 ionViewDidEnter is called again.

Thanks for the quick fix!

@7freaks-otte

This comment has been minimized.

Copy link
Author

commented Oct 8, 2019

Thanks this resolves my issue. ionViewDidEnter is called again.

@liamdebeasi liamdebeasi referenced this issue Oct 8, 2019
5 of 13 tasks complete
@liamdebeasi

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

This issue has been fixed and is available now in Ionic 4.10.2. Thanks!

@liamdebeasi liamdebeasi closed this Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.