Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: update angular-ui-router from 0.2.10 to 0.2.11 #2293

Closed
pellekrogholt opened this issue Sep 25, 2014 · 7 comments
Closed

feature request: update angular-ui-router from 0.2.10 to 0.2.11 #2293

pellekrogholt opened this issue Sep 25, 2014 · 7 comments

Comments

@pellekrogholt
Copy link

@pellekrogholt pellekrogholt commented Sep 25, 2014

currently ionic uses '"angular-ui-router": "0.2.10",' bower.json

what about getting a more recent version ? > 0.2.11

CHANGELOG.md

one motivation could be that its now possible to provide default parameters for a state

...
.state('app.setup', {
  url: '/setup/:target',
    params: {
      target: { value: 'some-default-value' }
    },
    ...

or have a optional param:

...
.state('app.setup', {
  url: '/setup/:target',
    params: {
      target: { value: null }
    },
    ...

long story:

@BondaCB
Copy link

@BondaCB BondaCB commented Sep 26, 2014

Wow, very interesting, it can be worth trying at least

@pushpak
Copy link

@pushpak pushpak commented Oct 22, 2014

👍

@didlich
Copy link

@didlich didlich commented Nov 3, 2014

+1, reasonable due to the BUG: uiView: Fixed infinite loop when is called .go() from a controller

@jgatjens
Copy link

@jgatjens jgatjens commented Nov 7, 2014

👍 works great !

@d65yan
Copy link

@d65yan d65yan commented Nov 15, 2014

also
uiSrefActive:

Also activate for child states. (bf163ad6, closes #818)

BREAKING CHANGE Since ui-sref-active now activates even when child states are active you may need to swap out your ui-sref-active with ui-sref-active-eq, thought typically we think devs want the auto inheritance.

uiSrefActiveEq: new directive with old ui-sref-active behavior

@ionitron-bot
Copy link

@ionitron-bot ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.