Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(action-sheet): header, subheader, and icon alignment better matches native ios #23322

Merged
merged 6 commits into from Jul 8, 2021

Conversation

liamdebeasi
Copy link
Member

@liamdebeasi liamdebeasi commented May 17, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #23317

What is the new behavior?

  • Header is now a heavier font weight when a sub header is present
  • Increased the font size of the subheader
  • Reduced the spacing between the bottom of header and top of subheader
  • Increased the spacing between the right edge of the icon and the left of the text in a button
native master action-sheet-align
IMG_8312 IMG_8317 IMG_8321
IMG_8311 IMG_8316 IMG_8320

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label May 17, 2021
@liamdebeasi
Copy link
Member Author

The sub header screenshot diff (https://screenshot.ionicframework.com/6bfe1ce/6363d14#diff-9546bcdc) will be addressed by #23318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: action sheet header and subheader are not aligned/sized properly on ios
1 participant