Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
refactor(item): replaced attributes with item-start / item-end #11125
Short description of what this resolves:
Ambiguity in RTL projects.
Changes proposed in this pull request:
Ionic Version: 3.1.x
@manucorporat That is possible, although, I have no idea what to do with:
And where exactly to add the deprecation message.
The other thing for support, is just the 16
Do I also need to add /** @deprecated **/ above
I think this should behave the same everywhere:
This would make it so there are no breaking changes, and it improves support.
@brandyscarney While I agree with you on
On this one, I really believe there should be a deprecation for
Side note: I've seen you reviewed most rtl PRs. Can you please review this one as well? #11121