New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rtl): change item reorder offset for RTL #11395

Merged
merged 1 commit into from Apr 30, 2017

Conversation

Projects
None yet
3 participants
@AmitMY
Member

AmitMY commented Apr 27, 2017

Short description of what this resolves:

Item reordering is incorrect in RTL

Changes proposed in this pull request:

  • add 100 instead of subtract 100 when RTL

Ionic Version: 3.x

Fixes: #11211

@manucorporat manucorporat merged commit 665e44f into ionic-team:master Apr 30, 2017

@manucorporat

This comment has been minimized.

Show comment
Hide comment
@manucorporat

manucorporat Apr 30, 2017

Member

@AmitMY thanks a lot!

Member

manucorporat commented Apr 30, 2017

@AmitMY thanks a lot!

@alaa-alshamy

This comment has been minimized.

Show comment
Hide comment
@alaa-alshamy

alaa-alshamy May 6, 2017

@AmitMY this also need reverse transition of the reorder button to make it come from left to right now it's coming from right to left so it's coming almost from the center of item

alaa-alshamy commented May 6, 2017

@AmitMY this also need reverse transition of the reorder button to make it come from left to right now it's coming from right to left so it's coming almost from the center of item

@AmitMY

This comment has been minimized.

Show comment
Hide comment
@AmitMY

AmitMY May 6, 2017

Member

@alaa-alshamy Gestures and transitions support will come sometime soon. Currently mostly working on UI.
If you have some free time, can you make a PR for it?

Member

AmitMY commented May 6, 2017

@alaa-alshamy Gestures and transitions support will come sometime soon. Currently mostly working on UI.
If you have some free time, can you make a PR for it?

@alaa-alshamy

This comment has been minimized.

Show comment
Hide comment
@alaa-alshamy

alaa-alshamy May 8, 2017

@AmitMY ok np i can, but should i make new one? because it's actually related with this pull request

alaa-alshamy commented May 8, 2017

@AmitMY ok np i can, but should i make new one? because it's actually related with this pull request

@AmitMY

This comment has been minimized.

Show comment
Hide comment
@AmitMY

AmitMY May 8, 2017

Member

Because this was already merged, yes, a new one

Member

AmitMY commented May 8, 2017

Because this was already merged, yes, a new one

@alaa-alshamy

This comment has been minimized.

Show comment
Hide comment
@alaa-alshamy

alaa-alshamy May 8, 2017

ok i will as soon as possible

alaa-alshamy commented May 8, 2017

ok i will as soon as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment