Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(picker): fix iOS picker options that shouldn't be showing #16055

Merged
merged 1 commit into from Oct 24, 2018

Conversation

@adamdbradley
Copy link
Member

commented Oct 24, 2018

No description provided.

@ionitron-bot

This comment has been minimized.

Copy link

commented Oct 24, 2018

Screenshot Report 🔎📱

test device images pixels
loading: standalone iPhone 1210799
datetime: standalone, should open basic picker Android 864498
popover: standalone Android 38558
segment: standalone Android 24025
segment: modes Android 17741
segment: basic Android 4048
radio: basic iPhone 1777
datetime: standalone, should open basic picker iPhone 1701
action-sheet: alertFromActionSheet, alert open iPhone 1442
radio-group: standalone Android 1352

4 mismatched screenshots not shown. See the full comparison.


💙 - Ionitron

@adamdbradley adamdbradley merged commit 02ef52b into master Oct 24, 2018

7 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-core Your tests passed on CircleCI!
Details
ci/circleci: test-core-clean-build Your tests passed on CircleCI!
Details
ci/circleci: test-core-lint Your tests passed on CircleCI!
Details
ci/circleci: test-core-screenshot Your tests passed on CircleCI!
Details
ci/circleci: test-core-spec Your tests passed on CircleCI!
Details
ci/circleci: test-core-treeshake Your tests passed on CircleCI!
Details

@adamdbradley adamdbradley deleted the picker-ios branch Oct 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.