Join GitHub today
feat(checkbox): implement indeterminate state #16951
Short description of what this resolves:
Implements an indeterminate state for checkboxes.
Changes proposed in this pull request:
This adds an
For MD styles I followed Material specs (see section "Parent and child checkboxes") and the Material Components for Web implementation to implement the dash according to the specs. For iOS styles I had a look at https://github.com/Marxon13/M13Checkbox.
Should I add an E2E test for the most common use case of it, which is a nested tree of checkboxes? That's why I'm submitting this anyway, because we need it for our work.
One change I am not totally sure about is that I had to remove
@brandyscarney could you have a look at this please? We want to use this in our app and would prefer
I can work on getting this PR ready if any changes are required.
I made some changes to the CSS to add back some things that were removed. I believe
I added a native indeterminate checkbox example to the test here:
This shows that our determinate checkboxes are behaving the same as native. I also added a parent/child example and it seems to be working as expected.
Please let me know if you're seeing any problems with my changes, otherwise it should be good to go. Thank you!!