Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controllers): pass props and data to components #17188

Merged
merged 4 commits into from Feb 28, 2019

Conversation

Projects
None yet
2 participants
@michaeltintiuc
Copy link
Contributor

commented Jan 21, 2019

When passing data to ionic controllers only the props where being picked up, the suggested change allows for both props and data to be altered.

@ionitron-bot ionitron-bot bot added the package: vue label Jan 21, 2019

@jthoms1 jthoms1 self-assigned this Feb 12, 2019

@brandyscarney brandyscarney changed the title Fix passing props and data to components fix(controllers): pass props and data to components Feb 12, 2019

@jthoms1

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2019

@michaeltintiuc Can you update this branch from master? Other than that it looks good.

@michaeltintiuc

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

@jthoms1 done!

@jthoms1 jthoms1 merged commit 2ce4940 into ionic-team:master Feb 28, 2019

1 check passed

build Workflow: build
Details

KillerCodeMonkey added a commit to KillerCodeMonkey/ionic that referenced this pull request Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.