Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(refresher): check for cancelable before preventing default #17351

Merged
merged 15 commits into from Mar 1, 2019

Conversation

Projects
None yet
4 participants
@BoyeMagnus
Copy link
Contributor

commented Feb 1, 2019

Add check before preventing event.

Short description of what this resolves:

Resolves the following issue, where an error was thrown, because the event wasn't cancelable.

Changes proposed in this pull request:

  • Add check before preventing the event

Ionic Version: Latest

Fixes: #15256

Fix error with refresher
Add check before preventing event.

@ionitron-bot ionitron-bot bot added the package: core label Feb 1, 2019

BoyeMagnus added some commits Feb 1, 2019

@BoyeMagnus BoyeMagnus changed the title Fix error with refresher Fix preventDefault error with refresher Feb 2, 2019

BoyeMagnus added some commits Feb 2, 2019

@brandyscarney brandyscarney changed the title Fix preventDefault error with refresher fix(refresher): check for cancelable before preventing default Feb 12, 2019

@brandyscarney brandyscarney requested a review from manucorporat Feb 12, 2019

brandyscarney and others added some commits Feb 12, 2019

@liamdebeasi
Copy link
Member

left a comment

Thanks for the PR! 🎉

liamdebeasi and others added some commits Feb 27, 2019

@brandyscarney brandyscarney merged commit f205b10 into ionic-team:master Mar 1, 2019

1 check passed

build Workflow: build
Details
@brandyscarney

This comment has been minimized.

Copy link
Member

commented Mar 1, 2019

Thank you!

@BoyeMagnus

This comment has been minimized.

Copy link
Contributor Author

commented Mar 4, 2019

No problem. Thanks for the merge 🙌

michaeltintiuc added a commit to ModusCreateOrg/ionic that referenced this pull request Mar 4, 2019

fix(refresher): check for cancelable before preventing default (ionic…
…-team#17351)

fixes ionic-team#15256

Add loading controller vue docs

Add ion-tabs support, QOL fixes

Fix @ionic/core version, rebuild core to include docs

Update router
@mohamedsharaf

This comment has been minimized.

Copy link

commented Mar 19, 2019

the same issue exists in the ion-slides

ionic v 4.1.1

@liamdebeasi

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

Hi there,

Please open a new issue if you are running into an problem with ion-slides.

Thanks!

@ionic-team ionic-team locked and limited conversation to collaborators Mar 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.