Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): change height to max height on input #17394

Merged
merged 13 commits into from Mar 19, 2019

Conversation

Projects
None yet
3 participants
@romulocintra
Copy link
Contributor

commented Feb 5, 2019

Short description of what this resolves:

This PR tries to add the same behavior in Chrome, Safari and FF, when the input is not wrapped in html tags : see example with different browsers
https://glitch.com/edit/#!/regular-magician?path=index.html:5:8

Changes proposed in this pull request:

  • change height : 100% to max-height : 100%
fix input height on Chrome
This PR gives the same behavior in Chrome, Safari and FF, when the input is not wrapped in html tags :  see example with different browsers

https://glitch.com/edit/#!/regular-magician?path=index.html:5:8

@ionitron-bot ionitron-bot bot added the package: core label Feb 5, 2019

@brandyscarney brandyscarney changed the title Fix input height on Chrome and Safari fix(input): change height to max height on input Feb 12, 2019

brandyscarney added some commits Feb 12, 2019

@brandyscarney brandyscarney requested a review from manucorporat Feb 12, 2019

romulocintra and others added some commits Feb 13, 2019

@brandyscarney brandyscarney requested a review from liamdebeasi Mar 15, 2019

@brandyscarney brandyscarney removed the request for review from manucorporat Mar 15, 2019

@liamdebeasi
Copy link
Member

left a comment

Thanks for the PR! 👍

@brandyscarney brandyscarney merged commit 67a9137 into ionic-team:master Mar 19, 2019

1 check passed

build Workflow: build
Details
@brandyscarney

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

Thanks! 🎉

Kiku-git added a commit to Kiku-git/ionic that referenced this pull request May 16, 2019

fix(input): use max-height for input for consistency across browsers (i…
…onic-team#17394)

This PR gives the same behavior in Chrome, Safari and FF, when the input is not wrapped in html tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.